felixfoertsch/webextensions-examples
1
0
Fork 0
mirror of https://github.com/mdn/webextensions-examples.git synced 2026-04-16 06:18:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #25 from mdn/ua-rewriter-review

Browse Source 
fix review comments for user-agent-rewriter
This commit is contained in:
wbamberg
2016-01-06 11:39:40 -08:00
parent 5eabe6d166 847a3ab16f
commit 334496d8e7
4 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
user-agent-rewriter/background.js
View File

@@ -23,8 +23,6 @@ function rewriteUserAgentHeader(e) {
return {requestHeaders: e.requestHeaders};
}
chrome.runtime.onMessage.addListener(setUaString);
function setUaString(message) {
ua = uaStrings[message.uaString];
function setUaString(uaString) {
ua = uaStrings[uaString];
}

15
user-agent-rewriter/popup/choose_ua.css
View File

@@ -1,14 +1,19 @@
html, body {
html, body, .ua-choices {
height: 100px;
width: 100px;
width: 120px;
margin: 0;
}
.ua-choices {
display: flex;
flex-direction: column;
justify-content: space-around;
}
.ua-choice {
height: 20%;
width: 90%;
margin: 3% auto;
padding: 8% 6% 0 6%;
margin: 0.2em;
padding: 0.2em;
background-color: #E5F2F2;
cursor: pointer;
}

8
user-agent-rewriter/popup/choose_ua.html
View File

@@ -8,9 +8,11 @@
<body>
<div class="ua-choice">Firefox 41</div>
<div class="ua-choice">Chrome 41</div>
<div class="ua-choice">IE 11</div>
<div class="ua-choices">
<div class="ua-choice">Firefox 41</div>
<div class="ua-choice">Chrome 41</div>
<div class="ua-choice">IE 11</div>
</div>
<script src="choose_ua.js"></script>
</body>

7
user-agent-rewriter/popup/choose_ua.js
View File

@@ -4,9 +4,6 @@ document.addEventListener("click", function(e) {
}
var chosenUa = e.target.textContent;
chrome.runtime.sendMessage({
"command": "set-user-agent",
"uaString": chosenUa
});
var backgroundPage = chrome.extension.getBackgroundPage();
backgroundPage.setUaString(chosenUa);
});