From 34e66898471a713eba36a39158ec459fff7f7cbf Mon Sep 17 00:00:00 2001 From: Will Bamberg Date: Tue, 5 Jan 2016 15:29:53 -0800 Subject: [PATCH 1/2] review changes for user-agent-rewriter --- user-agent-rewriter/background.js | 6 ++---- user-agent-rewriter/popup/choose_ua.css | 13 +++++++++---- user-agent-rewriter/popup/choose_ua.html | 8 +++++--- user-agent-rewriter/popup/choose_ua.js | 7 ++----- 4 files changed, 18 insertions(+), 16 deletions(-) diff --git a/user-agent-rewriter/background.js b/user-agent-rewriter/background.js index 545d35a..8ef8a39 100644 --- a/user-agent-rewriter/background.js +++ b/user-agent-rewriter/background.js @@ -23,8 +23,6 @@ function rewriteUserAgentHeader(e) { return {requestHeaders: e.requestHeaders}; } -chrome.runtime.onMessage.addListener(setUaString); - -function setUaString(message) { - ua = uaStrings[message.uaString]; +function setUaString(uaString) { + ua = uaStrings[uaString]; } diff --git a/user-agent-rewriter/popup/choose_ua.css b/user-agent-rewriter/popup/choose_ua.css index 2815fd5..2e2f3b7 100644 --- a/user-agent-rewriter/popup/choose_ua.css +++ b/user-agent-rewriter/popup/choose_ua.css @@ -1,14 +1,19 @@ -html, body { +html, body, .ua-choices { height: 100px; width: 100px; margin: 0; } +.ua-choices { + display: flex; + flex-direction: column; + justify-content: space-around; +} + .ua-choice { height: 20%; - width: 90%; - margin: 3% auto; - padding: 8% 6% 0 6%; + margin: 0.2em; + padding: 0.2em; background-color: #E5F2F2; cursor: pointer; } diff --git a/user-agent-rewriter/popup/choose_ua.html b/user-agent-rewriter/popup/choose_ua.html index 6f5cee3..837307d 100644 --- a/user-agent-rewriter/popup/choose_ua.html +++ b/user-agent-rewriter/popup/choose_ua.html @@ -8,9 +8,11 @@ -
Firefox 41
-
Chrome 41
-
IE 11
+
+
Firefox 41
+
Chrome 41
+
IE 11
+
diff --git a/user-agent-rewriter/popup/choose_ua.js b/user-agent-rewriter/popup/choose_ua.js index f7d4f88..a8321f7 100644 --- a/user-agent-rewriter/popup/choose_ua.js +++ b/user-agent-rewriter/popup/choose_ua.js @@ -4,9 +4,6 @@ document.addEventListener("click", function(e) { } var chosenUa = e.target.textContent; - - chrome.runtime.sendMessage({ - "command": "set-user-agent", - "uaString": chosenUa - }); + var backgroundPage = chrome.extension.getBackgroundPage(); + backgroundPage.setUaString(chosenUa); }); From 847a3ab16f67551ea53e17df4420865c7234123c Mon Sep 17 00:00:00 2001 From: Will Bamberg Date: Wed, 6 Jan 2016 09:46:53 -0800 Subject: [PATCH 2/2] increase popup width --- user-agent-rewriter/popup/choose_ua.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/user-agent-rewriter/popup/choose_ua.css b/user-agent-rewriter/popup/choose_ua.css index 2e2f3b7..9e15677 100644 --- a/user-agent-rewriter/popup/choose_ua.css +++ b/user-agent-rewriter/popup/choose_ua.css @@ -1,6 +1,6 @@ html, body, .ua-choices { height: 100px; - width: 100px; + width: 120px; margin: 0; }