Instructs user to view console output via "Inspect" button on extensions page, since there was no output using the previous instructions.
Additionally, updates expected output.
The `new URL(url)` statement will throw an error if the supplied
string is not a valid URL. Adding a note to the function to clarify
that as requested by @Rob--W.
By using the URL interface, the user is ascertained that the piece of
code does not manipulate the DOM. Keeping them in the right mental
context for the example.
The apply-css example uses the protocol of the URL of the tab to
determine if a pageAction should be shown. Any page that is hosted
over http or https will receive the page action.
The former implementation creates an anchor tag, assigns the URL to
that, and fetches the protocol from there. This PR alters that to
using the URL interface. This makes it clear to the user that we're
staying in JavaScript land and will not start manipulating the visible
DOM. I would argue this is cleaner all together, but I'm very open to
learning about a different opinion.
The URL interface is more broadly supported than the
pageAction.setIcon which this example is also dependent on, so this
change should not change compatibility of this Browser Extension.
* Remove required theme aliases
Replaced uses of headerURL, accentcolor, and textcolor with theme_frame, frame, and tab_background_text. Tested and confirmed all extensions working as expected.
* Fixed another reference to headerURL
Co-authored-by: Richard Bloor <rbloor@atlassian.com>
* New user script example
This PR is the content from [PR 426](https://github.com/mdn/webextensions-examples/pull/426), originally submitted by Irene, addressing the feedback on the readme content.
* Including the following changes:
* renaming the content script example and updating the readme file to reference the user script example
* renaming the user script example and versioning as v1
* addressing feedback on the user script example: limiting input to hosts and script, addressing code and HTML/CSS comments
I haven't changed the "eating" script example, I feel it is useful to have similar demonstrations in the content and user script examples to make it easier for developers to compare and contrast.
* Various changes for feedback
* Added a user script ID that is stored in the registered script's metadata and then used in the API script to key the data stored in local storage
* Update to emphasize scoping of local storage using an ID provided in the user script metadata
Co-authored-by: Richard Bloor <rbloor@atlassian.com>
* read-me-updates
In addition to some general improvements to the text, this change focuses on adding notes about:
* checking the readme file for any limitations on domains or pages the extension works in
* the fact that no extension runs in a private window by default, with a link to related help article
* contacting the discourse forum as a first point of call for issues
* Minor changes from readthrough
chilloutandwatchsomecatgifs.com now appears to serve ads. Replaced the link open on activating the page action with https://giphy.com/explore/cat. Also made some minor improvements to the readme file.
* proxy-blocker updates
These changes replace the use of the deprecated `proxy.register` (PAC file) with `proxy.onRequest` to handle the proxying of requests.
* Changes as per feedback
* Fixed typo
* Addressed feedback relating to issue with variable initialization after enable/disable
* Typo fix
* The changes as suggested by @wbamberg
Changes to account for the fact that "headerURL":, "accentcolor":, and "textcolor": have been replaced by "theme_frame": , "frame":, and "tab_text": respectively. In addition, removed the empty.png image files, as these are no longer needed. Also added an example of use of theme_inactive to weta_tiled.
