felixfoertsch/webextensions-examples
1
0
Fork 0
mirror of https://github.com/mdn/webextensions-examples.git synced 2026-04-17 14:59:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Updates to the webpacked example (#200)

Browse Source 
* Notes on AMO reviews, update to webpack 2 and use better reset style for panel footer button

* Link to webpack-webext-plugin in live-dev section
This commit is contained in:
Martin Giger
2017-04-10 23:14:19 +02:00
committed by wbamberg
parent f749846e3a
commit ec034f70a2
4 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
webpack-modules/README.md
View File

@@ -38,4 +38,10 @@ personal choice about your preferred tool.
## Live-development
As well as watching the folder with your `manifest.json` in it, you will also
have to run webpack in watch mode.
have to run webpack in watch mode. You can use the
[webpack-webext-plugin](https://github.com/rpl/webpack-webext-plugin) to simplify the workflow.
## On addons.mozilla.org Reviews
Files generated by webpack and friends are compiled files. You have to [upload the source](https://developer.mozilla.org/en-US/Add-ons/AMO/Policy/Reviews#Source_Code_Submission) you generated your extension from to AMO for review of a listed extension. This will mean that your extension has to be reviewed by an admin reviewer, which will result in a longer wait time in queue.
To make the review easier, you can exclude third-party libraries from your output and directly ship the original distribution files for the libraries. This allows AMO to automatically recognize libraries and mark them as safe. This can be achieved with [externals](https://webpack.js.org/configuration/externals/) in the configuration for webpack.