diff --git a/webpack-modules/README.md b/webpack-modules/README.md index 5fbeef5..eaf5d1b 100644 --- a/webpack-modules/README.md +++ b/webpack-modules/README.md @@ -38,4 +38,10 @@ personal choice about your preferred tool. ## Live-development As well as watching the folder with your `manifest.json` in it, you will also -have to run webpack in watch mode. +have to run webpack in watch mode. You can use the +[webpack-webext-plugin](https://github.com/rpl/webpack-webext-plugin) to simplify the workflow. + +## On addons.mozilla.org Reviews +Files generated by webpack and friends are compiled files. You have to [upload the source](https://developer.mozilla.org/en-US/Add-ons/AMO/Policy/Reviews#Source_Code_Submission) you generated your extension from to AMO for review of a listed extension. This will mean that your extension has to be reviewed by an admin reviewer, which will result in a longer wait time in queue. + +To make the review easier, you can exclude third-party libraries from your output and directly ship the original distribution files for the libraries. This allows AMO to automatically recognize libraries and mark them as safe. This can be achieved with [externals](https://webpack.js.org/configuration/externals/) in the configuration for webpack. diff --git a/webpack-modules/addon/popup/style.css b/webpack-modules/addon/popup/style.css index 463a919..5b1c6aa 100644 --- a/webpack-modules/addon/popup/style.css +++ b/webpack-modules/addon/popup/style.css @@ -39,4 +39,8 @@ input[type="number"]:focus { /* Reset the default styles for buttons if it's a footer button */ button.panel-section-footer-button { padding: 12px; + border: none; + margin: 0; + box-shadow: none; + background-color: none; } diff --git a/webpack-modules/package.json b/webpack-modules/package.json index c4915ed..7031cad 100644 --- a/webpack-modules/package.json +++ b/webpack-modules/package.json @@ -8,7 +8,7 @@ }, "license": "MPL-2.0", "devDependencies": { - "webpack": "^1.13.1" + "webpack": "^2.3.2" }, "dependencies": { "left-pad": "^1.1.1" diff --git a/webpack-modules/webpack.config.js b/webpack-modules/webpack.config.js index 03bf28d..e19012a 100644 --- a/webpack-modules/webpack.config.js +++ b/webpack-modules/webpack.config.js @@ -1,10 +1,12 @@ +const path = require("path"); + module.exports = { entry: { background_scripts: "./background_scripts/background.js", popup: "./popup/left-pad.js" }, output: { - path: "addon", + path: path.resolve(__dirname, "addon"), filename: "[name]/index.js" } };