felixfoertsch/webextensions-examples
1
0
Fork 0
mirror of https://github.com/mdn/webextensions-examples.git synced 2026-04-17 06:48:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

improve link detection in notify-link-clicks-i18n

Browse Source 
Original approach is a bit too naive and misses all links
that contain other elements which can grab mouse clicks.
E. g. simple target checking fails on the grid @ mozilla.org.

Traversing up the tree to look for valid links fixes this problem.
This commit is contained in:
Mindaugas Jakutis
2016-01-05 22:42:10 +02:00
parent 4d5fef4423
commit 933d5df99d
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
notify-link-clicks-i18n/content-script.js
View File

@@ -1,9 +1,13 @@
window.addEventListener("click", notifyExtension);
function notifyExtension(e) {
console.log("content script sending message");
if (e.target.tagName != "A") {
return;
var target = e.target;
while ((target.tagName != "A" || !target.href) && target.parentNode) {
target = target.parentNode;
}
chrome.runtime.sendMessage({"url": e.target.href});
if (target.tagName != "A")
return;
console.log("content script sending message");
chrome.runtime.sendMessage({"url": target.href});
}