felixfoertsch/webextensions-examples
1
0
Fork 0
mirror of https://github.com/mdn/webextensions-examples.git synced 2026-04-16 06:18:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix review comments, and display a message if there were no downloads

Browse Source
This commit is contained in:
Will Bamberg
2016-05-17 13:50:21 -07:00
parent 4a2498a7a7
commit 45bce03262
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
latest-download/popup/latest_download.js
View File

@@ -6,6 +6,11 @@ Callback from getFileIcon.
Log an error, or initialize the displayed icon.
*/
function updateIconUrl(iconUrl) {
/*
If there was an error getting the icon URL,
then lastError will be set. So check lastError
and handle it.
*/
if (chrome.runtime.lastError) {
console.error(chrome.runtime.lastError);
iconUrl = "";
@@ -22,12 +27,13 @@ If there was a download item,
If there wasn't a download item, disable the "open" and "remove" buttons.
*/
function initializeLatestDownload(downloadItems) {
var downloadUrl = document.querySelector("#url");
if (downloadItems.length > 0) {
latestDownloadId = downloadItems[0].id;
chrome.downloads.getFileIcon(latestDownloadId, updateIconUrl);
var downloadUrl = document.querySelector("#url");
downloadUrl.textContent = downloadItems[0].url;
} else {
downloadUrl.textContent = "No downloaded items found."
document.querySelector("#open").disabled = true;
document.querySelector("#remove").disabled = true;
}
@@ -46,7 +52,6 @@ Open the item using the associated application.
*/
function openItem() {
chrome.downloads.open(latestDownloadId);
window.close();
}
/*
@@ -58,8 +63,5 @@ function removeItem() {
window.close();
}
var openItemButton = document.querySelector("#open");
openItemButton.addEventListener("click", openItem);
var removeItemButton = document.querySelector("#remove");
removeItemButton.addEventListener("click", removeItem);
document.querySelector("#open").addEventListener("click", openItem);
document.querySelector("#remove").addEventListener("click", removeItem);