felixfoertsch/tildes
1
0
Fork 0
mirror of https://gitlab.com/tildes/tildes.git synced 2026-04-16 06:18:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use "outer" sizes for checking dropdown overflow

Browse Source 
The "outer" width/height functions also include padding and border. Not
including these didn't make a noticeable difference for the left/right
flipping (the omissions almost canceled each other out), but the
discrepancy is much more noticeable on the top/bottom flipping.
This commit is contained in:
Deimos
2020-07-21 15:15:57 -06:00
parent ca38cd67fd
commit e84c90533b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tildes/static/js/behaviors/dropdown-toggle.js
View File

@@ -32,12 +32,12 @@ $.onmount(".dropdown-toggle", function() {
.parent()
.toggleClass(
"dropdown-right",
$this.offset().left + $this.width() - $menu.width() > 0
$this.offset().left + $this.outerWidth() - $menu.outerWidth() > 0
);
// If the menu extends past the bottom of the viewport, or the site footer
// overlaps the menu, push the menu above the button instead.
var menuBottom = $this.offset().top + $this.height() + $menu.height();
var menuBottom = $this.offset().top + $this.outerHeight() + $menu.outerHeight();
var viewportHeight = $(window).height();
var scrollTop = $(document).scrollTop();
var footerTop = $("#site-footer").offset().top;