chore: use path/filepath for local file system paths (#10705 )

### Purpose `path` is for slash-separated paths (URLs, BEP protocol); local file system paths should use `path/filepath`. Fixed in `cmd/stdiscosrv/database.go` (3 sites) and `internal/db/sqlite/db_test.go` (1 site). ### Testing `go build ./cmd/stdiscosrv/...` and `go vet` pass. Signed-off-by: Yasuhiro Matsumoto <mattn.jp@gmail.com>
fix(stcrashreceiver): close source loader responses on errors (#10704 )
2026-05-23 22:31:33 +02:00 · 2026-05-23 13:50:03 +00:00 · 2026-05-23 12:00:07 +02:00 · 2026-05-23 09:36:25 +02:00
4 changed files with 8 additions and 9 deletions
@@ -164,7 +164,7 @@ jobs:
    needs:
      - build-test
      - package-linux
-      # - package-illumos
+      - package-illumos
      - package-cross
      - package-source
      - package-debian
@@ -646,7 +646,7 @@ jobs:
    needs:
      - codesign-windows
      - package-linux
-      # - package-illumos
+      - package-illumos
      - package-macos
      - package-cross
      - package-source
@@ -85,13 +85,13 @@ func (l *githubSourceCodeLoader) Load(filename string, line, context int) ([][]b
 			metricSourceCodeLoadsTotal.WithLabelValues("failed").Inc()
 			return nil, 0
 		}
+		defer resp.Body.Close()
 		if resp.StatusCode != http.StatusOK {
 			fmt.Println("Loading source:", resp.Status)
 			metricSourceCodeLoadsTotal.WithLabelValues("failed").Inc()
 			return nil, 0
 		}
 		data, err := io.ReadAll(resp.Body)
-		_ = resp.Body.Close()
 		if err != nil {
 			fmt.Println("Loading source:", err.Error())
 			metricSourceCodeLoadsTotal.WithLabelValues("failed").Inc()
@@ -15,7 +15,7 @@ import (
 	"io"
 	"log/slog"
 	"os"
-	"path"
+	"path/filepath"
 	"runtime"
 	"slices"
 	"strings"
@@ -77,7 +77,7 @@ func newInMemoryStore(dir string, flushInterval time.Duration, blobs blob.Store)
 			slog.Error("Failed to find database in blob storage", "error", cerr)
 			return s
 		}
-		fd, cerr := os.Create(path.Join(s.dir, "records.db"))
+		fd, cerr := os.Create(filepath.Join(s.dir, "records.db"))
 		if cerr != nil {
 			slog.Error("Failed to create database file", "error", cerr)
 			return s
@@ -257,7 +257,7 @@ func (s *inMemoryStore) write() (err error) {
 		}
 	}()

-	dbf := path.Join(s.dir, "records.db")
+	dbf := filepath.Join(s.dir, "records.db")
 	fd, err := os.Create(dbf + ".tmp")
 	if err != nil {
 		return err
@@ -340,7 +340,7 @@ func (s *inMemoryStore) write() (err error) {
 }

 func (s *inMemoryStore) read() (int, error) {
-	fd, err := os.Open(path.Join(s.dir, "records.db"))
+	fd, err := os.Open(filepath.Join(s.dir, "records.db"))
 	if err != nil {
 		return 0, err
 	}
@@ -13,7 +13,6 @@ import (
 	"errors"
 	"iter"
 	"os"
-	"path"
 	"path/filepath"
 	"sync"
 	"testing"
@@ -1168,7 +1167,7 @@ func TestOpenSpecialName(t *testing.T) {

 	// Create a "base" dir that is in the way if the path becomes
 	// incorrectly truncated in the next steps.
-	base := path.Join(dir, "test")
+	base := filepath.Join(dir, "test")
 	if err := os.Mkdir(base, 0o755); err != nil {
 		t.Fatal(err)
 	}
Author	SHA1	Message	Date
mattn	8ca3cca0a0	chore: use path/filepath for local file system paths (#10705 ) Build Syncthing / Gather common facts (push) Successful in 32s Details Build Syncthing / Build and test (~1.25.0, macos-latest) (push) Has been cancelled Details Build Syncthing / Build and test (~1.25.0, windows-latest) (push) Has been cancelled Details Build Syncthing / Build and test (~1.26.0, macos-latest) (push) Has been cancelled Details Build Syncthing / Build and test (~1.26.0, ubuntu-latest) (push) Has been cancelled Details Build Syncthing / Build and test (~1.26.0, windows-latest) (push) Has been cancelled Details Build Syncthing / Basic checks passed (push) Has been cancelled Details Build Syncthing / Package for Windows (push) Has been cancelled Details Build Syncthing / Build and test (~1.25.0, ubuntu-latest) (push) Has been cancelled Details Build Syncthing / Codesign for Windows (push) Has been cancelled Details Build Syncthing / Package for Linux (common) (push) Has been cancelled Details Mirrors / Mirror to Codeberg (push) Has been cancelled Details Build Syncthing / Package for Linux (other) (push) Has been cancelled Details Build Syncthing / Package for Linux (mips) (push) Has been cancelled Details Build Syncthing / Package for illumos (push) Has been cancelled Details Build Syncthing / Package for macOS (push) Has been cancelled Details Build Syncthing / Notarize for macOS (push) Has been cancelled Details Build Syncthing / Package cross compiled (push) Has been cancelled Details Build Syncthing / Package source code (push) Has been cancelled Details Build Syncthing / Sign for upgrade (push) Has been cancelled Details Build Syncthing / Package for Debian (push) Has been cancelled Details Build Syncthing / Publish nightly build (push) Has been cancelled Details Build Syncthing / Publish release files (push) Has been cancelled Details Build Syncthing / Publish APT (push) Has been cancelled Details Build Syncthing / Build and push Docker images (GHCR) (Dockerfile, syncthing, syncthing) (push) Has been cancelled Details Build Syncthing / Build and push Docker images (GHCR) (Dockerfile.stdiscosrv, discosrv, stdiscosrv) (push) Has been cancelled Details Build Syncthing / Build and push Docker images (GHCR) (Dockerfile.strelaysrv, relaysrv, strelaysrv) (push) Has been cancelled Details Build Syncthing / Sync images to Docker hub (push) Has been cancelled Details Build Syncthing / Run govulncheck (push) Has been cancelled Details Build Syncthing / Run golangci-lint (push) Has been cancelled Details Build Syncthing / Run meta checks (push) Has been cancelled Details ### Purpose `path` is for slash-separated paths (URLs, BEP protocol); local file system paths should use `path/filepath`. Fixed in `cmd/stdiscosrv/database.go` (3 sites) and `internal/db/sqlite/db_test.go` (1 site). ### Testing `go build ./cmd/stdiscosrv/...` and `go vet` pass. Signed-off-by: Yasuhiro Matsumoto <mattn.jp@gmail.com>	2026-05-23 22:31:33 +02:00
mattn	0c489f4ae2	fix(stcrashreceiver): close source loader responses on errors (#10704 ) Fix a response body leak in `githubSourceCodeLoader.Load` where the body was not closed when the HTTP status was non-200. Signed-off-by: Yasuhiro Matsumoto <mattn.jp@gmail.com>	2026-05-23 13:50:03 +00:00
Jakob Borg	deb1e5b38a	Revert "build: temporarily disable illumos for release" This reverts commit `c0c401efeb`.	2026-05-23 12:00:07 +02:00
Jakob Borg	49a2688caa	Merge branch 'infrastructure' * infrastructure: build: let infra containers builds fail individually chore(ur): move structs to reduce dependency chain chore(stcrashreceiver): add profiler on metrics port chore(stcrashreceiver): compact diskstore in-memory representation chore(stcrashreceiver): better source cache & metrics chore(stcrashreceiver): metrics on ignore matches	2026-05-23 09:36:25 +02:00