Update WHATSNEW

Start adding support for window properties.

configure

@@ -1,6 +1,6 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.72 for remind 06.01.08.
+# Generated by GNU Autoconf 2.72 for remind 06.01.09.
 #
 #
 # Copyright (C) 1992-1996, 1998-2017, 2020-2023 Free Software Foundation,
@@ -601,8 +601,8 @@ MAKEFLAGS=
 # Identity of this package.
 PACKAGE_NAME='remind'
 PACKAGE_TARNAME='remind'
-PACKAGE_VERSION='06.01.08'
-PACKAGE_STRING='remind 06.01.08'
+PACKAGE_VERSION='06.01.09'
+PACKAGE_STRING='remind 06.01.09'
 PACKAGE_BUGREPORT=''
 PACKAGE_URL='https://dianne.skoll.ca/projects/remind/'
 
@@ -1258,7 +1258,7 @@ if test "$ac_init_help" = "long"; then
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-'configure' configures remind 06.01.08 to adapt to many kinds of systems.
+'configure' configures remind 06.01.09 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1320,7 +1320,7 @@ fi
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of remind 06.01.08:";;
+     short | recursive ) echo "Configuration of remind 06.01.09:";;
    esac
   cat <<\_ACEOF
 
@@ -1408,7 +1408,7 @@ fi
 test -n "$ac_init_help" && exit $ac_status
 if $ac_init_version; then
   cat <<\_ACEOF
-remind configure 06.01.08
+remind configure 06.01.09
 generated by GNU Autoconf 2.72
 
 Copyright (C) 2023 Free Software Foundation, Inc.
@@ -1871,7 +1871,7 @@ cat >config.log <<_ACEOF
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by remind $as_me 06.01.08, which was
+It was created by remind $as_me 06.01.09, which was
 generated by GNU Autoconf 2.72.  Invocation command line was
 
   $ $0$ac_configure_args_raw
@@ -4231,6 +4231,7 @@ U="`uname -s`"
 if test "$U" != "SunOS" -a "$GCC" = yes; then
    	CFLAGS="$CFLAGS -Wall -Wextra -Wstrict-prototypes"
         # Check for link-time optimization support
+        OLDCFLAGS="$CFLAGS"
         CFLAGS="$CFLAGS -flto=auto"
         { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -flto=auto" >&5
 printf %s "checking whether $CC supports -flto=auto... " >&6; }
@@ -4258,11 +4259,12 @@ rm -f core conftest.err conftest.$ac_objext conftest.beam \
         { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $lto" >&5
 printf "%s\n" "$lto" >&6; }
         if test "x$lto" != "xyes" ; then
-	    CFLAGS="$CFLAGS -Wall -Wextra -Wstrict-prototypes"
+	    CFLAGS="$OLDCFLAGS"
         else
             { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -ffat-lto-object" >&5
 printf %s "checking whether $CC supports -ffat-lto-object... " >&6; }
-            CFLAGS="$CFLAGS -ffat-lto-objects"
+            OLDCFLAGS="$CFLAGS"
+            CFLAGS="$CFLAGS -Werror -ffat-lto-objects"
             cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 int x = 1;
@@ -4287,7 +4289,9 @@ rm -f core conftest.err conftest.$ac_objext conftest.beam \
             { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $lto" >&5
 printf "%s\n" "$lto" >&6; }
             if test "x$lto" != "xyes" ; then
-                CFLAGS="$CFLAGS -Wall -Wextra -Wstrict-prototypes -flto=auto"
+                CFLAGS="$OLDCFLAGS"
+            else
+                CFLAGS="$OLDCFLAGS -ffat-lto-objects"
             fi
         fi
 fi
@@ -4895,7 +4899,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log="
-This file was extended by remind $as_me 06.01.08, which was
+This file was extended by remind $as_me 06.01.09, which was
 generated by GNU Autoconf 2.72.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -4960,7 +4964,7 @@ ac_cs_config_escaped=`printf "%s\n" "$ac_cs_config" | sed "s/^ //; s/'/'\\\\\\\\
 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
 ac_cs_config='$ac_cs_config_escaped'
 ac_cs_version="\\
-remind config.status 06.01.08
+remind config.status 06.01.09
 configured by $0, generated by GNU Autoconf 2.72,
   with options \\"\$ac_cs_config\\"
 

configure.ac

@@ -1,6 +1,6 @@
 dnl Process this file with autoconf to produce a configure script.
 
-AC_INIT(remind, 06.01.08, , , https://dianne.skoll.ca/projects/remind/)
+AC_INIT(remind, 06.01.09, , , https://dianne.skoll.ca/projects/remind/)
 AC_CONFIG_SRCDIR([src/queue.c])
 
 cat <<'EOF'
@@ -50,6 +50,7 @@ U="`uname -s`"
 if test "$U" != "SunOS" -a "$GCC" = yes; then
    	CFLAGS="$CFLAGS -Wall -Wextra -Wstrict-prototypes"
         # Check for link-time optimization support
+        OLDCFLAGS="$CFLAGS"
         CFLAGS="$CFLAGS -flto=auto"
         AC_MSG_CHECKING([whether $CC supports -flto=auto])
         AC_LINK_IFELSE(
@@ -61,10 +62,11 @@ if test "$U" != "SunOS" -a "$GCC" = yes; then
                )
         AC_MSG_RESULT([$lto])
         if test "x$lto" != "xyes" ; then
-	    CFLAGS="$CFLAGS -Wall -Wextra -Wstrict-prototypes"
+	    CFLAGS="$OLDCFLAGS"
         else
             AC_MSG_CHECKING([whether $CC supports -ffat-lto-object])
-            CFLAGS="$CFLAGS -ffat-lto-objects"
+            OLDCFLAGS="$CFLAGS"
+            CFLAGS="$CFLAGS -Werror -ffat-lto-objects"
             AC_LINK_IFELSE(
                 [AC_LANG_PROGRAM(
                     [[int x = 1;]],
@@ -74,7 +76,9 @@ if test "$U" != "SunOS" -a "$GCC" = yes; then
                 )
             AC_MSG_RESULT([$lto])
             if test "x$lto" != "xyes" ; then
-                CFLAGS="$CFLAGS -Wall -Wextra -Wstrict-prototypes -flto=auto"
+                CFLAGS="$OLDCFLAGS"
+            else
+                CFLAGS="$OLDCFLAGS -ffat-lto-objects"
             fi
         fi
 fi

docs/WHATSNEW

@@ -1,5 +1,40 @@
 CHANGES TO REMIND
 
+* VERSION 06.01.09 - 2025-11-??
+
+- MAJOR NEW FEATURE: TkRemind: A new "View..." menu lets you choose a
+  calendar view from the following choices: Entire month, 1 week, 2
+  weeks or 4 weeks.
+
+- IMPROVEMENT: TkRemind: The Print dialog now allows you to preview
+  (and if you wish, adjust) the command used to print a calendar.
+
+- IMPROVEMENT: TkRemind: The Agenda Mode window ("Show Today's
+  Reminders") has navigation buttons for moving back or forward one
+  day at a time.
+
+- CHANGE: TkRemind: If you hand-edit a reminder in the "Preview
+  Reminder" dialog box, it is marked as non-editable by TkRemind.
+
+- CHANGE: TkRemind: Remove support for rem2ps.  All printing is now
+  done using rem2pdf.
+
+- IMPROVEMENT: remind: Improve error reporting if there's extraneous
+  content after an expression.
+
+- BUG FIX: TkRemind: Bind the Home/End/PgUp/PgDn keys on the numeric
+  keyboard for navigation.
+
+- FIX: Don't enable -ffat-lto-objects on FreeBSD.
+
+- BUG FIX: remind: Don't segfault if we can't open a .purged output
+  file in purge mode.
+
+- BUG FIX: rem2pdf: Make PANGO @x,y positioning consistent between
+  weekly and monthly calendars.  NOTE: If you use absolute PANGO
+  positioning, you might need to adjust your script because positions
+  are now relative to the centers of the grid lines.
+
 * VERSION 06.01.08 - 2025-10-27
 
 - BUG FIXES: tkremind: Fix many bugs with modal dialogs: Clicking too fast

man/tkremind.1.in

@@ -61,7 +61,7 @@ box appears completely full.
 .SH NAVIGATING
 To change to the previous or next month, click the \fB<\-\fR
 or \fB\->\fR button, respectively.  You can also use the left/right arrow
-keys or PageUp/PageDown to navigate.
+keys or PgUp/PgDn to navigate.
 
 To change back to the current month, click \fBToday\fR or press the
 Home key.  To go to a specific month, click \fBGo To Date...\fR.  This
@@ -71,6 +71,21 @@ year.  Once you've done this, click \fBGo\fR to go to the date, or
 
 To exit \fBTkRemind\fR, click \fBQuit\fR.
 
+.SH CHANGING THE VIEW
+By default, \fBTkRemind\fR shows the calendar for an entire month.
+The \fBView...\fR menu lets you pick from the following choices: Display
+an entire month, or display one, two or four weeks' worth of reminders.
+If you change the view, \fBTkRemind\fR remembers the change and that
+view becomes the default view next time you start \fBTkRemind\fR
+
+In the monthly view, the Next and Previous navigation buttons and keyboard
+shortcuts move by one month.  In all other views, they move by one week.
+This is true even for views that display multiple weeks.
+
+You can press the keys \fB1\fR, \fB2\fR, \fB4\fR or \fBm\fR over the
+main calendar window to change the view to one week, two weeks, four weeks
+or one month, respectively.
+
 .SH ADDING REMINDERS
 To add a reminder, click button 1 in any day number in the calendar.
 The \fBAdd Reminder...\fR dialog will pop up, with values preselected for
@@ -127,23 +142,33 @@ reminder you entered using the \fBAdd Reminder...\fR dialog.  You can
 edit the reminder, thereby gaining access to advanced features of
 \fBRemind\fR.  You can also use it simply to play around and discover
 \fBRemind\fR's idioms for expressing different types of reminders.
+.PP
+\fBNOTE\fR: If you hand-edit a reminder, then that reminder will
+\fInot\fR be editable in TkRemind's graphical reminder dialog any more.
+You will have to hand-edit it to change it.
 
 .SH SEEING A SINGLE DAY'S REMINDERS
 Right-click on any day number in the calendar to pop up a window with
 that day's reminders in Agenda Mode.  You can left- or right-click the
-current date and time indicator at the bottom of the window to see today's
-reminders in Agenda Mode.
+current date and time indicator at the bottom of the calendar window
+to see today's reminders in Agenda Mode.
 
 In the Agenda Mode display, hovering over a reminder will show ancillary
 information such as a Location, URL or Description.  Clicking on a reminder
-will open an editor on the REM command that created the reminder.
+will open an editor on the REM command that created the reminder.  You can
+also navigate in the Agenda Mode window one day at a time using the
+forward and back arrow buttons or left/right arrow keys or PgUp/PgDn.
+You can get back to today by clicking \fBToday\fR or pressing the
+Home key.
 
 .SH PRINTING
 To print the current month's calendar, click \fBPrint...\fR on the
 main calendar window.  This brings up the print dialog.  Printing
-either produces a PostScript file or sends PostScript to a UNIX command.
-(If you have \fBrem2pdf\fR installed, you can choose to produce
-PDF output rather than PostScript.)
+either produces a PostScript or PDF file, or sends PostScript or PDF
+to a UNIX command.
+
+Note that you must have \fBrem2pdf\fR installed in order to be
+able to print.
 
 Select the print destination by choosing either \fBTo file:\fR or
 \fBTo command:\fR in the print dialog.  Press \fBBrowse...\fR to bring
@@ -160,7 +185,7 @@ the directory.
 Select the appropriate paper size and orientation.  Activate
 \fBFill page\fR if you want the calendar to fill the page.  This should
 be the normal case unless you have many reminders in a particular
-day.  (See the \fBRem2PS\fR or \fBrem2pdf\fR documentation.)
+day.  (See the \fBrem2pdf\fR documentation.)
 
 Finally, click \fBPrint\fR to print or \fBCancel\fR to cancel.  Note
 that during printing, \fBRemind\fR is called with the
@@ -171,9 +196,9 @@ is also supplied to \fBRemind\fR.
 If you click on \fBShow Command\fR rather than \fBPrint\fR, then
 \fBTkRemind\fR won't actually print anything.  Instead, it will pop
 up a text window with the command that it \fIwould have used\fR to print
-the calendar.  You can cut-and-paste the command into a shell prompt and
-adjust as needed if you want to use any \fBrem2pdf\fR or \fBrem2ps\fR
-options that are not directly supported by \fBTkRemind\fR.
+the calendar.  You can adjust the command as needed and then click \fBRun\fR
+to run the modified command.  This lets you specify \fBrem2pdf\fR options
+that are not directly supported by \fBTkRemind\fR.
 
 .SH EDITING REMINDERS
 
@@ -187,13 +212,11 @@ reminder entirely by selecting \fBDelete reminder\fR.  The remaining
 buttons, \fBPreview reminder\fR and \fBCancel\fR operate identically
 to the dialog in "ADDING REMINDERS."
 
-Note that if you edit a reminder (using \fBPreview reminder\fR),
-any edits you made are \fInot\fR retained in the dialog box.  You
-should not attempt to edit such reminders; you have to retype them
-in the \fBPreview reminder\fR dialog.
-
-If the reminder was not created with \fBTkRemind\fR, you can't edit
-it with \fBTkRemind\fR.
+Note that if you have hand-edited a reminder (using \fBPreview
+reminder\fR), or if the reminder was hand-created in the first place,
+then clicking on it will \fInot\fR pop up the TkRemind
+reminder-editing dialog.  Instead, TkRemind will start up a text
+editor (if you have configured one) so you can hand-edit the reminder.
 
 .SH USING A TEXT EDITOR
 
@@ -559,5 +582,5 @@ $HOME/.config/tkremindrc -- \fBTkRemind\fR saved options.
 .SH HOME PAGE
 https://dianne.skoll.ca/projects/remind/
 .SH SEE ALSO
-\fBremind\fR, \fBrem2ps\fR, \fBrem2pdf\fR, \fBrem2html\fR
+\fBremind\fR, \fBrem2pdf\fR, \fBrem2html\fR
 

rem2pdf/bin/rem2pdf.in

@@ -683,7 +683,10 @@ of the right side of the calendar box.
 A positive I<y> value positions the top edge of the text I<y> points
 below the top of the calendar box, while a negative I<y> value
 positions the bottom edge of the text I<y> points above the bottom of
-the calendar box.
+the calendar box.  Note that the coordinates are relative to the center
+of the lines that delineate the boxes; you should use an I<x> value
+whose absolute value is at least 2 and a I<y> value whose absolute
+value is at least 4 to avoid colliding with the lines.
 
 If you use absolutely-positioned text, it's up to you to make sure it
 doesn't overlap other text; B<rem2pdf> takes no special precautions to
@@ -692,7 +695,7 @@ prevent this.
 As an example, this places Sunrise and Sunset times at the bottom left
 of each calendar box:
 
-  REM SPECIAL PANGO @1,-1 <span size="4800"><i>Rise [sunrise($U)] Set [sunset($U)]</i></span>
+  REM SPECIAL PANGO @2,-4 <span size="4800"><i>Rise [sunrise($U)] Set [sunset($U)]</i></span>
 
 (Note that Pango expresses font sizes in 1024's of a point, so a size of
 4800 works out to about 4.6 points.)

rem2pdf/lib/Remind/PDF.pm

@@ -628,7 +628,7 @@ sub col_box_coordinates
                 $settings->{margin_left} + $cell * $col,
                 $so_far,
                 $settings->{margin_left} + $cell * ($col + 1),
-                $so_far + $height + $settings->{border_size},
+                $so_far + $height + 2* $settings->{border_size},
             );
 }
 
@@ -663,7 +663,7 @@ sub draw_day
                         $cr->set_source_rgb($shade->{r} / 255,
                                             $shade->{g} / 255,
                                             $shade->{b} / 255);
-                        $cr->rectangle($x1, $y1, $x2 - $x1, $y2 - $y1 + $settings->{border_size});
+                        $cr->rectangle($x1, $y1, $x2 - $x1, $y2 - $y1);
                         $cr->fill();
                         $cr->restore;
                 }

src/err.h

@@ -137,6 +137,9 @@
 #define E_NO_MB             113
 #define E_BAD_MB_SEQ        114
 #define E_EXPR_NODES_EXCEEDED 115
+#define E_EXPECTING_EOXPR   116
+#define E_EXPECTING_ATOM    117
+
 #ifdef MK_GLOBALS
 #undef EXTERN
 #define EXTERN
@@ -270,6 +273,8 @@ EXTERN char *ErrMsg[]
 /* E_NO_MB */              "C library does not support multibyte characters",
 /* E_BAD_MB_SEQ */         "Invalid multibyte sequence",
 /* E_EXPR_NODES_EXCEEDED */ "Maximum expression complexity exceeded",
+/* E_EXPECTING_EOXPR */    "Expecting operator or end-of-expression",
+/* E_EXPECTING_ATOM */     "Expecting constant, variable, function call or (expression)",
 }
 #endif /* MK_GLOBALS */
 ;

src/expr.c

@@ -170,6 +170,8 @@ static expr_node *expr_node_free_list = NULL;
 /* Maximum parse level before we bail (to avoid SEGV from filling stack)*/
 #define MAX_PARSE_LEVEL 2000
 
+/* Legal punctuation characters in an expression */
+#define LEGAL_CHARS "+-*/%&|=<>!)"
 static int parse_level_high_water = 0;
 #define CHECK_PARSE_LEVEL() do { if (level > parse_level_high_water) { parse_level_high_water = level; if (level > MAX_PARSE_LEVEL) { *r = E_OP_STK_OVER; return NULL; } } } while(0)
 
@@ -2228,9 +2230,15 @@ static int set_constant_value(expr_node *atom)
         atom->u.value.v.val = val;
         return OK;
     }
+
     atom->u.value.type = ERR_TYPE;
-    Eprint("`%s': %s", DBufValue(&ExprBuf), GetErr(E_ILLEGAL_CHAR));
-    return E_ILLEGAL_CHAR;
+    if (strchr(LEGAL_CHARS, *s) != NULL) {
+        r = E_EXPECTING_ATOM;
+    } else {
+        r = E_ILLEGAL_CHAR;
+    }
+    Eprint("`%s': %s", DBufValue(&ExprBuf), GetErr(r));
+    return r;
 }
 
 /***************************************************************/
@@ -2346,8 +2354,13 @@ static expr_node *parse_atom(char const **e, int *r, Var *locals, int level)
         *s != '$' &&
         *s != '"' &&
         *s != '\'') {
-        Eprint("%s `%c'", GetErr(E_ILLEGAL_CHAR), *s);
-        *r = E_ILLEGAL_CHAR;
+        if (strchr(LEGAL_CHARS, *s) != NULL) {
+            *r = E_EXPECTING_ATOM;
+            Eprint("%s", GetErr(*r));
+        } else {
+            *r = E_ILLEGAL_CHAR;
+            Eprint("%s `%c'", GetErr(*r), *s);
+        }
         return NULL;
     }
 
@@ -2759,9 +2772,24 @@ expr_node *parse_expression(char const **e, int *r, Var *locals)
             print_expr_tree(node, ErrFp);
             fprintf(ErrFp, "\n");
         }
-        if (**e && (**e != ']')) {
+        orig = o2;
+    }
+    while (**e && isempty(**e)) {
+        (*e)++;
+    }
+    if (**e && (**e != ']')) {
+        if (DebugFlag & DB_PARSE_EXPR) {
             fprintf(ErrFp, "  Unparsed: %s\n", *e);
         }
+        if (*r == OK) {
+            *r = E_EXPECTING_EOXPR;
+        }
+    }
+    if (*r != OK) {
+        if (node) {
+            free_expr_tree(node);
+            node = NULL;
+        }
     }
     if (!SuppressErrorOutputInCatch) {
         if (*r == E_EXPECT_COMMA     ||
@@ -2771,9 +2799,11 @@ expr_node *parse_expression(char const **e, int *r, Var *locals)
             *r == E_2FEW_ARGS        ||
             *r == E_PARSE_ERR        ||
             *r == E_EOLN             ||
+            *r == E_EXPECTING_EOXPR  ||
             *r == E_BAD_NUMBER       ||
             *r == E_BAD_DATE         ||
             *r == E_BAD_TIME         ||
+            *r == E_EXPECTING_ATOM   ||
             *r == E_ILLEGAL_CHAR) {
             end_of_expr = find_end_of_expr(orig);
             while (**e && isempty(**e)) {

src/files.c

@@ -225,8 +225,9 @@ static void OpenPurgeFile(char const *fname, char const *mode)
     if (!PurgeFP) {
         fprintf(ErrFp, tr("Cannot open `%s' for writing: %s"), DBufValue(&fname_buf), strerror(errno));
         fprintf(ErrFp, "\n");
+    } else {
+        set_cloexec(fileno(PurgeFP));
     }
-    set_cloexec(fileno(PurgeFP));
     DBufFree(&fname_buf);
 }
 

src/funcs.c

@@ -34,8 +34,10 @@
 #endif
 
 #ifdef HAVE_SYS_TERMIOS_H
+#ifdef __sun
 #include <sys/termios.h>
 #endif
+#endif
 
 #include <ctype.h>
 #include <math.h>

src/init.c

@@ -36,8 +36,10 @@
 #endif
 
 #ifdef HAVE_SYS_TERMIOS_H
+#ifdef __sun
 #include <sys/termios.h>
 #endif
+#endif
 
 
 #include "types.h"

tests/manpage-personal-dict

@@ -304,6 +304,8 @@ Pango
 ParseUntriggered
 Paulo
 Pelzl
+PgDn
+PgUp
 Philipp
 Pinard
 Plaser

tests/test-rem

@@ -27,12 +27,16 @@ if test `id -u` = 0 ; then
     exit 1
 fi
 
-REMIND="../src/remind --flush -q"
+REMIND_CMD=${REMIND_CMD:-../src/remind}
+REM2PS=${REM2PS:-../src/rem2ps}
+REMIND="$REMIND_CMD --flush -q"
 OUT="../tests/test.out"
 CMP="../tests/test.cmp"
 # Set a known timezone so moon phases show up in predictable places
 TZ=UTC
 export TZ
+LANG=C.UTF-8
+LC_ALL=C.UTF-8
 
 # Check if "grep" accepts "-a" flag
 echo TEST | grep -a TEST > /dev/null 2>&1
@@ -189,8 +193,8 @@ rm -f ../tests/purge_dir/*.rem.purged >> $OUT 2>&1
 
 $REMIND ../tests/runtest.rem >> $OUT 2>&1
 
-$REMIND -p ../tests/shade.rem 1 August 2009 | ../src/rem2ps -e -l -c3 >> $OUT 2>&1
-$REMIND -pp ../tests/shade.rem 1 August 2009 | ../src/rem2ps -e -l -c3 >> $OUT 2>&1
+$REMIND -p ../tests/shade.rem 1 August 2009 | "$REM2PS" -e -l -c3 >> $OUT 2>&1
+$REMIND -pp ../tests/shade.rem 1 August 2009 | "$REM2PS" -e -l -c3 >> $OUT 2>&1
 
 TZ=America/Toronto $REMIND ../tests/sunmoon.rem 1 Jan 2011 >> $OUT 2>&1
 
@@ -507,8 +511,8 @@ $REMIND --version >> $OUT 2>&1
 # Test queueing.  Because eventstart depends on the actual system
 # date, we use the --test flag to fake the date and time.
 # We can't use $REMIND here because it includes the -q flag.
-echo JSONQUEUE | ../src/remind --flush --test -z0 ../tests/queue1.rem >> $OUT 2>&1
-echo QUEUE     | ../src/remind --flush --test -zj ../tests/queue1.rem >> $OUT 2>&1
+echo JSONQUEUE | "$REMIND_CMD" --flush --test -z0 ../tests/queue1.rem >> $OUT 2>&1
+echo QUEUE     | "$REMIND_CMD" --flush --test -zj ../tests/queue1.rem >> $OUT 2>&1
 
 # Test for leap year bug that was fixed
 $REMIND -dte - 28 Feb 2024 <<'EOF' >> $OUT 2>&1

tests/test.cmp

@@ -1046,7 +1046,7 @@ set a057 value("a05"+"6")
 "a05" + "6" => "a056"
 value("a056") => "SDFJHSDF KSJDFH KJSDFH KSJDFH"
 set a058 version()
-version() => "06.01.08"
+version() => "06.01.09"
 set a059 wkday(today())
 today() => 1991-02-16
 wkday(1991-02-16) => "Saturday"
@@ -2609,7 +2609,7 @@ a056  "SDFJHSDF KSJDFH KJSDFH KSJDFH"
 a007  "1991-02-16"
 a057  "SDFJHSDF KSJDFH KJSDFH KSJDFH"
 a008  "11:44"
-a058  "06.01.08"
+a058  "06.01.09"
 a059  "Saturday"
 a010  12
 a060  6
@@ -5040,8 +5040,9 @@ set a 7 * "Cabbage! "
 
 # Should result in errors
 set pqxya 1+2)
-1 + 2 => 3
-../tests/test.rem(1014): Expecting end-of-line
+1+2)
+   ^-- here
+../tests/test.rem(1014): Expecting operator or end-of-expression
 
 # Should result in an error
 REM Tue OMIT 2024-01-01 MSG Wookie
@@ -5562,8 +5563,8 @@ REM SATISFY ""
 REM SATISFY [version() > "01.00.00"]
 ../tests/test.rem(1074): SATISFY: expression has no reference to trigdate() or $T...
 ../tests/test.rem(1074): Trig = Saturday, 16 February, 1991
-version() => "06.01.08"
-"06.01.08" > "01.00.00" => 1
+version() => "06.01.09"
+"06.01.09" > "01.00.00" => 1
 ../tests/test.rem(1074): Trig(satisfied) = Saturday, 16 February, 1991
 REM SATISFY [max(x, max(x, 1, 2, 3), 4, 5, 6) * 5]
 ../tests/test.rem(1075): SATISFY: expression has no reference to trigdate() or $T...
@@ -16426,9 +16427,14 @@ eval("1/0") => 1 / 0 => Division by zero
 ../tests/test.rem(1590): `/': Division by zero
 Division by zero
 set a eval("1 / / 2")
-eval("1 / / 2") => ../tests/test.rem(1591): Illegal character `/'
+eval("1 / / 2") => ../tests/test.rem(1591): Expecting constant, variable, function call or (expression)
 1 / / 2
     ^-- here
+Expecting constant, variable, function call or (expression)
+set a eval("1 / # 2")
+eval("1 / # 2") => ../tests/test.rem(1592): Illegal character `#'
+1 / # 2
+    ^-- here
 Illegal character
 set a catch(eval("1 +"), 33)
 eval("1 +") => Unexpected end of line
@@ -16438,7 +16444,10 @@ eval("1/0") => 1 / 0 => Division by zero
 Division by zero
 catch(*Division by zero*, 34) => 34
 set a catch(eval("1 / / 2"), 35)
-eval("1 / / 2") => Illegal character
+eval("1 / / 2") => Expecting constant, variable, function call or (expression)
+catch(*Expecting constant, variable, function call or (expression)*, 35) => 35
+set a catch(eval("1 / # 2"), 35)
+eval("1 / # 2") => Illegal character
 catch(*Illegal character*, 35) => 35
 
 # Ensure RUN is disabled in eval
@@ -16446,7 +16455,7 @@ set a shell("echo foo")
 shell("echo foo") => "foo"
 set a eval("shell(\"echo foo\")")
 eval("shell(\"echo foo\")") => shell("echo foo") => RUN disabled
-../tests/test.rem(1598): shell(): RUN disabled
+../tests/test.rem(1600): shell(): RUN disabled
 RUN disabled
 set a shell("echo foo")
 shell("echo foo") => "foo"
@@ -16459,8 +16468,8 @@ Leaving UserFN i() => "foo"
 set a eval("i()")
 eval("i()") => Entering UserFN i()
 shell("echo foo") => RUN disabled
-../tests/test.rem(1603): shell(): RUN disabled
-    ../tests/test.rem(1601): [#0] In function `i'
+../tests/test.rem(1605): shell(): RUN disabled
+    ../tests/test.rem(1603): [#0] In function `i'
 Leaving UserFN i() => RUN disabled
 RUN disabled
 set a i()
@@ -16473,19 +16482,19 @@ set b eval(a)
 a => "eval(\"1\")+ shell(\"ls\")"
 eval("eval(\"1\")+ shell(\"ls\")") => eval("1") => 1
 shell("ls") => RUN disabled
-../tests/test.rem(1607): shell(): RUN disabled
+../tests/test.rem(1609): shell(): RUN disabled
 RUN disabled
 
 # "value" should use lazy evaluation
 set a value(4:33)
 value(04:33) => Type mismatch
-../tests/test.rem(1610): Type mismatch
+../tests/test.rem(1612): Type mismatch
 set a value('2020-01-01', 42)
 value(2020-01-01, ?) => Type mismatch
-../tests/test.rem(1611): Type mismatch
+../tests/test.rem(1613): Type mismatch
 set a value("nosuchvar")
 value("nosuchvar") => Undefined variable
-../tests/test.rem(1612): Undefined variable
+../tests/test.rem(1614): Undefined variable
 set a value("nosuchvar", 42)
 value("nosuchvar", 42) => 42
 set a value("a", 42)
@@ -16495,11 +16504,11 @@ value("a") => 42
 DEBUG -x
 
 DEBUG -e
-../tests/test.rem(1622): eval(): Too many recursive function calls
+../tests/test.rem(1624): eval(): Too many recursive function calls
 Base: 1991-02-09
 Base: 1991-02-09
-../tests/test.rem(1630): Expired
-../tests/test.rem(1631): Expired
+../tests/test.rem(1632): Expired
+../tests/test.rem(1633): Expired
 trigvalid = 1; trigdate = 1991-01-14
 trigvalid = 0; trigdate = 0
 daysinmon(2, 2000) => 29
@@ -16511,36 +16520,36 @@ daysinmon("Feb", 2001) => 28
 daysinmon("March", 2000) => 31
 daysinmon("March", 2001) => 31
 daysinmon("Cabbage", 2001) => Invalid month name
-../tests/test.rem(1658): daysinmon(): Invalid month name
+../tests/test.rem(1660): daysinmon(): Invalid month name
 daysinmon(2000-02-14) => 29
 daysinmon(2001-02-14) => 28
 daysinmon(2000-04-14) => 30
 daysinmon(2001-04-14) => 30
 date(2020, "April", 15) => 2020-04-15
 date(2020, "Carrot", 12) => Invalid month name
-../tests/test.rem(1666): date(): Invalid month name
+../tests/test.rem(1668): date(): Invalid month name
 datetime(2020, "April", 13, 04:44) => 2020-04-13@04:44
 datetime(2020, "April", 13, 4, 44) => 2020-04-13@04:44
 datetime(2020, "Lettuce", 13, 04:44) => Invalid month name
-../tests/test.rem(1669): datetime(): Invalid month name
+../tests/test.rem(1671): datetime(): Invalid month name
 datetime(2020, "Lettuce", 13, 4, 44) => Invalid month name
-../tests/test.rem(1670): datetime(): Invalid month name
+../tests/test.rem(1672): datetime(): Invalid month name
 wkdaynum("Tue") => 2
 wkdaynum("Wednesday") => 3
 wkdaynum("telephone") => Invalid weekday name
-../tests/test.rem(1674): wkdaynum(): Invalid weekday name
-../tests/test.rem(1685): Cannot modify system variable: `$NumTrig'
-../tests/test.rem(1686): POP-VARS without matching PUSH-VARS
+../tests/test.rem(1676): wkdaynum(): Invalid weekday name
+../tests/test.rem(1687): Cannot modify system variable: `$NumTrig'
+../tests/test.rem(1688): POP-VARS without matching PUSH-VARS
 
 FUNSET a
 FSET b(x, y) x*y
 FSET c() 33
 
 set a a(2)
-../tests/test.rem(1695): Undefined function: `a'
+../tests/test.rem(1697): Undefined function: `a'
 set a b(2)
 b(?) => Not enough arguments
-../tests/test.rem(1696): b(): Not enough arguments
+../tests/test.rem(1698): b(): Not enough arguments
 set a b(2, 3)
 Entering UserFN b(2, 3)
 x => 2
@@ -16562,7 +16571,7 @@ Entering UserFN a(2)
 Leaving UserFN a(2) => 42
 set a b(2)
 b(?) => Not enough arguments
-../tests/test.rem(1707): b(): Not enough arguments
+../tests/test.rem(1709): b(): Not enough arguments
 set a b(2, 3)
 Entering UserFN b(2, 3)
 x => 2
@@ -16577,10 +16586,10 @@ Leaving UserFN c() => 66
 POP-FUNCS
 
 set a a(2)
-../tests/test.rem(1713): Undefined function: `a'
+../tests/test.rem(1715): Undefined function: `a'
 set a b(2)
 b(?) => Not enough arguments
-../tests/test.rem(1714): b(): Not enough arguments
+../tests/test.rem(1716): b(): Not enough arguments
 set a b(2, 3)
 Entering UserFN b(2, 3)
 x => 2
@@ -16595,7 +16604,7 @@ DEBUG -xe
 Overridden: subst_colon subst_bang subst_question subst_at subst_hash
 bad => "ÿ"
 mbstrlen("ÿ") => Invalid multibyte sequence
-../tests/test.rem(1734): mbstrlen(): Invalid multibyte sequence
+../tests/test.rem(1736): mbstrlen(): Invalid multibyte sequence
 bad => "ÿ"
 strlen("ÿ") => 1
 faces => "🙂🙂🙂🙂🙂xyzçççéfoo"
@@ -16609,7 +16618,7 @@ index("🙂🙂🙂🙂🙂xyzçççéfoo", "ç") => 24
 bad => "ÿ"
 bad => "ÿ"
 mbindex("ÿ", "ÿ") => Invalid multibyte sequence
-../tests/test.rem(1742): mbindex(): Invalid multibyte sequence
+../tests/test.rem(1744): mbindex(): Invalid multibyte sequence
 faces => "🙂🙂🙂🙂🙂xyzçççéfoo"
 mbindex("🙂🙂🙂🙂🙂xyzçççéfoo", "ç", 11) => 11
 faces => "🙂🙂🙂🙂🙂xyzçççéfoo"
@@ -16628,10 +16637,10 @@ faces => "🙂🙂🙂🙂🙂xyzçççéfoo"
 mbsubstr("🙂🙂🙂🙂🙂xyzçççéfoo", 2, 9) => "🙂🙂🙂🙂xyzç"
 bad => "ÿ"
 mbsubstr("ÿ", 1) => Invalid multibyte sequence
-../tests/test.rem(1754): mbsubstr(): Invalid multibyte sequence
+../tests/test.rem(1756): mbsubstr(): Invalid multibyte sequence
 bad => "ÿ"
 mbsubstr("ÿ", 1, 20) => Invalid multibyte sequence
-../tests/test.rem(1755): mbsubstr(): Invalid multibyte sequence
+../tests/test.rem(1757): mbsubstr(): Invalid multibyte sequence
 faces => "🙂🙂🙂🙂🙂xyzçççéfoo"
 substr("🙂🙂🙂🙂🙂xyzçççéfoo", 2) => "Ÿ™‚🙂🙂🙂🙂xyzçççéfoo"
 faces => "🙂🙂🙂🙂🙂xyzçççéfoo"
@@ -16641,13 +16650,13 @@ codepoint("🙂🙂🙂🙂🙂xyzçççéfoo") => 128578
 mbchar(128578, 162, 122) => "🙂¢z"
 bad => "ÿ"
 codepoint("ÿ") => Invalid multibyte sequence
-../tests/test.rem(1762): codepoint(): Invalid multibyte sequence
+../tests/test.rem(1764): codepoint(): Invalid multibyte sequence
 codepoint("") => 0
 mbchar(0) => ""
 mbchar(0, 120) => Number too low
-../tests/test.rem(1765): mbchar(): Number too low
+../tests/test.rem(1767): mbchar(): Number too low
 mbchar(120, 0) => Number too low
-../tests/test.rem(1766): mbchar(): Number too low
+../tests/test.rem(1768): mbchar(): Number too low
 Variable hash table statistics:
   Entries: 100146; Buckets: 87719; Non-empty Buckets: 66303
   Maxlen: 5; Minlen: 0; Avglen: 1.142; Stddev: 0.878; Avg nonempty len: 1.510
@@ -16669,7 +16678,7 @@ Expression nodes high-water: 302076
     Expression nodes leaked: 0
      Parse level high-water: 34
 Max expr node evaluations per line: 2001
-Total expression node evaluations:  106467
+Total expression node evaluations:  106471
 
 Test 2
 
@@ -23707,7 +23716,7 @@ SECURITY: Won't read world-writable file or directory!
 Error reading include_dir/ww: Can't open file
 SECURITY: Won't read world-writable file or directory!
 Error reading include_dir/ww: No files matching *.rem
-06.01.08
+06.01.09
 Enabling test mode: This is meant for the acceptance test.
 Do not use --test in production.
 In test mode, the system time is fixed at 2025-01-06@19:00
@@ -23905,7 +23914,9 @@ Parsed expression: 1||1
 Parsed expression: 2
   => 2
   Unparsed: , 3
-../tests/expr.rem(15): Expecting end-of-line
+2, 3
+ ^-- here
+../tests/expr.rem(15): Expecting operator or end-of-expression
 Parsed expression: iif(0, "foo", 0, "bar", 1, "blech", 0, "quux", 1, "borhy", "wacka")
   => (Iif 0 "foo" 0 "bar" 1 "blech" 0 "quux" 1 "borhy" "wacka")
 iif(0, ?, 0, ?, 1, "blech", ?, ?, ?, ?, ?) => "blech"
@@ -23923,7 +23934,7 @@ max(6, 9, 50) => 50
 Parsed expression: max(1,
   => Error: Illegal character
   Unparsed: ,1)
-,1)
+max(1,,1)
       ^-- here
 Parsed expression: 5%0
   => (% 5 0)
@@ -24284,7 +24295,7 @@ Expression nodes high-water: 499
     Expression nodes leaked: 0
      Parse level high-water: 2001
 Max expr node evaluations per line: 499
-Total expression node evaluations:  632
+Total expression node evaluations:  631
 -stdin-(14): Unmatched PUSH-OMIT-CONTEXT at -stdin-(7)
 -stdin-(14): Warning: PUSH-OMIT-CONTEXT without matching POP-OMIT-CONTEXT
 No reminders.
@@ -25063,6 +25074,8 @@ TRANSLATE "TZ specified for non-timed reminder" ""
 TRANSLATE "C library does not support multibyte characters" ""
 TRANSLATE "Invalid multibyte sequence" ""
 TRANSLATE "Maximum expression complexity exceeded" ""
+TRANSLATE "Expecting operator or end-of-expression" ""
+TRANSLATE "Expecting constant, variable, function call or (expression)" ""
 
 # Other Messages
 TRANSLATE "%s function `%s' defined at %s(%s) does not use its argument" ""

tests/test.rem

@@ -1589,9 +1589,11 @@ dump -c a
 set a eval("1 +")
 set a eval("1/0")
 set a eval("1 / / 2")
+set a eval("1 / # 2")
 set a catch(eval("1 +"), 33)
 set a catch(eval("1/0"), 34)
 set a catch(eval("1 / / 2"), 35)
+set a catch(eval("1 / # 2"), 35)
 
 # Ensure RUN is disabled in eval
 set a shell("echo foo")
@@ -1765,6 +1767,8 @@ set a mbchar(0)
 set a mbchar(0, 120)
 set a mbchar(120, 0)
 
+# Make sure trailing space doesn't cause a diagnostic.
+set a "foo"      
 DEBUG -x
 # Don't want Remind to queue reminders
 EXIT