Update WHATSNEW for 04.02.01 release.

Patch courtesy of Luís Henriques

.gitignore

@@ -31,3 +31,4 @@ src/test-*.out
 src/version.h
 tests/test.out
 www/Makefile
+gmon.out

.gitlab-ci.yml

@@ -6,7 +6,7 @@ tests:
     - chown -R testuser .
     - chmod -R go-w .
   script:
-    - LANG=C.UTF-8 su testuser -c './configure && make test'
+    - LANG=C.UTF-8 su testuser -c './configure && make all && make test'
   artifacts:
     when: always
     paths:

README

@@ -40,20 +40,39 @@ PREREQUISITES:
 Remind and rem2ps have no prerequisites beyond the standard C library and
 the standard math library.
 
-Rem2HTML requires the JSON::MaybeXS Perl module; on Debian-like
-systems, you can install that with:
+Rem2HTML requires the JSON::MaybeXS Perl module.
+Rem2PDF requires the JSON::MaybeXS, Pango and Cairo Perl modules.
 
-    apt install libjson-maybexs-perl
-
-Rem2PDF requires the JSON::MaybeXS, Pango and Cairo Perl modules.  On
-Debian-like systems, install with:
+- On Debian-like systems, these prerequisites may be installed with:
 
     apt install libjson-maybexs-perl libpango-perl libcairo-perl
 
-TkRemind requires Tcl/Tk and the tcllib library.  On Debian-like systems
-install with:
+- On RPM-based systems, you need perl-Pango, perl-Cairo and perl-JSON-MaybeXS
+
+- On Gentoo, you need dev-perl/Pango, dev-perl/Cairo and dev-perl/JSON-MaybeXS.
+
+- On Arch linux, you need pango-perl, cairo-perl and perl-json-maybexs
+
+TkRemind requires Tcl/Tk and the tcllib library.
+
+- On Debian-like systems, install with:
 
     apt install tcl tk tcllib
 
+- On RPM-based systems, you need tcl, tk and tcllib
+
+- On Arch Linux, you need tk and tcllib.  The latter is available at
+  https://aur.archlinux.org/packages/tcllib
+
+If the little arrows for "Previous Month" and "Next Month" do not display
+correctly in TkRemind, you may need to install the Noto Fonts.  Install
+all of your distribution's Nonto Font-related packages.
+
+- On Debian-like systems, install with:
+
+    apt install fonts-noto-core fonts-noto-color-emoji \
+        fonts-noto-extra fonts-noto-ui-core fonts-noto-ui-extra
+
+==========================================================================
 Contact info: mailto:dianne@skoll.ca
 Home page:    https://dianne.skoll.ca/projects/remind/

configure

@@ -3975,7 +3975,14 @@ fi
 if test "$GCC" = yes; then
 	CFLAGS="$CFLAGS -Wall -Wextra -Wstrict-prototypes"
         # Check for link-time optimization support
-        for f in -flto=auto -ffat-lto-objects; do
+        f=-flto=auto
+        { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC supports $f" >&5
+$as_echo_n "checking whether $CC supports $f... " >&6; }
+        if $CC -E $f /dev/null > /dev/null 2>&1 ; then
+            { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
+$as_echo "yes" >&6; }
+            CFLAGS="$CFLAGS $f"
+            f=-ffat-lto-objects
             { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC supports $f" >&5
 $as_echo_n "checking whether $CC supports $f... " >&6; }
             if $CC -E $f /dev/null > /dev/null 2>&1 ; then
@@ -3986,7 +3993,10 @@ $as_echo "yes" >&6; }
                 { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
 $as_echo "no" >&6; }
             fi
-        done
+        else
+            { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
+$as_echo "no" >&6; }
+        fi
 fi
 
 if test "$ac_cv_perlartifacts" = "yes" ; then
@@ -4015,7 +4025,7 @@ _ACEOF
 fi
 done
 
-VERSION=04.02.00
+VERSION=04.02.01
 
 
 

configure.in

@@ -47,7 +47,12 @@ AC_HEADER_TIME
 if test "$GCC" = yes; then
 	CFLAGS="$CFLAGS -Wall -Wextra -Wstrict-prototypes"
         # Check for link-time optimization support
-        for f in -flto=auto -ffat-lto-objects; do
+        f=-flto=auto
+        AC_MSG_CHECKING([whether $CC supports $f])
+        if $CC -E $f /dev/null > /dev/null 2>&1 ; then
+            AC_MSG_RESULT([yes])
+            CFLAGS="$CFLAGS $f"
+            f=-ffat-lto-objects
             AC_MSG_CHECKING([whether $CC supports $f])
             if $CC -E $f /dev/null > /dev/null 2>&1 ; then
                 AC_MSG_RESULT([yes])
@@ -55,7 +60,9 @@ if test "$GCC" = yes; then
             else
                 AC_MSG_RESULT([no])
             fi
-        done
+        else
+            AC_MSG_RESULT([no])
+        fi
 fi
 
 if test "$ac_cv_perlartifacts" = "yes" ; then
@@ -73,7 +80,7 @@ if test "$?" != 0 ; then
     exit 1
 fi
 AC_CHECK_FUNCS(setenv unsetenv glob mbstowcs setlocale initgroups)
-VERSION=04.02.00
+VERSION=04.02.01
 AC_SUBST(VERSION)
 AC_SUBST(PERL)
 AC_SUBST(PERLARTIFACTS)

docs/WHATSNEW

@@ -1,6 +1,34 @@
 CHANGES TO REMIND
 
-* VERSION 4.2 Patch 0 - 2022-??-??
+* VERSION 4.2 Patch 1 - 2022-12-15
+
+- MINOR IMPROVEMENT: TkRemind: If "Extra Remind Options" contains -m, make
+  TkRemind start the calendar with Monday instead of Sunday.
+
+- MINOR IMPROVEMENT: Sample files: Add French holidays courtesy of
+  Clément Bœsch.
+
+- MINOR IMPROVEMENT: A few performance fixes, likely not even noticeable in
+  most cases.
+
+- MINOR FIXES: Fix misleading comments in the source code.
+
+- MINOR FIX: Remove a bunch of dead code in the moon-phase routines.
+
+- MINOR FIX: Remove unnecessary %"...%" markers in holidays/us.rem
+
+- MINOR FIX: Don't use the -ffat-lto-objects if we're compiling with Clang.
+
+- MINOR FIX: Remind: Fix a broken printf-format string (need to double up on %
+  to get a literal % in the output.)
+
+- BUG FIX: Make test suite pass regardless of the date on which it is run.
+  D'oh!!!
+
+- BUG FIX: Make sure the banner gets printed each time through a "*N"
+  command-line option loop.
+
+* VERSION 4.2 Patch 0 - 2022-10-14
 
 - NEW FEATURE: remind: Allow weekdays to be globally-omitted.  For example:
 
@@ -35,6 +63,16 @@ CHANGES TO REMIND
   %{name} or %*{name} that end up calling the function subst_name and using
   its return value as the replacement for the substitution sequence.
 
+- NEW FEATURE: remind: Add the FUNSET command to undefine a user-defined
+  function.
+
+- NEW FILES: Add standard include files holidays/jewish.rem and
+  ansitext.rem (the latter defines standard ANSI escape codes for
+  changing text attributes such as bold, underline, etc.)
+
+- NEW EXAMPLES: add examples/alignmemt.rem, examples/ansitext and
+  examples/astro
+
 - BUG FIX: remind: Make MSF correctly format UTF-8 text and text with
   embedded ANSI color-changing codes.
 
@@ -46,8 +84,12 @@ CHANGES TO REMIND
 
 - BUG FIX: Fix tests in non-UTF-8 locales.
 
-- BUG FIX: Fix a few problems with the include include/holidays/us.rem
-  file.
+- BUG FIX: Fix a few problems with the include/holidays/us.rem file.
+
+- BUG FIX: remind: Fix an ancient logic error in DBufPutc that hurt
+  performance.
+
+- MINOR IMPROVEMENT: Clean up code and remove some dead code.
 
 * VERSION 4.1 Patch 0 - 2022-09-25
 

examples/ansitext

@@ -0,0 +1,35 @@
+#!/bin/sh
+#
+# A little demo script that displays ANSI text attributes
+# Not all attributes work on all terminals... your mileage may vary.
+
+remind -@2 - <<'EOF'
+
+SET $AddBlankLines 0
+BANNER %
+INCLUDE [$SysInclude]/ansitext.rem
+MSG This file shows off some ANSI text attributes and colors.
+MSG Not all attributes work on all terminals.%_
+
+MSG This is [ansi_bold]bold.[ansi_normal]
+MSG This is [ansi_faint]faint.[ansi_normal]
+MSG This is [ansi_italic]italic.[ansi_normal]
+MSG This is [ansi_underline]underline.[ansi_normal]
+MSG This is [ansi_underline2]underline2.[ansi_normal]%_
+MSG This is [ansi_reverse]reverse.[ansi_normal]%_
+MSG This is [ansi_strikeout]strikeout.[ansi_normal]%_
+MSG This is [ansi_overline]overline.[ansi_normal]%_
+
+MSG This is [ansicolor(255,0,0)]red.[ansicolor("")]
+MSG This is [ansicolor(0,255,0)]green.[ansicolor("")]
+MSG This is [ansicolor(0,0,255)]blue.[ansicolor("")]
+MSG This is [ansicolor(255,255,0)]yellow.[ansicolor("")]
+MSG This is [ansicolor(255,0,255)]magenta.[ansicolor("")]
+MSG This is [ansicolor(0,255,255)]cyan.[ansicolor("")]%_
+
+# You can combine attributes
+MSG This is [ansicolor(0,255,0)][ansicolor(0,0,96,1)][ansi_italic][ansi_bold]Green-Bold-Italic-on-Blue[ansi_normal][ansicolor("")]
+
+EOF
+
+exit 0

examples/astro

@@ -13,6 +13,8 @@ SET bg_dark 1
 SET $AddBlankLines 0
 BANNER %
 
+MSG Today is [today()].%_
+
 IF bg_dark
    SPECIAL COLOR 255 255 0 Sunrise:       🌅 [sunrise()] today and [sunrise(today()+1)] tomorrow
    SPECIAL COLOR 255 128 0 Sunset:        🌇 [sunset()] today and [sunset(today()+1)] tomorrow%_

include/ansitext.rem

@@ -0,0 +1,34 @@
+# Global variables for various ANSI escape-code sequences
+# Not all sequences are supported by all terminals.
+
+# This file is part of REMIND
+# REMIND is Copyright (C) 1992-2022 by Dianne Skoll
+
+if !defined("ansi_bold")
+    # Disable ANSI attributes in calandar mode
+    if $CalMode
+        set ansi_normal     ""
+        set ansi_bold       ""
+        set ansi_faint      ""
+        set ansi_italic     ""
+        set ansi_underline  ""
+        set ansi_reverse    ""
+        set ansi_strikeout  ""
+        set ansi_underline2 ""
+        set ansi_overline   ""
+    else
+        set ansi_normal     char(27) + "[0m"
+        set ansi_bold       char(27) + "[1m"
+        set ansi_faint      char(27) + "[2m"
+        set ansi_italic     char(27) + "[3m"
+        set ansi_underline  char(27) + "[4m"
+        set ansi_reverse    char(27) + "[7m"
+        set ansi_strikeout  char(27) + "[9m"
+        set ansi_underline2 char(27) + "[21m"
+        set ansi_overline   char(27) + "[53m"
+    endif
+    preserve ansi_normal ansi_bold ansi_faint ansi_italic ansi_underline2 ansi_reverse ansi_strikeout ansi_underline2 ansi_overline
+endif
+
+# Example: REM MSG I must [ansi_bold]emphasize[ansi_normal] \
+#              the [ansi_italic]severity[ansi_normal] of the situation!

include/holidays/fr.rem

@@ -0,0 +1,20 @@
+#
+# France Holidays
+#
+# Source: Article L3133-1
+#   https://www.legifrance.gouv.fr/codes/section_lc/LEGITEXT000006072050/LEGISCTA000006178007/2016-08-10/
+#
+
+SET easter EASTERDATE($Uy)
+
+REM Jan  1      MSG %"Jour de l'an%"
+REM [easter+1]  MSG %"Lundi de Pâques%"
+REM May  1      MSG %"Fête du Travail%"
+REM May  8      MSG %"Victoire des alliés%"
+REM [easter+39] MSG %"Jeudi de l'Ascension%"
+REM [easter+50] MSG %"Lundi de Pentecôte%"
+REM Jul 14      MSG %"Fête nationale%"
+REM Aug 15      MSG %"Assomption%"
+REM Nov  1      MSG %"La Toussaint%"
+REM Nov 11      MSG %"Armistice%"
+REM Dec 25      MSG %"Noël%"

include/holidays/jewish.rem

@@ -0,0 +1,111 @@
+# Major Jewish Holidays
+
+# Set the variable InIsrael to 1 if you live in Israel.  Otherwise,
+# you get the Diaspora versions of Jewish holidays
+SET InIsrael value("InIsrael", 0)
+
+# Set the variable Reform to 1 if you want the Reform version of the
+# Jewish calendar.  Otherwise, you get the traditional version
+SET Reform value("Reform", 0)
+
+# Convenient function definition to save typing
+FSET _h(x, y) HEBDATE(x,y)
+FSET _h2(x, y) HEBDATE(x, y, $U-7)
+FSET _PastSat(x, y) IIF(WKDAYNUM(_h2(x,y))!=6, _h2(x,y), _h2(x,y)+1)
+FSET _BackTwoFri(x, y) IIF(WKDAYNUM(_h2(x,y))!=5, _h2(x,y), _h2(x,y)-2)
+FSET _BackTwoSat(x, y) IIF(WKDAYNUM(_h2(x,y))!=6, _h2(x,y), _h2(x,y)-2)
+# Default values in case InIsrael and Reform are not set
+SET InIsrael VALUE("InIsrael", 0)
+SET Reform   VALUE("Reform", 0)
+
+[_h(1,  "Tishrey")] ++4 MSG %"Rosh Hashana 1%" is %b.
+
+# No RH-2 or Tzom Gedalia in Reform
+IF !Reform
+   [_h(2,  "Tishrey")] ++4 MSG %"Rosh Hashana 2%" is %b.
+   [_PastSat(3,  "Tishrey")] ++4 MSG %"Tzom Gedalia%" is %b.
+ENDIF
+
+[_h(10, "Tishrey")] ++4 MSG %"Yom Kippur%" is %b.
+[_h(15, "Tishrey")] ++4 MSG %"Sukkot 1%" is %b.
+
+IF !InIsrael
+   [_h(16, "Tishrey")] MSG %"Sukkot 2%"
+ENDIF
+
+[_h(21, "Tishrey")] ++4 MSG %"Hoshana Rabba%" is %b.
+[_h(22, "Tishrey")] ++4 MSG %"Shemini Atzeret%" is %b.
+
+IF InIsrael
+   [_h(22, "Tishrey")] ++4 MSG %"Simchat Torah%" is %b.
+ELSE
+   [_h(23, "Tishrey")] ++4 MSG %"Simchat Torah%" is %b.
+ENDIF
+
+# Because Kislev can change length, we must be more careful about Chanukah
+FSET _chan(x) HEBDATE(24, "Kislev", $U-9)+x
+[_chan(1)] ++4 MSG %"Chanukah 1%" is %b.
+[_chan(2)] MSG %"Chanukah 2%"
+[_chan(3)] MSG %"Chanukah 3%"
+[_chan(4)] MSG %"Chanukah 4%"
+[_chan(5)] MSG %"Chanukah 5%"
+[_chan(6)] MSG %"Chanukah 6%"
+[_chan(7)] MSG %"Chanukah 7%"
+[_chan(8)] MSG %"Chanukah 8%"
+
+# Not sure about Reform's position on the next one.
+IF !Reform
+# 10 Tevet will never be a Saturday, so whether or not to
+# move it is moot.  (Thanks to Art Werschulz.)
+   [_h(10, "Tevet")] MSG %"Tzom Tevet%" is %b.
+ENDIF
+
+[_h(15, "Shvat")] ++4 MSG %"Tu B'Shvat%" is %b.
+[_h(14, "Adar A")] ++4 MSG %"Purim Katan%" is %b.
+
+# If Purim is on Sunday, then Fast of Esther is 11 Adar.
+IF WKDAYNUM(_h2(13, "Adar")) != 6
+   REM [_h2(13, "Adar")] ++4 MSG %"Fast of Esther%" is %b.
+ELSE
+   REM [_h2(11, "Adar")] ++4 MSG %"Fast of Esther%" is %b.
+ENDIF
+[_h(14, "Adar")] ++4 MSG %"Purim%" is %b.
+[_h(15, "Nisan")] ++4 MSG %"Pesach%" is %b.
+
+IF !InIsrael
+   [_h(16, "Nisan")] MSG %"Pesach 2%"
+ENDIF
+
+[_h(21, "Nisan")] MSG %"Pesach 7%"
+
+IF !InIsrael && !Reform
+   [_h(22, "Nisan")] MSG %"Pesach 8%"
+ENDIF
+
+[_h(27, "Nisan")] ++4 MSG %"Yom HaShoah%" is %b.
+[_BackTwoFri(4,  "Iyar")] ++4 MSG %"Yom HaZikaron%" is %b.
+[_BackTwoSat(5,  "Iyar")] ++4 MSG %"Yom Ha'atzmaut%" is %b.
+
+# Not sure about Reform's position on Lag B'Omer
+IF !Reform
+   [_h(18, "Iyar")] ++4 MSG %"Lag B'Omer%" is %b.
+ENDIF
+
+[_h(28, "Iyar")] ++4 MSG %"Yom Yerushalayim%" is %b.
+[_h(6,  "Sivan")] ++4 MSG %"Shavuot%" is %b.
+
+IF !InIsrael && !Reform
+   [_h(7, "Sivan")] MSG %"Shavuot 2%"
+ENDIF
+
+# Fairly sure Reform Jews don't observe the next two
+IF !Reform
+# Tzom Tamuz and Tish'a B'Av are moved to Sunday if they normally
+# fall on a Saturday
+   [_PastSat(17, "Tamuz")] ++4 MSG %"Tzom Tammuz%" is %b.
+   [_PastSat(9,  "Av")] ++4 MSG %"Tish'a B'Av%" is %b.
+ENDIF
+
+# Clean up
+FUNSET _h _h2 _PastSat _BackTwoFri _BackTwoSat _chan
+

include/holidays/us.rem

@@ -2,22 +2,22 @@
 # This file is part of REMIND.
 # Copyright (C) 1992-2022 Dianne Skoll
 
-REM  [easterdate($Uy)-46] MSG %"Ash Wednesday%"
-REM  [easterdate($Uy)-7]  MSG %"Palm Sunday%"
-OMIT [easterdate($Uy)-2]  MSG %"Good Friday%"
+REM  [easterdate($Uy)-46] MSG Ash Wednesday
+REM  [easterdate($Uy)-7]  MSG Palm Sunday
+OMIT [easterdate($Uy)-2]  MSG Good Friday
 OMIT [easterdate($Uy)]    MSG %"Easter%" Sunday
-REM  [easterdate($Uy)+39] MSG %"Ascension Day%"
-REM  [easterdate($Uy)+49] MSG %"Pentecost%"
+REM  [easterdate($Uy)+39] MSG Ascension Day
+REM  [easterdate($Uy)+49] MSG Pentecost
 
 # Some holidays are omitted, some are not.  You may want to change
 # which ones are omitted.
 
-OMIT Jan 1 MSG %"New Year's Day%"
+OMIT Jan 1 MSG New Year's Day
 REM Third Monday in Jan MSG Martin Luther King - %"MLK Day%"
-REM Feb 2 MSG %"Ground Hog Day%"
-REM Feb 14 MSG %"Valentine's Day%"
-REM Third Monday in Feb SCANFROM -7 ADDOMIT MSG %"President's Day%"
-REM Mar 17 MSG %"St. Patrick's Day%"
+REM Feb 2 MSG Ground Hog Day
+REM Feb 14 MSG Valentine's Day
+REM Third Monday in Feb SCANFROM -7 ADDOMIT MSG President's Day
+REM Mar 17 MSG St. Patrick's Day
 
 # These are accurate for most places in North America
 REM MAYBE-UNCOMPUTABLE Sun November SATISFY [isdst($T) != isdst($T+1)] MSG Daylight Saving Time Ends
@@ -25,30 +25,30 @@ REM MAYBE-UNCOMPUTABLE Sun March SATISFY [isdst($T) != isdst($T+1)] MSG Daylight
 
 REM Apr 1 MSG %"April Fool's%" Day
 REM Mon Tue Wed Thu Fri Sat 15 Apr MSG %"Income tax%" due
-REM May 5 MSG %"Cinco de Mayo%"
-REM First Sat in May MSG %"Kentucky Derby%"
-REM Second Sun in May MSG %"Mother's Day%"
-REM Third Sat in May MSG %"Armed Forces Day%"
-REM Last Monday in May SCANFROM -7 ADDOMIT MSG %"Memorial Day%"
-REM Jun 14 MSG %"Flag Day%"
+REM May 5 MSG Cinco de Mayo
+REM First Sat in May MSG Kentucky Derby
+REM Second Sun in May MSG Mother's Day
+REM Third Sat in May MSG Armed Forces Day
+REM Last Monday in May SCANFROM -7 ADDOMIT MSG Memorial Day
+REM Jun 14 MSG Flag Day
 
 REM July 4 SCANFROM -7 ADDOMIT MSG Independence Day
 REM July 3 SCANFROM -7 ADDOMIT SATISFY [$Tw == 5] MSG Independence Day (observed)
 REM July 5 SCANFROM -7 ADDOMIT SATISFY [$Tw == 1] MSG Independence Day (observed)
 
-REM Third Sun in June MSG %"Father's Day%"
-REM First Mon in Sep SCANFROM -7 ADDOMIT MSG %"Labor Day%"
-REM Second Mon in Oct MSG %"Columbus Day / Indigenous Peoples' Day%"
-REM Nov 11 MSG %"Veterans Day%"
+REM Third Sun in June MSG Father's Day
+REM First Mon in Sep SCANFROM -7 ADDOMIT MSG Labor Day
+REM Second Mon in Oct MSG Columbus Day / Indigenous Peoples' Day
+REM Nov 11 MSG Veterans Day
 
-REM Oct 30 MSG %"Mischief Night%"
-REM Oct 31 MSG %"Halloween%"
+REM Oct 30 MSG Mischief Night
+REM Oct 31 MSG Halloween
 
-REM Tue Nov  2 SCANFROM -7 SATISFY [($Ty % 4) == 0] MSG %"Election Day%"
+REM Tue Nov  2 SCANFROM -7 SATISFY [($Ty % 4) == 0] MSG Election Day
 
-REM Thu 22 Nov SCANFROM -7 ADDOMIT MSG %"Thanksgiving Day%"
+REM Thu 22 Nov SCANFROM -7 ADDOMIT MSG Thanksgiving Day
 
-REM Fri 23 Nov SCANFROM -7 ADDOMIT MSG %"Thanksgiving (cont.)%"
+REM Fri 23 Nov SCANFROM -7 ADDOMIT MSG Thanksgiving (cont.)
 
-REM Dec 24 MSG %"Christmas Eve%"
+REM Dec 24 MSG Christmas Eve
 OMIT Dec 25 MSG %"Christmas%" Day

man/remind.1.in

@@ -4152,6 +4152,19 @@ with future versions of \fBRemind\fR (which may define more built-in
 functions), you may wish to name all user-defined functions beginning
 with an underscore.
 .PP
+To delete a user-defined function, use \fBFUNSET\fR.  This takes a
+space-separated list of user-defined functions to delete.  For
+example, after the command:
+.PP
+.nf
+        FUNSET myfunc1 otherfunc thirdfunc
+.fi
+.PP
+it is guaranteed that no user-defined functions named myfunc1, otherfunc
+or thirdfunc will exist.  \fBRemind\fR does not issue an error if you
+try to \fBFUNSET\fR a nonexistent user-defined function; it simply
+does nothing in that case.
+.PP
 .SH PRECISE SCHEDULING
 .PP
 The \fBWARN\fR keyword allows precise control over advance warning in

scripts/tkremind

@@ -955,6 +955,7 @@ proc WriteOptionsToFile {} {
 #***********************************************************************
 proc LoadOptions {} {
     global Option ConfigFile
+    global MondayFirst
     set problem [catch {set f [open "$ConfigFile" "r"]}]
     if {$problem} {
 	return
@@ -974,6 +975,9 @@ proc LoadOptions {} {
         set Option($key) $val
     }
     close $f
+    if {[regexp -- {-m.*} $Option(ExtraRemindArgs)]} {
+	set MondayFirst 1
+    }
     font configure CalboxFont {*}$Option(CalboxFont)
     font configure HeadingFont {*}$Option(HeadingFont)
 }

src/calendar.c

@@ -744,7 +744,7 @@ SetMoonEntry(int jul, char const *moon)
 {
     int phase;
     int y, m, d;
-    char msg[32];
+    char msg[28];
 
     /* Don't bother unless it's utf-8 */
     if (!encoding_is_utf8) {
@@ -752,7 +752,7 @@ SetMoonEntry(int jul, char const *moon)
     }
 
     msg[0] = 0;
-    if (sscanf(moon, "%d %*d %*d %31[^\x01]", &phase, msg) < 4) {
+    if (sscanf(moon, "%d %*d %*d %27[^\x01]", &phase, msg) < 4) {
         if (sscanf(moon, "%d", &phase) != 1) {
             /* Malformed MOON special; ignore */
             fprintf(stderr, "Oops 1\n");
@@ -1649,6 +1649,7 @@ static void GenerateCalEntries(int col)
 	    case T_Exit:    DoExit(&p);	     break;
 	    case T_Set:     r=DoSet(&p);     break;
 	    case T_Fset:    r=DoFset(&p);    break;
+	    case T_Funset:  r=DoFunset(&p);  break;
 	    case T_UnSet:   r=DoUnset(&p);   break;
 	    case T_Clr:     r=DoClear(&p);   break;
 	    case T_Flush:   r=DoFlush(&p);   break;

src/dosubst.c

@@ -244,7 +244,7 @@ int DoSubst(ParsePtr p, DynamicBuffer *dbuf, Trigger *t, TimeTrig *tt, int jul,
                 }
             }
             if (!c) {
-                Wprint("Warning: Unterminated %{...} substitution sequence");
+                Wprint("Warning: Unterminated %%{...} substitution sequence");
             }
             if (UserFuncExists(s) != 3) {
                 continue;

src/dynbuf.h

@@ -31,6 +31,8 @@ int DBufGets(DynamicBuffer *dbuf, FILE *fp);
 #define DBufValue(bufPtr) ((bufPtr)->buffer)
 #define DBufLen(bufPtr) ((bufPtr)->len)
 
-#define DBufPutc(dbuf, c) ( (dbuf)->allocatedLen < (dbuf)->len+1 ) ? (dbuf)->buffer[(dbuf)->len++] = c, (dbuf)->buffer[(dbuf)->len] = 0, OK : DBufPutcFN((dbuf), c)
+#define DBufPutc(dbuf, c) ( ( (dbuf)->allocatedLen <= (dbuf)->len+1 ) ?   \
+    DBufPutcFN( (dbuf), c) : \
+    ( (dbuf)->buffer[(dbuf)->len++] = c, (dbuf)->buffer[(dbuf)->len] = 0, OK) )
 
 #endif /* DYNBUF_H */

src/expr.c

@@ -1194,9 +1194,9 @@ static int LogNot(void)
 
 /***************************************************************/
 /*                                                             */
-/*  FindFunc                                                   */
+/*  FindOperator                                               */
 /*                                                             */
-/*  Find a function.                                           */
+/*  Find an operator.                                          */
 /*                                                             */
 /***************************************************************/
 Operator *FindOperator(char const *name, Operator where[], int num)
@@ -1205,7 +1205,7 @@ Operator *FindOperator(char const *name, Operator where[], int num)
     int mid, r;
     while (top >= bot) {
 	mid = (top + bot) / 2;
-	r = StrCmpi(name, where[mid].name);
+	r = strcmp(name, where[mid].name);
 	if (!r) return &where[mid];
 	else if (r > 0) bot = mid+1;
 	else top = mid-1;
@@ -1213,6 +1213,20 @@ Operator *FindOperator(char const *name, Operator where[], int num)
     return NULL;
 }
 
+/* Compare two strings case-insensitively, where we KNOW
+   that the second string is definitely lower-case */
+static int strcmp_lcfirst(char const *s1, char const *s2)
+{
+    int r;
+    while (*s1 && *s2) {
+	r = tolower(*s1) - *s2;
+	if (r) return r;
+	s1++;
+	s2++;
+    }
+    return tolower(*s1) - *s2;
+}
+
 /***************************************************************/
 /*                                                             */
 /*  FindFunc                                                   */
@@ -1226,7 +1240,7 @@ BuiltinFunc *FindFunc(char const *name, BuiltinFunc where[], int num)
     int mid, r;
     while (top >= bot) {
 	mid = (top + bot) / 2;
-	r = StrCmpi(name, where[mid].name);
+	r = strcmp_lcfirst(name, where[mid].name);
 	if (!r) return &where[mid];
 	else if (r > 0) bot = mid+1;
 	else top = mid-1;

src/main.c

@@ -176,6 +176,8 @@ static void DoReminders(void)
     Parser p;
     int purge_handled;
 
+    DidMsgReminder = 0;
+
     if (!UseStdin) {
 	FileAccessDate = GetAccessDate(InitialFile);
     } else {
@@ -260,6 +262,7 @@ static void DoReminders(void)
 	    case T_Flush:   r=DoFlush(&p);   break;
 	    case T_Set:     r=DoSet(&p);     break;
 	    case T_Fset:    r=DoFset(&p);    break;
+	    case T_Funset:  r=DoFunset(&p);  break;
 	    case T_UnSet:   r=DoUnset(&p);   break;
 	    case T_Clr:     r=DoClear(&p);   break;
             case T_Debug:   r=DoDebug(&p);   break;

src/moon.c

@@ -400,8 +400,8 @@ static double phase(double pdate,
 		    double *suangdia)
 {
 
-    double Day, N, M, Ec, Lambdasun, ml, MM, MN, Ev, Ae, A3, MmP,
-	mEc, A4, lP, V, lPP, NP, y, x, Lambdamoon,
+    double Day, N, M, Ec, Lambdasun, ml, MM, Ev, Ae, A3, MmP,
+	mEc, A4, lP, V, lPP,
 	MoonAge, MoonPhase,
 	MoonDist, MoonDFrac, MoonAng,
 	F, SunDist, SunAng;
@@ -431,9 +431,6 @@ static double phase(double pdate,
     /* Moon's mean anomaly */
     MM = fixangle(ml - 0.1114041 * Day - mmlongp);
 
-    /* Moon's ascending node mean longitude */
-    MN = fixangle(mlnode - 0.0529539 * Day);
-
     /* Evection */
     Ev = 1.2739 * sin(torad(2 * (ml - Lambdasun) - MM));
 
@@ -461,19 +458,6 @@ static double phase(double pdate,
     /* 1 longitude */
     lPP = lP + V;
 
-    /* Corrected longitude of the node */
-    NP = MN - 0.16 * sin(torad(M));
-
-    /* Y inclination coordinate */
-    y = sin(torad(lPP - NP)) * cos(torad(minc));
-
-    /* X inclination coordinate */
-    x = cos(torad(lPP - NP));
-
-    /* Ecliptic longitude */
-    Lambdamoon = todeg(atan2(y, x));
-    Lambdamoon += NP;
-
     /* Calculation of the phase of the Moon */
 
     /* Age of the Moon in degrees */

src/protos.h

@@ -26,6 +26,7 @@
 
 int CallUserFunc (char const *name, int nargs, ParsePtr p);
 int DoFset (ParsePtr p);
+int DoFunset (ParsePtr p);
 void ProduceCalendar (void);
 char const *SimpleTime (int tim);
 char const *CalendarTime (int tim, int duration);

src/token.c

@@ -62,6 +62,7 @@ Token TokArray[] = {
     { "friday",		3,	T_WkDay,	4 },
     { "from",		4,	T_Scanfrom,	FROM_TYPE },
     { "fset",		4,	T_Fset,		0 },
+    { "funset",         6,      T_Funset,       0 },
     { "if",		2,	T_If,		0 },
     { "iftrig",		6,	T_IfTrig,	0 },
     { "in",             2,      T_In,           0 },
@@ -354,7 +355,8 @@ static int TokStrCmp(Token const *t, char const *s)
     register int r;
     char const *tk = t->name;
     while(*tk && *s && !(*s == ',' && *(s+1) == 0)) {
-	r = tolower(*tk) - tolower(*s);
+        /* t->name is already lower-case */
+	r = *tk - tolower(*s);
 	tk++;
 	s++;
 	if (r) return r;
@@ -362,5 +364,5 @@ static int TokStrCmp(Token const *t, char const *s)
     /* Ignore trailing commas on s */
 
     if (!*s || (*s == ',' && !*(s+1))) return 0;
-    return (tolower(*tk) - tolower(*s));
+    return (*tk - tolower(*s));
 }

src/types.h

@@ -155,7 +155,7 @@ enum TokTypes
   /* Commands first */
   T_Rem, T_Push, T_Pop, T_Preserve, T_Include, T_IncludeR, T_IncludeCmd, T_If, T_Else, T_EndIf,
   T_IfTrig, T_ErrMsg,
-  T_Set, T_UnSet, T_Fset, T_Omit, T_Banner, T_Exit,
+  T_Set, T_UnSet, T_Fset, T_Funset, T_Omit, T_Banner, T_Exit,
   T_AddOmit,
   T_WkDay,
   T_Month, T_Time, T_Date, T_DateTime,

src/userfns.c

@@ -53,6 +53,34 @@ static void FSet (UserFunc *f);
 static int SetUpLocalVars (UserFunc *f);
 static void DestroyLocalVals (UserFunc *f);
 
+/***************************************************************/
+/*                                                             */
+/*  DoFunset                                                   */
+/*                                                             */
+/*  Undefine a user-defined function - the FUNSET command.     */
+/*                                                             */
+/***************************************************************/
+int DoFunset(ParsePtr p)
+{
+    int r;
+    int seen_one = 0;
+    DynamicBuffer buf;
+    DBufInit(&buf);
+
+    while(1) {
+        r = ParseIdentifier(p, &buf);
+        if (r == E_EOLN) {
+            DBufFree(&buf);
+            break;
+        }
+        seen_one = 1;
+        FUnset(DBufValue(&buf));
+        DBufFree(&buf);
+    }
+    if (seen_one) return OK;
+    return E_PARSE_ERR;
+}
+
 /***************************************************************/
 /*                                                             */
 /*  DoFset                                                     */

src/utils.c

@@ -24,8 +24,6 @@ static char const DontEscapeMe[] =
 #include "globals.h"
 #include "protos.h"
 
-#define UPPER(c) toupper(c)
-
 /***************************************************************/
 /*                                                             */
 /*  StrnCpy                                                    */
@@ -68,12 +66,12 @@ int StrinCmp(char const *s1, char const *s2, int n)
     register int r;
     while (n && *s1 && *s2) {
 	n--;
-	r = UPPER(*s1) - UPPER(*s2);
+	r = toupper(*s1) - toupper(*s2);
 	if (r) return r;
 	s1++;
 	s2++;
     }
-    if (n) return (UPPER(*s1) - UPPER(*s2)); else return 0;
+    if (n) return (toupper(*s1) - toupper(*s2)); else return 0;
 }
 
 /***************************************************************/
@@ -102,12 +100,12 @@ int StrCmpi(char const *s1, char const *s2)
 {
     int r;
     while (*s1 && *s2) {
-	r = UPPER(*s1) - UPPER(*s2);
+	r = toupper(*s1) - toupper(*s2);
 	if (r) return r;
 	s1++;
 	s2++;
     }
-    return UPPER(*s1) - UPPER(*s2);
+    return toupper(*s1) - toupper(*s2);
 }
 
 /***************************************************************/

src/var.c

@@ -763,7 +763,6 @@ typedef struct {
     void *value;
     int min;
     int max;
-    int (*validate)(void const *newvalue);
 } SysVar;
 
 /* If the type of a sys variable is STR_TYPE, then min is redefined
@@ -775,107 +774,107 @@ typedef struct {
 
 /* All of the system variables sorted alphabetically */
 static SysVar SysVarArr[] = {
-    /*  name          mod  type              value          min/mal   max  validate*/
-    {"AddBlankLines",  1,  INT_TYPE,     &AddBlankLines,       0,      1,    NULL },
-    {"Ago",            1,  STR_TYPE,     &DynamicAgo,          0,      0,    NULL },
-    {"Am",             1,  STR_TYPE,     &DynamicAm,           0,      0,    NULL },
-    {"And",            1,  STR_TYPE,     &DynamicAnd,          0,      0,    NULL },
-    {"April",          1,  STR_TYPE,     &DynamicMonthName[3], 0,      0,    NULL },
-    {"At",             1,  STR_TYPE,     &DynamicAt,           0,      0,    NULL },
-    {"August",         1,  STR_TYPE,     &DynamicMonthName[7], 0,      0,    NULL },
-    {"CalcUTC",        1,  INT_TYPE,     &CalculateUTC,        0,      1,    NULL },
-    {"CalMode",        0,  INT_TYPE,     &DoCalendar,          0,      0,    NULL },
-    {"Daemon",         0,  INT_TYPE,     &Daemon,              0,      0,    NULL },
-    {"DateSep",        1,  SPECIAL_TYPE, date_sep_func,        0,      0,    NULL },
-    {"DateTimeSep",    1,  SPECIAL_TYPE, datetime_sep_func,    0,      0,    NULL },
-    {"December",       1,  STR_TYPE,     &DynamicMonthName[11],0,      0,    NULL },
-    {"DefaultColor",   1,  SPECIAL_TYPE, default_color_func,   0,      0,    NULL },
-    {"DefaultPrio",    1,  INT_TYPE,     &DefaultPrio,         0,      9999, NULL },
-    {"DefaultTDelta",  1,  INT_TYPE,     &DefaultTDelta,       0,      1440, NULL },
-    {"DeltaOffset",    0,  INT_TYPE,     &DeltaOffset,         0,      0,    NULL },
-    {"DontFork",       0,  INT_TYPE,     &DontFork,            0,      0,    NULL },
-    {"DontQueue",      0,  INT_TYPE,     &DontQueue,           0,      0,    NULL },
-    {"DontTrigAts",    0,  INT_TYPE,     &DontIssueAts,        0,      0,    NULL },
-    {"EndSent",        1,  STR_TYPE,     &EndSent,             0,      0,    NULL },
-    {"EndSentIg",      1,  STR_TYPE,     &EndSentIg,           0,      0,    NULL },
-    {"February",       1,  STR_TYPE,     &DynamicMonthName[1], 0,      0,    NULL },
-    {"FirstIndent",    1,  INT_TYPE,     &FirstIndent,         0,      132,  NULL },
-    {"FoldYear",       1,  INT_TYPE,     &FoldYear,            0,      1,    NULL },
-    {"FormWidth",      1,  INT_TYPE,     &FormWidth,           20,     500,  NULL },
-    {"Friday",         1,  STR_TYPE,     &DynamicDayName[4],   0,      0,    NULL },
-    {"Fromnow",        1,  STR_TYPE,     &DynamicFromnow,      0,      0,    NULL },
-    {"Hour",           1,  STR_TYPE,     &DynamicHour,         0,      0,    NULL },
-    {"Hplu",           1,  STR_TYPE,     &DynamicHplu,         0,      0,    NULL },
-    {"HushMode",       0,  INT_TYPE,     &Hush,                0,      0,    NULL },
-    {"IgnoreOnce",     0,  INT_TYPE,     &IgnoreOnce,          0,      0,    NULL },
-    {"InfDelta",       0,  INT_TYPE,     &InfiniteDelta,       0,      0,    NULL },
-    {"IntMax",         0,  INT_TYPE,     &IntMax,              0,      0,    NULL },
-    {"IntMin",         0,  INT_TYPE,     &IntMin,              0,      0,    NULL },
-    {"Is",             1,  STR_TYPE,     &DynamicIs,           0,      0,    NULL },
-    {"January",        1,  STR_TYPE,     &DynamicMonthName[0], 0,      0,    NULL },
-    {"July",           1,  STR_TYPE,     &DynamicMonthName[6], 0,      0,    NULL },
-    {"June",           1,  STR_TYPE,     &DynamicMonthName[5], 0,      0,    NULL },
-    {"LatDeg",         1,  SPECIAL_TYPE, latdeg_func,          0,      0,    NULL },
-    {"Latitude",       1,  SPECIAL_TYPE, latitude_func,        0,      0,    NULL },
-    {"LatMin",         1,  SPECIAL_TYPE, latmin_func,          0,      0,    NULL },
-    {"LatSec",         1,  SPECIAL_TYPE, latsec_func,          0,      0,    NULL },
-    {"Location",       1,  STR_TYPE,     &Location,            0,      0,    NULL },
-    {"LongDeg",        1,  SPECIAL_TYPE, longdeg_func,         0,      0,    NULL },
-    {"Longitude",      1,  SPECIAL_TYPE, longitude_func,       0,      0,    NULL },
-    {"LongMin",        1,  SPECIAL_TYPE, longmin_func,         0,      0,    NULL },
-    {"LongSec",        1,  SPECIAL_TYPE, longsec_func,         0,      0,    NULL },
-    {"March",          1,  STR_TYPE,     &DynamicMonthName[2], 0,      0,    NULL },
-    {"MaxSatIter",     1,  INT_TYPE,     &MaxSatIter,          10,     ANY,  NULL },
-    {"MaxStringLen",   1,  INT_TYPE,     &MaxStringLen,        -1,     ANY,  NULL },
-    {"May",            1,  STR_TYPE,     &DynamicMonthName[4], 0,      0,    NULL },
-    {"MinsFromUTC",    1,  INT_TYPE,     &MinsFromUTC,         -780,   780,  NULL },
-    {"Minute",         1,  STR_TYPE,     &DynamicMinute,       0,      0,    NULL },
-    {"Monday",         1,  STR_TYPE,     &DynamicDayName[0],   0,      0,    NULL },
-    {"Mplu",           1,  STR_TYPE,     &DynamicMplu,         0,      0,    NULL },
-    {"NextMode",       0,  INT_TYPE,     &NextMode,            0,      0,    NULL },
-    {"November",       1,  STR_TYPE,     &DynamicMonthName[10],0,      0,    NULL },
-    {"Now",            1,  STR_TYPE,     &DynamicNow,          0,      0,    NULL },
-    {"NumQueued",      0,  INT_TYPE,     &NumQueued,           0,      0,    NULL },
-    {"NumTrig",        0,  INT_TYPE,     &NumTriggered,        0,      0,    NULL },
-    {"October",        1,  STR_TYPE,     &DynamicMonthName[9], 0,      0,    NULL },
-    {"On",             1,  STR_TYPE,     &DynamicOn,           0,      0,    NULL },
-    {"Pm",             1,  STR_TYPE,     &DynamicPm,           0,      0,    NULL },
-    {"PrefixLineNo",   0,  INT_TYPE,     &DoPrefixLineNo,      0,      0,    NULL },
-    {"PSCal",          0,  INT_TYPE,     &PsCal,               0,      0,    NULL },
-    {"RunOff",         0,  INT_TYPE,     &RunDisabled,         0,      0,    NULL },
-    {"Saturday",       1,  STR_TYPE,     &DynamicDayName[5],   0,      0,    NULL },
-    {"September",      1,  STR_TYPE,     &DynamicMonthName[8], 0,      0,    NULL },
-    {"SimpleCal",      0,  INT_TYPE,     &DoSimpleCalendar,    0,      0,    NULL },
-    {"SortByDate",     0,  INT_TYPE,     &SortByDate,          0,      0,    NULL },
-    {"SortByPrio",     0,  INT_TYPE,     &SortByPrio,          0,      0,    NULL },
-    {"SortByTime",     0,  INT_TYPE,     &SortByTime,          0,      0,    NULL },
-    {"SubsIndent",     1,  INT_TYPE,     &SubsIndent,          0,      132,  NULL },
-    {"Sunday",         1,  STR_TYPE,     &DynamicDayName[6],   0,      0,    NULL },
-    {"SuppressLRM",    1,  INT_TYPE,     &SuppressLRM,         0,      1,    NULL },
-    {"SysInclude",     0,  STR_TYPE,     &SysDir,              0,      0,    NULL },
-    {"T",              0,  SPECIAL_TYPE, trig_date_func,       0,      0,    NULL },
-    {"Td",             0,  SPECIAL_TYPE, trig_day_func,        0,      0,    NULL },
-    {"TerminalBackground", 0, INT_TYPE,  &TerminalBackground,  0,      0,    NULL },
-    {"Thursday",       1,  STR_TYPE,     &DynamicDayName[3],   0,      0,    NULL },
-    {"TimeSep",        1,  SPECIAL_TYPE, time_sep_func,        0,      0,    NULL },
-    {"Tm",             0,  SPECIAL_TYPE, trig_mon_func,        0,      0,    NULL },
-    {"Today",          1,  STR_TYPE,     &DynamicToday,        0,      0,    NULL },
-    {"Tomorrow",       1,  STR_TYPE,     &DynamicTomorrow,     0,      0,    NULL },
-    {"Tuesday",        1,  STR_TYPE,     &DynamicDayName[1],   0,      0,    NULL },
-    {"Tw",             0,  SPECIAL_TYPE, trig_wday_func,       0,      0,    NULL },
-    {"Ty",             0,  SPECIAL_TYPE, trig_year_func,       0,      0,    NULL },
-    {"U",              0,  SPECIAL_TYPE, today_date_func,      0,      0,    NULL },
-    {"Ud",             0,  SPECIAL_TYPE, today_day_func,       0,      0,    NULL },
-    {"Um",             0,  SPECIAL_TYPE, today_mon_func,       0,      0,    NULL },
-    {"UntimedFirst",   0,  INT_TYPE,     &UntimedBeforeTimed,  0,      0,    NULL },
-    {"Use256Colors",   0,  INT_TYPE,     &Use256Colors,        0,      0,    NULL },
-    {"UseBGVTColors",  0,  INT_TYPE,     &UseBGVTColors,        0,      0,    NULL },
-    {"UseTrueColors",  0,  INT_TYPE,     &UseTrueColors,       0,      0,    NULL },
-    {"UseVTColors",    0,  INT_TYPE,     &UseVTColors,         0,      0,    NULL },
-    {"Uw",             0,  SPECIAL_TYPE, today_wday_func,      0,      0,    NULL },
-    {"Uy",             0,  SPECIAL_TYPE, today_year_func,      0,      0,    NULL },
-    {"Was",            1,  STR_TYPE,     &DynamicWas,          0,      0,    NULL },
-    {"Wednesday",      1,  STR_TYPE,     &DynamicDayName[2],   0,      0,    NULL }
+    /*  name          mod  type              value          min/mal   max */
+    {"AddBlankLines",  1,  INT_TYPE,     &AddBlankLines,       0,      1 },
+    {"Ago",            1,  STR_TYPE,     &DynamicAgo,          0,      0 },
+    {"Am",             1,  STR_TYPE,     &DynamicAm,           0,      0 },
+    {"And",            1,  STR_TYPE,     &DynamicAnd,          0,      0 },
+    {"April",          1,  STR_TYPE,     &DynamicMonthName[3], 0,      0 },
+    {"At",             1,  STR_TYPE,     &DynamicAt,           0,      0 },
+    {"August",         1,  STR_TYPE,     &DynamicMonthName[7], 0,      0 },
+    {"CalcUTC",        1,  INT_TYPE,     &CalculateUTC,        0,      1 },
+    {"CalMode",        0,  INT_TYPE,     &DoCalendar,          0,      0 },
+    {"Daemon",         0,  INT_TYPE,     &Daemon,              0,      0 },
+    {"DateSep",        1,  SPECIAL_TYPE, date_sep_func,        0,      0 },
+    {"DateTimeSep",    1,  SPECIAL_TYPE, datetime_sep_func,    0,      0 },
+    {"December",       1,  STR_TYPE,     &DynamicMonthName[11],0,      0 },
+    {"DefaultColor",   1,  SPECIAL_TYPE, default_color_func,   0,      0 },
+    {"DefaultPrio",    1,  INT_TYPE,     &DefaultPrio,         0,      9999 },
+    {"DefaultTDelta",  1,  INT_TYPE,     &DefaultTDelta,       0,      1440 },
+    {"DeltaOffset",    0,  INT_TYPE,     &DeltaOffset,         0,      0 },
+    {"DontFork",       0,  INT_TYPE,     &DontFork,            0,      0 },
+    {"DontQueue",      0,  INT_TYPE,     &DontQueue,           0,      0 },
+    {"DontTrigAts",    0,  INT_TYPE,     &DontIssueAts,        0,      0 },
+    {"EndSent",        1,  STR_TYPE,     &EndSent,             0,      0 },
+    {"EndSentIg",      1,  STR_TYPE,     &EndSentIg,           0,      0 },
+    {"February",       1,  STR_TYPE,     &DynamicMonthName[1], 0,      0 },
+    {"FirstIndent",    1,  INT_TYPE,     &FirstIndent,         0,      132 },
+    {"FoldYear",       1,  INT_TYPE,     &FoldYear,            0,      1 },
+    {"FormWidth",      1,  INT_TYPE,     &FormWidth,           20,     500 },
+    {"Friday",         1,  STR_TYPE,     &DynamicDayName[4],   0,      0 },
+    {"Fromnow",        1,  STR_TYPE,     &DynamicFromnow,      0,      0 },
+    {"Hour",           1,  STR_TYPE,     &DynamicHour,         0,      0 },
+    {"Hplu",           1,  STR_TYPE,     &DynamicHplu,         0,      0 },
+    {"HushMode",       0,  INT_TYPE,     &Hush,                0,      0 },
+    {"IgnoreOnce",     0,  INT_TYPE,     &IgnoreOnce,          0,      0 },
+    {"InfDelta",       0,  INT_TYPE,     &InfiniteDelta,       0,      0 },
+    {"IntMax",         0,  INT_TYPE,     &IntMax,              0,      0 },
+    {"IntMin",         0,  INT_TYPE,     &IntMin,              0,      0 },
+    {"Is",             1,  STR_TYPE,     &DynamicIs,           0,      0 },
+    {"January",        1,  STR_TYPE,     &DynamicMonthName[0], 0,      0 },
+    {"July",           1,  STR_TYPE,     &DynamicMonthName[6], 0,      0 },
+    {"June",           1,  STR_TYPE,     &DynamicMonthName[5], 0,      0 },
+    {"LatDeg",         1,  SPECIAL_TYPE, latdeg_func,          0,      0 },
+    {"Latitude",       1,  SPECIAL_TYPE, latitude_func,        0,      0 },
+    {"LatMin",         1,  SPECIAL_TYPE, latmin_func,          0,      0 },
+    {"LatSec",         1,  SPECIAL_TYPE, latsec_func,          0,      0 },
+    {"Location",       1,  STR_TYPE,     &Location,            0,      0 },
+    {"LongDeg",        1,  SPECIAL_TYPE, longdeg_func,         0,      0 },
+    {"Longitude",      1,  SPECIAL_TYPE, longitude_func,       0,      0 },
+    {"LongMin",        1,  SPECIAL_TYPE, longmin_func,         0,      0 },
+    {"LongSec",        1,  SPECIAL_TYPE, longsec_func,         0,      0 },
+    {"March",          1,  STR_TYPE,     &DynamicMonthName[2], 0,      0 },
+    {"MaxSatIter",     1,  INT_TYPE,     &MaxSatIter,          10,     ANY },
+    {"MaxStringLen",   1,  INT_TYPE,     &MaxStringLen,        -1,     ANY },
+    {"May",            1,  STR_TYPE,     &DynamicMonthName[4], 0,      0 },
+    {"MinsFromUTC",    1,  INT_TYPE,     &MinsFromUTC,         -780,   780 },
+    {"Minute",         1,  STR_TYPE,     &DynamicMinute,       0,      0 },
+    {"Monday",         1,  STR_TYPE,     &DynamicDayName[0],   0,      0 },
+    {"Mplu",           1,  STR_TYPE,     &DynamicMplu,         0,      0 },
+    {"NextMode",       0,  INT_TYPE,     &NextMode,            0,      0 },
+    {"November",       1,  STR_TYPE,     &DynamicMonthName[10],0,      0 },
+    {"Now",            1,  STR_TYPE,     &DynamicNow,          0,      0 },
+    {"NumQueued",      0,  INT_TYPE,     &NumQueued,           0,      0 },
+    {"NumTrig",        0,  INT_TYPE,     &NumTriggered,        0,      0 },
+    {"October",        1,  STR_TYPE,     &DynamicMonthName[9], 0,      0 },
+    {"On",             1,  STR_TYPE,     &DynamicOn,           0,      0 },
+    {"Pm",             1,  STR_TYPE,     &DynamicPm,           0,      0 },
+    {"PrefixLineNo",   0,  INT_TYPE,     &DoPrefixLineNo,      0,      0 },
+    {"PSCal",          0,  INT_TYPE,     &PsCal,               0,      0 },
+    {"RunOff",         0,  INT_TYPE,     &RunDisabled,         0,      0 },
+    {"Saturday",       1,  STR_TYPE,     &DynamicDayName[5],   0,      0 },
+    {"September",      1,  STR_TYPE,     &DynamicMonthName[8], 0,      0 },
+    {"SimpleCal",      0,  INT_TYPE,     &DoSimpleCalendar,    0,      0 },
+    {"SortByDate",     0,  INT_TYPE,     &SortByDate,          0,      0 },
+    {"SortByPrio",     0,  INT_TYPE,     &SortByPrio,          0,      0 },
+    {"SortByTime",     0,  INT_TYPE,     &SortByTime,          0,      0 },
+    {"SubsIndent",     1,  INT_TYPE,     &SubsIndent,          0,      132 },
+    {"Sunday",         1,  STR_TYPE,     &DynamicDayName[6],   0,      0 },
+    {"SuppressLRM",    1,  INT_TYPE,     &SuppressLRM,         0,      1 },
+    {"SysInclude",     0,  STR_TYPE,     &SysDir,              0,      0 },
+    {"T",              0,  SPECIAL_TYPE, trig_date_func,       0,      0 },
+    {"Td",             0,  SPECIAL_TYPE, trig_day_func,        0,      0 },
+    {"TerminalBackground", 0, INT_TYPE,  &TerminalBackground,  0,      0 },
+    {"Thursday",       1,  STR_TYPE,     &DynamicDayName[3],   0,      0 },
+    {"TimeSep",        1,  SPECIAL_TYPE, time_sep_func,        0,      0 },
+    {"Tm",             0,  SPECIAL_TYPE, trig_mon_func,        0,      0 },
+    {"Today",          1,  STR_TYPE,     &DynamicToday,        0,      0 },
+    {"Tomorrow",       1,  STR_TYPE,     &DynamicTomorrow,     0,      0 },
+    {"Tuesday",        1,  STR_TYPE,     &DynamicDayName[1],   0,      0 },
+    {"Tw",             0,  SPECIAL_TYPE, trig_wday_func,       0,      0 },
+    {"Ty",             0,  SPECIAL_TYPE, trig_year_func,       0,      0 },
+    {"U",              0,  SPECIAL_TYPE, today_date_func,      0,      0 },
+    {"Ud",             0,  SPECIAL_TYPE, today_day_func,       0,      0 },
+    {"Um",             0,  SPECIAL_TYPE, today_mon_func,       0,      0 },
+    {"UntimedFirst",   0,  INT_TYPE,     &UntimedBeforeTimed,  0,      0 },
+    {"Use256Colors",   0,  INT_TYPE,     &Use256Colors,        0,      0 },
+    {"UseBGVTColors",  0,  INT_TYPE,     &UseBGVTColors,        0,      0 },
+    {"UseTrueColors",  0,  INT_TYPE,     &UseTrueColors,       0,      0 },
+    {"UseVTColors",    0,  INT_TYPE,     &UseVTColors,         0,      0 },
+    {"Uw",             0,  SPECIAL_TYPE, today_wday_func,      0,      0 },
+    {"Uy",             0,  SPECIAL_TYPE, today_year_func,      0,      0 },
+    {"Was",            1,  STR_TYPE,     &DynamicWas,          0,      0 },
+    {"Wednesday",      1,  STR_TYPE,     &DynamicDayName[2],   0,      0 }
 };
 
 #define NUMSYSVARS ( sizeof(SysVarArr) / sizeof(SysVar) )
@@ -906,16 +905,7 @@ int SetSysVar(char const *name, Value *value)
         DestroyValue(*value);
         return r;
     }
-    if (v->validate) {
-        if (v->type == STR_TYPE) {
-            r = (v->validate)((void *) value->v.str);
-        } else {
-            r = (v->validate)((void *) &(value->v.val));
-        }
-        if (r != OK) {
-            return r;
-        }
-    }
+
     if (v->type == STR_TYPE) {
         /* If it's already the same, don't bother doing anything */
         if (!strcmp(value->v.str, (char const *) v->value)) {

tests/test-rem

@@ -398,6 +398,9 @@ EOF
 TZ=America/Toronto ../src/remind -dxe ../tests/tz.rem >> ../tests/test.out 2>&1
 TZ=Europe/Berlin ../src/remind -dxe ../tests/tz.rem >> ../tests/test.out 2>&1
 
+# Test that banner is printed on every iteration
+echo "MSG Should be three banners." | ../src/remind - 2022-10-20 '*3' >> ../tests/test.out 2>&1
+
 # Remove references to SysInclude, which is build-specific
 grep -F -v '$SysInclude' < ../tests/test.out > ../tests/test.out.1 && mv -f ../tests/test.out.1 ../tests/test.out
 cmp -s ../tests/test.out ../tests/test.cmp

tests/tz.rem

@@ -1,30 +1,30 @@
 # Test conversion between local time and UTC
 
 set a localtoutc('2022-01-01@12:00')
-set a localtoutc('2022-03-13@02:59')
-set a localtoutc('2022-03-13@03:00')
-set a localtoutc('2022-03-13@03:01')
+set a localtoutc('2022-03-13@03:59')
+set a localtoutc('2022-03-13@04:00')
+set a localtoutc('2022-03-13@04:01')
 set a localtoutc('2022-06-01@12:00')
-set a localtoutc('2022-11-06@01:59')
-set a localtoutc('2022-11-06@02:00')
-set a localtoutc('2022-11-06@02:01')
+set a localtoutc('2022-11-06@02:59')
+set a localtoutc('2022-11-06@03:00')
+set a localtoutc('2022-11-06@03:01')
 set a localtoutc('2022-12-01@12:00')
 
 set b utctolocal('2022-01-01@17:00')
 set b utctolocal('2022-03-13@06:00')
-set b utctolocal('2022-03-13@06:01')
-set b utctolocal('2022-03-13@06:59')
+set b utctolocal('2022-03-13@07:01')
+set b utctolocal('2022-03-13@07:59')
 set b utctolocal('2022-03-13@07:00')
 set b utctolocal('2022-03-13@07:01')
 set b utctolocal('2022-03-13@07:59')
 set b utctolocal('2022-06-01@16:00')
-set b utctolocal('2022-11-06@05:59')
-set b utctolocal('2022-11-06@06:00')
-set b utctolocal('2022-11-06@06:01')
-set b utctolocal('2022-11-06@06:59')
+set b utctolocal('2022-11-06@03:59')
 set b utctolocal('2022-11-06@07:00')
 set b utctolocal('2022-11-06@07:01')
-set b utctolocal('2022-12-01@17:00')
+set b utctolocal('2022-11-06@07:59')
+set b utctolocal('2022-11-06@08:00')
+set b utctolocal('2022-11-06@08:01')
+set b utctolocal('2022-12-01@18:00')
 
 set c timezone('2022-07-01')
 set c timezone('2022-12-01')