felixfoertsch/remind
1
0
Fork 0
mirror of https://salsa.debian.org/dskoll/remind.git synced 2026-04-17 14:59:20 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make decision to drop privileges based on euid instead of uid

Browse Source
This commit is contained in:
Dianne Skoll
2021-10-15 20:36:58 -04:00
parent 3e2794548b
commit f4f5552975
1 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/init.c
View File

@@ -710,7 +710,7 @@ void Usage(void)
/***************************************************************/
static void ChgUser(char const *user)
{
uid_t myuid;
uid_t myeuid;
struct passwd *pwent;
static char *home;
@@ -718,7 +718,7 @@ static void ChgUser(char const *user)
static char *username;
static char *logname;
myuid = getuid();
myeuid = geteuid();
pwent = getpwnam(user);
@@ -727,20 +727,23 @@ static void ChgUser(char const *user)
exit(EXIT_FAILURE);
}
if (!myeuid) {
/* Started as root, so drop privileges */
#ifdef HAVE_INITGROUPS
if (!myuid && (initgroups(pwent->pw_name, pwent->pw_gid) < 0)) {
fprintf(ErrFp, ErrMsg[M_NO_CHG_GID], pwent->pw_gid);
exit(EXIT_FAILURE);
};
if (initgroups(pwent->pw_name, pwent->pw_gid) < 0) {
fprintf(ErrFp, ErrMsg[M_NO_CHG_GID], pwent->pw_gid);
exit(EXIT_FAILURE);
};
#endif
if (!myuid && (setgid(pwent->pw_gid) < 0)) {
fprintf(ErrFp, ErrMsg[M_NO_CHG_GID], pwent->pw_gid);
exit(EXIT_FAILURE);
}
if (setgid(pwent->pw_gid) < 0) {
fprintf(ErrFp, ErrMsg[M_NO_CHG_GID], pwent->pw_gid);
exit(EXIT_FAILURE);
}
if (!myuid && (setuid(pwent->pw_uid) < 0)) {
fprintf(ErrFp, ErrMsg[M_NO_CHG_UID], pwent->pw_uid);
exit(EXIT_FAILURE);
if (setuid(pwent->pw_uid) < 0) {
fprintf(ErrFp, ErrMsg[M_NO_CHG_UID], pwent->pw_uid);
exit(EXIT_FAILURE);
}
}
home = malloc(strlen(pwent->pw_dir) + 6);