Disable Siri, Share and Reply (from NSE) Extensions. (#7619)

Podfile

@@ -104,22 +104,12 @@ abstract_target 'RiotPods' do
     end
   end
 
-  target "RiotShareExtension" do
-    import_MatrixSDK
-    import_MatrixKit_pods
-  end
-
   target "RiotSwiftUI" do
     import_SwiftUI_pods
-  end 
+  end
 
   target "RiotSwiftUITests" do
     import_SwiftUI_pods
-  end 
-
-  target "SiriIntents" do
-    import_MatrixSDK
-    import_MatrixKit_pods
   end
 
   target "RiotNSE" do
@@ -131,6 +121,18 @@ abstract_target 'RiotPods' do
     import_MatrixSDK
   end
 
+  # Disabled due to crypto corruption issues.
+  # https://github.com/vector-im/element-ios/issues/7618
+  # target "RiotShareExtension" do
+  #   import_MatrixSDK
+  #   import_MatrixKit_pods
+  # end
+  #
+  # target "SiriIntents" do
+  #   import_MatrixSDK
+  #   import_MatrixKit_pods
+  # end
+
 end
 
 post_install do |installer|

Podfile.lock

@@ -208,6 +208,6 @@ SPEC CHECKSUMS:
   zxcvbn-ios: fef98b7c80f1512ff0eec47ac1fa399fc00f7e3c
   ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb
 
-PODFILE CHECKSUM: 0e7e10f516d40d9df60cb874170b91603c632118
+PODFILE CHECKSUM: f8d711a31048bfd5981d17b00487a85996b62983
 
 COCOAPODS: 1.11.3

Riot/SupportingFiles/Riot-Bridging-Header.h

@@ -44,7 +44,7 @@
 #import "ContactDetailsViewController.h"
 #import "RoomInputToolbarView.h"
 #import "NSArray+Element.h"
-#import "ShareItemSender.h"
+#import "ShareItemSenderProtocol.h"
 #import "Contact.h"
 #import "RoomTimelineCellProvider.h"
 #import "PlainRoomTimelineCellProvider.h"

Riot/target.yml

@@ -34,8 +34,10 @@ targets:
     platform: iOS
 
     dependencies:
-    - target: RiotShareExtension
-    - target: SiriIntents
+    # Disabled due to crypto corruption issues.
+    # https://github.com/vector-im/element-ios/issues/7618
+    # - target: RiotShareExtension
+    # - target: SiriIntents
     - target: RiotNSE
     - target: BroadcastUploadExtension
     - target: DesignKit

RiotNSE/NotificationService.swift

@@ -799,7 +799,9 @@ class NotificationService: UNNotificationServiceExtension {
             return Constants.toBeRemovedNotificationCategoryIdentifier
         }
         
-        return "QUICK_REPLY"
+        // Don't return QUICK_REPLY here as there is an issue
+        // with crypto corruption when sending from extensions.
+        return nil
     }
     
     /// Attempts to send trigger a VoIP push for the given event

changelog.d/7618.change

@@ -0,0 +1 @@
+Disable Siri, Share and Reply (from NSE) Extensions.

project.yml

@@ -29,8 +29,6 @@ options:
 include:
   - path: Riot/target.yml
   - path: RiotTests/target.yml
-  - path: RiotShareExtension/target.yml
-  - path: SiriIntents/target.yml
   - path: RiotNSE/target.yml
   - path: BroadcastUploadExtension/target.yml
   - path: DesignKit/target.yml
@@ -39,6 +37,10 @@ include:
   - path: RiotSwiftUI/targetUITests.yml
   - path: CommonKit/target.yml
   - path: CommonKit/targetUnitTests.yml
+  # Disabled due to crypto corruption issues.
+  # https://github.com/vector-im/element-ios/issues/7618
+  # - path: RiotShareExtension/target.yml
+  # - path: SiriIntents/target.yml
 
 packages:
   AnalyticsEvents: