Merge pull request #6553 from vector-im/release/1.8.26/release

Release 1.8.26

CHANGES.md

@@ -1,3 +1,18 @@
+## Changes in 1.8.26 (2022-08-10)
+
+🙌 Improvements
+
+- Upgrade MatrixSDK version ([v0.23.15](https://github.com/matrix-org/matrix-ios-sdk/releases/tag/v0.23.15)).
+
+🐛 Bugfixes
+
+- Media: Fix a potential crash when dismissing an image. ([#6548](https://github.com/vector-im/element-ios/issues/6548))
+
+Others
+
+- Contacts Prompt: Clarify how contacts are used in the app. ([#6549](https://github.com/vector-im/element-ios/issues/6549))
+
+
 ## Changes in 1.8.25 (2022-08-09)
 
 🙌 Improvements

Config/AppVersion.xcconfig

@@ -15,5 +15,5 @@
 //
 
 // Version
-MARKETING_VERSION = 1.8.25
-CURRENT_PROJECT_VERSION = 1.8.25
+MARKETING_VERSION = 1.8.26
+CURRENT_PROJECT_VERSION = 1.8.26

Podfile

@@ -16,7 +16,7 @@ use_frameworks!
 # - `{ :specHash => {sdk spec hash}` to depend on specific pod options (:git => …, :podspec => …) for MatrixSDK repo. Used by Fastfile during CI
 #
 # Warning: our internal tooling depends on the name of this variable name, so be sure not to change it
-$matrixSDKVersion = '= 0.23.14'
+$matrixSDKVersion = '= 0.23.15'
 # $matrixSDKVersion = :local
 # $matrixSDKVersion = { :branch => 'develop'}
 # $matrixSDKVersion = { :specHash => { git: 'https://git.io/fork123', branch: 'fix' } }

Riot/Assets/en.lproj/InfoPlist.strings

@@ -18,7 +18,7 @@
 "NSCameraUsageDescription" = "The camera is used to take photos and videos, make video calls.";
 "NSPhotoLibraryUsageDescription" = "The photo library is used to send photos and videos.";
 "NSMicrophoneUsageDescription" = "Element needs to access your microphone to make and receive calls, take videos, and record voice messages.";
-"NSContactsUsageDescription" = "Element will show your contacts so you can invite them to chat.";
+"NSContactsUsageDescription" = "Element will check your contacts with your identity server to find who is on Matrix.";
 "NSCalendarsUsageDescription" = "See your scheduled meetings in the app.";
 "NSFaceIDUsageDescription" = "Face ID is used to access your app.";
 "NSLocationWhenInUseUsageDescription" = "When you share your location to people, Element needs access to show them a map.";

Riot/Modules/Room/Attachements/MXKAttachmentsViewController.m

@@ -1383,13 +1383,19 @@
 
 - (BOOL)prepareSubviewsForTransition:(BOOL)isStartInteraction
 {
-    MXKMediaCollectionViewCell *cell = (MXKMediaCollectionViewCell *)[self.attachmentsCollection.visibleCells firstObject];
+    // Sanity check
+    if (currentVisibleItemIndex >= attachments.count)
+    {
+        return NO;
+    }
+    
     MXKAttachment *attachment = attachments[currentVisibleItemIndex];
     NSString *mimeType = attachment.contentInfo[@"mimetype"];
 
     // Check attachment type for GIFs - this is required because of the extra WKWebView
     if (attachment.type == MXKAttachmentTypeImage && attachment.contentURL && [mimeType isEqualToString:@"image/gif"])
     {
+        MXKMediaCollectionViewCell *cell = (MXKMediaCollectionViewCell *)[self.attachmentsCollection.visibleCells firstObject];
         UIView *customView = cell.customView;
         for (UIView *v in customView.subviews)
         {

Riot/SupportingFiles/Info.plist

@@ -73,7 +73,7 @@
 	<key>NSCameraUsageDescription</key>
 	<string>The camera is used to take photos and videos, make video calls.</string>
 	<key>NSContactsUsageDescription</key>
-	<string>The contact book is used to send room invitation to your contacts with their emails.</string>
+	<string>Element will check your contacts with your identity server to find who is on Matrix.</string>
 	<key>NSFaceIDUsageDescription</key>
 	<string>Face ID is used to access your app.</string>
 	<key>NSLocationAlwaysAndWhenInUseUsageDescription</key>