Re-enable NSException on Share extension dismiss.

Disable crash logging in the share extension because of this.

Riot/Categories/Bundle.swift

@@ -30,4 +30,9 @@ public extension Bundle {
         }
         return bundle
     }
+    
+    /// Whether or not the bundle is the RiotShareExtension.
+    var isShareExtension: Bool {
+        bundleURL.lastPathComponent.contains("RiotShareExtension.appex")
+    }
 }

Riot/Modules/Analytics/Analytics.swift

@@ -121,8 +121,13 @@ import AnalyticsEvents
         
         MXLog.debug("[Analytics] Started.")
         
-        // Catch and log crashes
-        MXLogger.logCrashes(true)
+        if Bundle.main.isShareExtension {
+            // Don't log crashes in the share extension
+        } else {
+            // Catch and log crashes
+            MXLogger.logCrashes(true)
+        }
+        
         MXLogger.setBuildVersion(AppInfo.current.buildInfo.readableBuildVersion)
     }
     

RiotShareExtension/Sources/ShareExtensionRootViewController.m

@@ -99,6 +99,10 @@
 {
     [self dismissViewControllerAnimated:true completion:^{
         [self.presentingViewController dismissViewControllerAnimated:false completion:nil];
+        
+        // FIXME: Share extension memory usage increase when launched several times and then crash due to some memory leaks.
+        // For now, we force the share extension to exit and free memory.
+        [NSException raise:@"Kill the app extension" format:@"Free memory used by share extension"];
     }];
 }
 

changelog.d/5805.bugfix

@@ -0,0 +1 @@
+Share Extension: Stop logging crashes due to intentional exception that frees up memory and handle changes to MXRoom in the SDK.