felixfoertsch/bundesmessenger-ios
1
0
Fork 0
mirror of https://gitlab.opencode.de/bwi/bundesmessenger/clients/bundesmessenger-ios.git synced 2026-04-17 06:58:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add UTs

Browse Source
This commit is contained in:
Alfonso Grillo
2022-12-13 15:35:18 +01:00
parent a423199aa4
commit 4201c0060e
2 changed files with 71 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/Service/MatrixSDK/UserSessionsDataProvider.swift
View File

@@ -76,18 +76,25 @@ class UserSessionsDataProvider: UserSessionsDataProviderProtocol {
}
}
private extension UserSessionsDataProvider {
func deleteAccountDataIfNeeded(deviceList: [MXDevice]) {
extension UserSessionsDataProvider {
// internal just to facilitate tests
func obsoletedDeviceAccountData(deviceList: [MXDevice], accountDataEvents: [String: Any]) -> Set<String> {
let deviceAccountDataKeys = Set(
session
.accountData
.allAccountDataEvents()
accountDataEvents
.map(\.key)
.filter { $0.hasPrefix(kMXAccountDataTypeClientInformation) }
)
let expectedDeviceAccountDataKeys = Set(deviceList.map { "\(kMXAccountDataTypeClientInformation).\($0.deviceId)" })
let obsoletedDeviceAccountDataKeys = deviceAccountDataKeys.subtracting(expectedDeviceAccountDataKeys)
let expectedDeviceAccountDataKeys = Set(deviceList.map {
"\(kMXAccountDataTypeClientInformation).\($0.deviceId)"
})
return deviceAccountDataKeys.subtracting(expectedDeviceAccountDataKeys)
}
private func deleteAccountDataIfNeeded(deviceList: [MXDevice]) {
let obsoletedDeviceAccountDataKeys = obsoletedDeviceAccountData(deviceList: deviceList,
accountDataEvents: session.accountData.allAccountDataEvents())
for accountDataKey in obsoletedDeviceAccountDataKeys {
session.deleteAccountData(withType: accountDataKey, success: {}, failure: { _ in })

57
RiotTests/UserSessionsDataProviderTests.swift
View File

@@ -100,10 +100,67 @@ class UserSessionCardViewDataTests: XCTestCase {
XCTAssertEqual(verificationState, .permanentlyUnverified)
}
func testObsoletedDeviceInformation_someMatch() {
let mxSession = MockSession(canCrossSign: true)
let dataProvider = UserSessionsDataProvider(session: mxSession)
let accountDataEvents: [String: Any] = [
"io.element.matrix_client_information.D": ""
]
let expectedObsoletedEvents: Set = [
"io.element.matrix_client_information.D"
]
let obsoletedEvents = dataProvider.obsoletedDeviceAccountData(deviceList: .mockDevices, accountDataEvents: accountDataEvents)
XCTAssertEqual(obsoletedEvents, expectedObsoletedEvents)
}
func testObsoletedDeviceInformation_noMatch() {
let mxSession = MockSession(canCrossSign: true)
let dataProvider = UserSessionsDataProvider(session: mxSession)
let accountDataEvents: [String: Any] = [
"io.element.matrix_client_information.C": ""
]
let expectedObsoletedEvents: Set<String> = []
let obsoletedEvents = dataProvider.obsoletedDeviceAccountData(deviceList: .mockDevices, accountDataEvents: accountDataEvents)
XCTAssertEqual(obsoletedEvents, expectedObsoletedEvents)
}
func testObsoletedDeviceInformation_allMatch() {
let mxSession = MockSession(canCrossSign: true)
let dataProvider = UserSessionsDataProvider(session: mxSession)
let expectedObsoletedEvents = Set(["D", "E", "F"].map { "io.element.matrix_client_information.\($0)"})
let accountDataEvents: [String: Any] = expectedObsoletedEvents.reduce(into: [:]) { partialResult, value in
partialResult[value] = ""
}
let obsoletedEvents = dataProvider.obsoletedDeviceAccountData(deviceList: .mockDevices, accountDataEvents: accountDataEvents)
XCTAssertEqual(obsoletedEvents, expectedObsoletedEvents)
}
}
// MARK: Mocks
private extension Array where Element == MXDevice {
static let mockDevices: [MXDevice] = {
["A", "B", "C"]
.map {
let device = MXDevice()
device.deviceId = $0
return device
}
}()
}
// Device ID constants.
private extension String {
static var otherDeviceA: String { "abcdef" }