Merge pull request #2078 from aaronraimist/nsuserdefaults-synchronize

Remove all calls of [NSUserDefaults synchronize] (#1924)

Riot/AppDelegate.m

@@ -414,10 +414,8 @@ NSString *const kAppDelegateNetworkStatusDidChangeNotification = @"kAppDelegateN
         {
             // Move this setting into the shared userDefaults object to apply it to the extensions.
             [sharedUserDefaults setObject:language forKey:@"appLanguage"];
-            [sharedUserDefaults synchronize];
-            
+
             [[NSUserDefaults standardUserDefaults] removeObjectForKey:@"appLanguage"];
-            [[NSUserDefaults standardUserDefaults] synchronize];
         }
     }
     [NSBundle mxk_setLanguage:language];
@@ -2994,7 +2992,6 @@ NSString *const kAppDelegateNetworkStatusDidChangeNotification = @"kAppDelegateN
     if (!isErrorNotificationSuspended && ![[NSUserDefaults standardUserDefaults] boolForKey:@"deviceIdAtStartupChecked"])
     {
         [[NSUserDefaults standardUserDefaults] setBool:YES forKey:@"deviceIdAtStartupChecked"];
-        [[NSUserDefaults standardUserDefaults] synchronize];
         
         // Check if there is a device id
         if (!mxSession.matrixRestClient.credentials.deviceId)

Riot/Managers/Widgets/WidgetManager.m

@@ -527,7 +527,6 @@ NSString *const WidgetManagerErrorDomain = @"WidgetManagerErrorDomain";
     NSUserDefaults *userDefaults = [MXKAppSettings standardAppSettings].sharedUserDefaults;
 
     [userDefaults setObject:scalarTokens forKey:@"scalarTokens"];
-    [userDefaults synchronize];
 }
 
 @end

Riot/Modules/Authentication/AuthenticationViewController.m

@@ -682,9 +682,7 @@
         {
             [[NSUserDefaults standardUserDefaults] removeObjectForKey:@"customIdentityServerURL"];
         }
-        
-        [[NSUserDefaults standardUserDefaults] synchronize];
-        
+                
         // Restore default configuration
         [self setHomeServerTextFieldText:self.defaultHomeServerUrl];
         [self setIdentityServerTextFieldText:self.defaultIdentityServerUrl];

Riot/Modules/Settings/SettingsViewController.m

@@ -4155,7 +4155,6 @@ typedef void (^blockSettingsViewController_onReadyToDestroy)();
         // Store user settings
         NSUserDefaults *sharedUserDefaults = [MXKAppSettings standardAppSettings].sharedUserDefaults;
         [sharedUserDefaults setObject:language forKey:@"appLanguage"];
-        [sharedUserDefaults synchronize];
 
         // Do a reload in order to recompute strings in the new language
         // Note that "reloadMatrixSessions:NO" will reset room summaries