API: Rename FactionName.BachmanAssociates to FactionName.BachmanAndAssociates (#2183)

markdown/bitburner.factionnameenumtype.md

@@ -17,7 +17,7 @@ type FactionNameEnumType = {
   TheCovenant: "The Covenant";
   ECorp: "ECorp";
   MegaCorp: "MegaCorp";
-  BachmanAssociates: "Bachman & Associates";
+  BachmanAndAssociates: "Bachman & Associates";
   BladeIndustries: "Blade Industries";
   NWO: "NWO";
   ClarkeIncorporated: "Clarke Incorporated";

src/Achievements/Achievements.ts

@@ -750,7 +750,7 @@ export const achievements: Record<AchievementId, Achievement> = {
 // Steam has a limit of 100 achievement. So these were planned but commented for now.
 // { ID: FactionNames.ECorp.toUpperCase(), Condition: () => Player.factions.includes(FactionNames.ECorp) },
 // { ID: FactionNames.MegaCorp.toUpperCase(), Condition: () => Player.factions.includes(FactionNames.MegaCorp) },
-// { ID: "BACHMAN_&_ASSOCIATES", Condition: () => Player.factions.includes(FactionNames.BachmanAssociates) },
+// { ID: "BACHMAN_&_ASSOCIATES", Condition: () => Player.factions.includes(FactionNames.BachmanAndAssociates) },
 // { ID: "BLADE_INDUSTRIES", Condition: () => Player.factions.includes(FactionNames.BladeIndustries) },
 // { ID: FactionNames.NWO.toUpperCase(), Condition: () => Player.factions.includes(FactionNames.NWO) },
 // { ID: "CLARKE_INCORPORATED", Condition: () => Player.factions.includes(FactionNames.ClarkeIncorporated) },

src/Augmentation/Augmentations.ts

@@ -39,7 +39,7 @@ export const Augmentations: Record<AugmentationName, Augmentation> = (() => {
       factions: [
         FactionName.Silhouette,
         FactionName.FourSigma,
-        FactionName.BachmanAssociates,
+        FactionName.BachmanAndAssociates,
         FactionName.ClarkeIncorporated,
       ],
     },
@@ -685,7 +685,7 @@ export const Augmentations: Record<AugmentationName, Augmentation> = (() => {
       charisma: 1.6,
       charisma_exp: 1.6,
       factions: [
-        FactionName.BachmanAssociates,
+        FactionName.BachmanAndAssociates,
         FactionName.NWO,
         FactionName.ClarkeIncorporated,
         FactionName.OmniTekIncorporated,
@@ -731,7 +731,7 @@ export const Augmentations: Record<AugmentationName, Augmentation> = (() => {
       company_rep: 1.1,
       work_money: 1.2,
       factions: [
-        FactionName.BachmanAssociates,
+        FactionName.BachmanAndAssociates,
         FactionName.ClarkeIncorporated,
         FactionName.FourSigma,
         FactionName.KuaiGongInternational,
@@ -1089,7 +1089,7 @@ export const Augmentations: Record<AugmentationName, Augmentation> = (() => {
         FactionName.Aevum,
         FactionName.Ishima,
         FactionName.Volhaven,
-        FactionName.BachmanAssociates,
+        FactionName.BachmanAndAssociates,
         FactionName.ClarkeIncorporated,
         FactionName.FourSigma,
       ],
@@ -1247,7 +1247,7 @@ export const Augmentations: Record<AugmentationName, Augmentation> = (() => {
         FactionName.Chongqing,
         FactionName.ClarkeIncorporated,
         FactionName.FourSigma,
-        FactionName.BachmanAssociates,
+        FactionName.BachmanAndAssociates,
       ],
     },
     [AugmentationName.NutriGen]: {
@@ -1466,7 +1466,7 @@ export const Augmentations: Record<AugmentationName, Augmentation> = (() => {
       charisma_exp: 1.5,
       company_rep: 1.25,
       faction_rep: 1.25,
-      factions: [FactionName.BachmanAssociates],
+      factions: [FactionName.BachmanAndAssociates],
     },
     [AugmentationName.SmartSonar]: {
       repCost: 2.25e4,
@@ -1492,7 +1492,7 @@ export const Augmentations: Record<AugmentationName, Augmentation> = (() => {
         FactionName.FourSigma,
         FactionName.KuaiGongInternational,
         FactionName.ClarkeIncorporated,
-        FactionName.BachmanAssociates,
+        FactionName.BachmanAndAssociates,
       ],
     },
     [AugmentationName.SpeechProcessor]: {

src/Company/data/CompaniesMetadata.ts

@@ -41,7 +41,7 @@ export function getCompaniesMetadata(): Record<CompanyName, CompanyCtorParams> {
       expMultiplier: 2.6,
       salaryMultiplier: 2.6,
       jobStatReqOffset: 224,
-      relatedFaction: FactionName.BachmanAssociates,
+      relatedFaction: FactionName.BachmanAndAssociates,
     },
     [CompanyName.BladeIndustries]: {
       name: CompanyName.BladeIndustries,

src/Faction/Enums.ts

@@ -4,7 +4,7 @@ export enum FactionName {
   TheCovenant = "The Covenant",
   ECorp = "ECorp",
   MegaCorp = "MegaCorp",
-  BachmanAssociates = "Bachman & Associates",
+  BachmanAndAssociates = "Bachman & Associates",
   BladeIndustries = "Blade Industries",
   NWO = "NWO",
   ClarkeIncorporated = "Clarke Incorporated",

src/Faction/FactionInfo.tsx

@@ -216,7 +216,7 @@ export const FactionInfos: Record<FactionName, FactionInfo> = {
     keepOnInstall: true,
   }),
 
-  [FactionName.BachmanAssociates]: new FactionInfo({
+  [FactionName.BachmanAndAssociates]: new FactionInfo({
     infoText: (
       <>
         Where Law and Business meet - that's where we are.

src/ScriptEditor/NetscriptDefinitions.d.ts

@@ -8670,7 +8670,7 @@ type FactionNameEnumType = {
   TheCovenant: "The Covenant";
   ECorp: "ECorp";
   MegaCorp: "MegaCorp";
-  BachmanAssociates: "Bachman & Associates";
+  BachmanAndAssociates: "Bachman & Associates";
   BladeIndustries: "Blade Industries";
   NWO: "NWO";
   ClarkeIncorporated: "Clarke Incorporated";

src/utils/APIBreaks/3.0.0.ts

@@ -198,5 +198,17 @@ export const breakingChanges300: VersionBreakingChange = {
         "This bug was fixed. Please check your code to see if it still works as you expect.",
       showPopUp: false,
     },
+    {
+      brokenAPIs: [
+        {
+          name: "ns.enums.FactionName.BachmanAssociates",
+          migration: { searchValue: "BachmanAssociates", replaceValue: "BachmanAndAssociates" },
+        },
+      ],
+      info:
+        'The key of "Bachman & Associates" faction in the FactionName enum was renamed.\n' +
+        '"ns.enums.FactionName.BachmanAssociates" has been automatically replaced with "ns.enums.FactionName.BachmanAndAssociates".',
+      showPopUp: false,
+    },
   ],
 };