felixfoertsch/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2026-04-27 19:37:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

REFACTOR: Change repNeededToDonate to favorNeededToDonate (#2134)

Browse Source 
It was wrong and confusing.
This commit is contained in:
David Walker
2025-05-13 14:13:00 -07:00
committed by GitHub
parent be2b5fac10
commit 48f6de9cf5
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Faction/formulas/donation.ts
+1 -1
View File
@@ -13,7 +13,7 @@ export function donationForRep(rep: number, person: IPerson): number {
return (rep * CONSTANTS.DonateMoneyToRepDivisor) / person.mults.faction_rep / currentNodeMults.FactionWorkRepGain; return (rep * CONSTANTS.DonateMoneyToRepDivisor) / person.mults.faction_rep / currentNodeMults.FactionWorkRepGain;
} }
export function repNeededToDonate(): number { export function favorNeededToDonate(): number {
return Math.floor(CONSTANTS.BaseFavorToDonate * currentNodeMults.RepToDonateToFaction); return Math.floor(CONSTANTS.BaseFavorToDonate * currentNodeMults.RepToDonateToFaction);
} }
src/Faction/ui/FactionRoot.tsx
+2 -2
View File
@@ -21,7 +21,7 @@ import { FactionName, FactionWorkType } from "@enums";
import { GangButton } from "./GangButton"; import { GangButton } from "./GangButton";
import { FactionWork } from "../../Work/FactionWork"; import { FactionWork } from "../../Work/FactionWork";
import { useCycleRerender } from "../../ui/React/hooks"; import { useCycleRerender } from "../../ui/React/hooks";
import { repNeededToDonate } from "../formulas/donation"; import { favorNeededToDonate } from "../formulas/donation";
type FactionRootProps = { type FactionRootProps = {
faction: Faction; faction: Faction;
@@ -103,7 +103,7 @@ function MainPage({ faction, rerender, onAugmentations }: IMainProps): React.Rea
// Flags for whether special options (gang, sleeve purchases, donate, etc.) // Flags for whether special options (gang, sleeve purchases, donate, etc.)
// should be shown // should be shown
const favorToDonate = repNeededToDonate(); const favorToDonate = favorNeededToDonate();
const canDonate = faction.favor >= favorToDonate; const canDonate = faction.favor >= favorToDonate;
const canPurchaseSleeves = faction.name === FactionName.TheCovenant && Player.bitNodeN === 10; const canPurchaseSleeves = faction.name === FactionName.TheCovenant && Player.bitNodeN === 10;
src/NetscriptFunctions/Singularity.ts
+3 -3
View File
@@ -30,7 +30,7 @@ import { calculateHackingTime } from "../Hacking";
import { Server } from "../Server/Server"; import { Server } from "../Server/Server";
import { netscriptCanHack } from "../Hacking/netscriptCanHack"; import { netscriptCanHack } from "../Hacking/netscriptCanHack";
import { FactionInfos } from "../Faction/FactionInfo"; import { FactionInfos } from "../Faction/FactionInfo";
import { donate, repNeededToDonate } from "../Faction/formulas/donation"; import { donate, favorNeededToDonate } from "../Faction/formulas/donation";
import { InternalAPI, setRemovedFunctions } from "../Netscript/APIWrapper"; import { InternalAPI, setRemovedFunctions } from "../Netscript/APIWrapper";
import { enterBitNode } from "../RedPill"; import { enterBitNode } from "../RedPill";
import { ClassWork } from "../Work/ClassWork"; import { ClassWork } from "../Work/ClassWork";
@@ -952,13 +952,13 @@ export function NetscriptSingularity(): InternalAPI<ISingularity> {
return false; return false;
} }
if (faction.favor < repNeededToDonate()) { if (faction.favor < favorNeededToDonate()) {
helpers.log( helpers.log(
ctx, ctx,
() => () =>
`You do not have enough favor to donate to this faction. Have ${ `You do not have enough favor to donate to this faction. Have ${
faction.favor faction.favor
}, need ${repNeededToDonate()}`, }, need ${favorNeededToDonate()}`,
); );
return false; return false;
} }