REFACTOR: Change repNeededToDonate to favorNeededToDonate (#2134)

It was wrong and confusing.

src/Faction/formulas/donation.ts

@@ -13,7 +13,7 @@ export function donationForRep(rep: number, person: IPerson): number {
   return (rep * CONSTANTS.DonateMoneyToRepDivisor) / person.mults.faction_rep / currentNodeMults.FactionWorkRepGain;
 }
 
-export function repNeededToDonate(): number {
+export function favorNeededToDonate(): number {
   return Math.floor(CONSTANTS.BaseFavorToDonate * currentNodeMults.RepToDonateToFaction);
 }
 

src/Faction/ui/FactionRoot.tsx

@@ -21,7 +21,7 @@ import { FactionName, FactionWorkType } from "@enums";
 import { GangButton } from "./GangButton";
 import { FactionWork } from "../../Work/FactionWork";
 import { useCycleRerender } from "../../ui/React/hooks";
-import { repNeededToDonate } from "../formulas/donation";
+import { favorNeededToDonate } from "../formulas/donation";
 
 type FactionRootProps = {
   faction: Faction;
@@ -103,7 +103,7 @@ function MainPage({ faction, rerender, onAugmentations }: IMainProps): React.Rea
 
   // Flags for whether special options (gang, sleeve purchases, donate, etc.)
   // should be shown
-  const favorToDonate = repNeededToDonate();
+  const favorToDonate = favorNeededToDonate();
   const canDonate = faction.favor >= favorToDonate;
   const canPurchaseSleeves = faction.name === FactionName.TheCovenant && Player.bitNodeN === 10;
 

src/NetscriptFunctions/Singularity.ts

@@ -30,7 +30,7 @@ import { calculateHackingTime } from "../Hacking";
 import { Server } from "../Server/Server";
 import { netscriptCanHack } from "../Hacking/netscriptCanHack";
 import { FactionInfos } from "../Faction/FactionInfo";
-import { donate, repNeededToDonate } from "../Faction/formulas/donation";
+import { donate, favorNeededToDonate } from "../Faction/formulas/donation";
 import { InternalAPI, setRemovedFunctions } from "../Netscript/APIWrapper";
 import { enterBitNode } from "../RedPill";
 import { ClassWork } from "../Work/ClassWork";
@@ -952,13 +952,13 @@ export function NetscriptSingularity(): InternalAPI<ISingularity> {
         return false;
       }
 
-      if (faction.favor < repNeededToDonate()) {
+      if (faction.favor < favorNeededToDonate()) {
         helpers.log(
           ctx,
           () =>
             `You do not have enough favor to donate to this faction. Have ${
               faction.favor
-            }, need ${repNeededToDonate()}`,
+            }, need ${favorNeededToDonate()}`,
         );
         return false;
       }