felixfoertsch/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2026-05-21 07:02:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

BLADEBURNER: Do not decrease player reputation when failing actions (#2768)

Browse Source
This commit is contained in:
catloversg
2026-05-17 01:51:02 +07:00
committed by GitHub
parent a46dd5df80
commit 42a3cbfa47
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Bladeburner/Bladeburner.ts
+5 -3
View File
@@ -1274,9 +1274,11 @@ export class Bladeburner implements OperationTeam {
}
this.maxRank = Math.max(this.rank, this.maxRank);
const bladeburnerFaction = Factions[FactionName.Bladeburners];
if (bladeburnerFaction.isMember) {
bladeburnerFaction.playerReputation += calculateActionReputationGain(person, change);
if (change > 0) {
const bladeburnerFaction = Factions[FactionName.Bladeburners];
if (bladeburnerFaction.isMember) {
bladeburnerFaction.playerReputation += calculateActionReputationGain(person, change);
}
}
// Gain skill points
test/jest/Bladeburner/Actions.test.ts
+8
View File
@@ -13,6 +13,7 @@ import {
BladeburnerOperationName,
CityName,
CrimeType,
FactionName,
} from "@enums";
import { FormatsNeedToChange } from "../../../src/ui/formatNumber";
import { CrimeWork } from "../../../src/Work/CrimeWork";
@@ -21,6 +22,8 @@ import type { Skills } from "@nsdefs";
import { applyAugmentation } from "../../../src/Augmentation/AugmentationHelpers";
import { PlayerOwnedAugmentation } from "../../../src/Augmentation/PlayerOwnedAugmentation";
import { BlackOperation } from "../../../src/Bladeburner/Actions/BlackOperation";
import { joinFaction } from "../../../src/Faction/FactionHelpers";
import { Factions } from "../../../src/Faction/Factions";
describe("Bladeburner Actions", () => {
const SampleContract = Contract.createId(BladeburnerContractName.Tracking);
@@ -244,8 +247,12 @@ describe("Bladeburner Actions", () => {
describe.each([SampleOperation, SampleBlackOp])("operations and black operations decrease rank", (id) => {
it(`${id.type}`, () => {
before = bb.rank;
joinFaction(Factions[FactionName.Bladeburners]);
expect(Player.factions.includes(FactionName.Bladeburners)).toBe(true);
expect(Factions[FactionName.Bladeburners].playerReputation).toBe(0);
complete(id, forceFailure);
expect(bb.rank).toBeLessThan(before);
expect(Factions[FactionName.Bladeburners].playerReputation).toBe(0);
});
});
});
@@ -262,6 +269,7 @@ describe("Bladeburner Actions", () => {
beforeEach(() => {
setPlayer(new PlayerObject());
Factions[FactionName.Bladeburners].prestigeSourceFile();
/** Need BN5 to receive Int EXP */
Player.sourceFiles.set(5, 3);