8 Commits

Author SHA1 Message Date
rebloor
82217a05bc Replace var with let in examples (#484)
* Replace var with let in examples

store-collected-images/webextension-plain/deps/uuidv4.js

* Reverted third–party code
2022-08-11 04:27:28 +12:00
Aad Versteden
b1b896627a Add doc that received url parameter must be a valid URL
The `new URL(url)` statement will throw an error if the supplied
string is not a valid URL.  Adding a note to the function to clarify
that as requested by @Rob--W.
2020-12-31 13:31:56 +01:00
Aad Versteden
4cddd8497c Use URL interface in apply-css example
By using the URL interface, the user is ascertained that the piece of
code does not manipulate the DOM.  Keeping them in the right mental
context for the example.

The apply-css example uses the protocol of the URL of the tab to
determine if a pageAction should be shown.  Any page that is hosted
over http or https will receive the page action.

The former implementation creates an anchor tag, assigns the URL to
that, and fetches the protocol from there.  This PR alters that to
using the URL interface.  This makes it clear to the user that we're
staying in JavaScript land and will not start manipulating the visible
DOM.  I would argue this is cleaner all together, but I'm very open to
learning about a different opinion.

The URL interface is more broadly supported than the
pageAction.setIcon which this example is also dependent on, so this
change should not change compatibility of this Browser Extension.
2020-12-31 10:36:57 +01:00
YFdyh000
0a745348f3 Fixes for ESLint 2017-07-09 05:55:13 +08:00
wbamberg
c5d69d15d6 Rewrite examples to use browser.* and promises (#138) 2016-11-15 10:12:55 -08:00
Will Bamberg
9e6945676c Update based review comments, and show action only in http(s) pages 2016-08-17 15:54:02 -07:00
Will Bamberg
c3eff787af Added comments to apply-css/background.js 2016-08-17 11:24:35 -07:00
Will Bamberg
c4b5b841f1 New example, showing insertCSS and removeCSS 2016-08-17 11:21:30 -07:00