From 8b260a9a7f4b8d40f0184d2296de46774eacf87d Mon Sep 17 00:00:00 2001 From: Gabriel Aubut-Lussier Date: Wed, 5 Nov 2025 21:56:42 -0500 Subject: [PATCH] Fix the example with Firefox on macOS when managed storage isn't available. (#554) Co-authored-by: rebloor Co-authored-by: Simeon Vincent --- favourite-colour/options.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/favourite-colour/options.js b/favourite-colour/options.js index 542fa1e..f929640 100644 --- a/favourite-colour/options.js +++ b/favourite-colour/options.js @@ -6,8 +6,16 @@ async function saveOptions(e) { } async function restoreOptions() { - let res = await browser.storage.managed.get('colour'); - document.querySelector("#managed-colour").innerText = res.colour; + try { + let res = await browser.storage.managed.get('colour'); + document.querySelector("#managed-colour").innerText = res.colour || "Could not find 'colour' in managed storage."; + } catch(error) { + if (error.message === "Managed storage manifest not found") { + document.querySelector("#managed-colour").innerText = "Managed storage manifest not found. Make sure it's stored in an appropriate location."; + } else { + document.querySelector("#managed-colour").innerText = `Unexpected managed storage error: ${error.message}`; + } + } res = await browser.storage.sync.get('colour'); document.querySelector("#colour").value = res.colour || 'Firefox red';