From a783b3c7397335e6e71d12e308297eb6b8b5a679 Mon Sep 17 00:00:00 2001 From: hsvflight <39955795+hsvflight@users.noreply.github.com> Date: Sun, 15 Jun 2025 21:33:33 -0500 Subject: [PATCH 1/2] Update Plugin.cs - Guid empty Getting this error: [2025-06-16 00:41:58.499 +00:00] [FTL] Unhandled Exception System.ArgumentException: Guid can't be empty (Parameter 'id') at Jellyfin.Plugin.TubeArchivistMetadata.Plugin.OnPlaybackProgress(...) And right after playback fails [2025-06-16 00:42:23.345 +00:00] [INF] Playback stopped reported by app "Jellyfin Roku" "3.0.5" playing "Video". Stopped at "973000" ms --- Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs b/Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs index 600fabb..a1662a7 100644 --- a/Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs +++ b/Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs @@ -173,6 +173,11 @@ namespace Jellyfin.Plugin.TubeArchivistMetadata private async void OnPlaybackProgress(object? sender, PlaybackProgressEventArgs eventArgs) { + if (eventArgs == null || eventArgs.ItemId == Guid.Empty) + { + Logger.LogWarning("PlaybackProgress called with null or empty Guid."); + return; + } if (Instance!.Configuration.JFTASync && eventArgs.Users.Any(u => Instance!.Configuration.JFUsernameFrom.Equals(u.Username, StringComparison.Ordinal))) { BaseItem? season = LibraryManager.GetItemById(eventArgs.Item.ParentId); From ca0a9215feb7bc9e43db89506056ca309ad8cbf5 Mon Sep 17 00:00:00 2001 From: DarkFighterLuke <31162436+DarkFighterLuke@users.noreply.github.com> Date: Sun, 13 Jul 2025 11:39:32 +0200 Subject: [PATCH 2/2] Change log message The event is not catastrophic in Jellyfin, so it can be hidden the user unless debug level logs are enabled --- Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs b/Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs index a1662a7..bdb18ae 100644 --- a/Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs +++ b/Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs @@ -175,7 +175,7 @@ namespace Jellyfin.Plugin.TubeArchivistMetadata { if (eventArgs == null || eventArgs.ItemId == Guid.Empty) { - Logger.LogWarning("PlaybackProgress called with null or empty Guid."); + Logger.LogDebug("Skipping progress synchronization: PlaybackProgress event triggered with null or empty Guid."); return; } if (Instance!.Configuration.JFTASync && eventArgs.Users.Any(u => Instance!.Configuration.JFUsernameFrom.Equals(u.Username, StringComparison.Ordinal)))