felixfoertsch/tildes
1
0
Fork 0
mirror of https://gitlab.com/tildes/tildes.git synced 2026-04-17 23:08:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug with trying to unnest non-webargs errors

Browse Source 
When a ValidationError comes up for a reason unrelated to webargs (for
example, if a user tries to set a password that's in the breached list),
this crashes when trying to unnest it, since it doesn't have the extra
level that webargs adds.

This is a bit ugly, but checks to see whether the extra level is there
first.
This commit is contained in:
Deimos
2020-08-10 12:52:10 -06:00
parent 2e5a2d96bf
commit d61b848816
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tildes/tildes/views/exceptions.py
View File

@@ -28,11 +28,18 @@ from tildes.models.group import Group
def errors_from_validationerror(validation_error: ValidationError) -> Sequence[str]: def errors_from_validationerror(validation_error: ValidationError) -> Sequence[str]:
"""Extract errors from a marshmallow ValidationError into a displayable format.""" """Extract errors from a marshmallow ValidationError into a displayable format."""
# as of webargs 6.0, errors are inside a nested dict, where the first level should normalized_errors = validation_error.normalized_messages()
# As of webargs 6.0, errors are inside a nested dict, where the first level should
# always be a single-item dict with the key representing the "location" of the data # always be a single-item dict with the key representing the "location" of the data
# (e.g. query, form, etc.) - we don't care about that, so just skip that level # (e.g. query, form, etc.) - Check if the errors seem to be in that format, and if
errors_by_location = validation_error.normalized_messages() # they are, just remove that level since we don't care about it
errors_by_field = list(errors_by_location.values())[0] first_value = list(normalized_errors.values())[0]
if isinstance(first_value, dict):
errors_by_field = first_value
else:
# not a webargs error, so just use the original without any unnesting
errors_by_field = normalized_errors
error_strings = [] error_strings = []
for field, errors in errors_by_field.items(): for field, errors in errors_by_field.items():