This just removes an unnecessary foreign key constraint, where we
already do the garbage collection manually in the database service.
However, as part of getting here I tried a couple of other variants
along the way:
- Changing the order of the primary key from `(hash, blocklist_hash,
idx)` to `(blocklist_hash, idx, hash)` so that inserts would be
naturally ordered. However this requires a new index `on blocks (hash)`
so that we can still look up blocks by hash, and turns out to be
strictly worse than what we already have.
- Removing the primary key entirely and the `WITHOUT ROWID` to make it a
rowid table without any required order, and an index as above. This is
faster when the table is small, but becomes slower when it's large (due
to dual indexes I guess).
These are the benchmark results from current `main`, the second
alternative below ("Index(hash)") and this proposal that retains the
combined primary key ("combined"). Overall it ends up being about 65%
faster.
<img width="764" height="452" alt="Screenshot 2025-08-29 at 14 36 28"
src="https://github.com/user-attachments/assets/bff3f9d1-916a-485f-91b7-b54b477f5aac"
/>
Ref #10264
252 lines
6.1 KiB
Go
252 lines
6.1 KiB
Go
// Copyright (C) 2025 The Syncthing Authors.
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
// You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
package sqlite
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/syncthing/syncthing/internal/timeutil"
|
|
"github.com/syncthing/syncthing/lib/config"
|
|
"github.com/syncthing/syncthing/lib/protocol"
|
|
"github.com/syncthing/syncthing/lib/rand"
|
|
)
|
|
|
|
var globalFi protocol.FileInfo
|
|
|
|
func BenchmarkUpdate(b *testing.B) {
|
|
db, err := Open(b.TempDir())
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
b.Cleanup(func() {
|
|
if err := db.Close(); err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
})
|
|
|
|
fs := make([]protocol.FileInfo, 100)
|
|
|
|
seed := 0
|
|
size := 1000
|
|
const numBlocks = 1000
|
|
|
|
for size < 200_000 {
|
|
for {
|
|
local, err := db.CountLocal(folderID, protocol.LocalDeviceID)
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
if local.Files >= size {
|
|
break
|
|
}
|
|
fs := make([]protocol.FileInfo, 1000)
|
|
for i := range fs {
|
|
fs[i] = genFile(rand.String(24), numBlocks, 0)
|
|
}
|
|
if err := db.Update(folderID, protocol.LocalDeviceID, fs); err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
|
|
b.Run(fmt.Sprintf("n=Insert100Loc/size=%d", size), func(b *testing.B) {
|
|
for range b.N {
|
|
for i := range fs {
|
|
fs[i] = genFile(rand.String(24), numBlocks, 0)
|
|
}
|
|
if err := db.Update(folderID, protocol.LocalDeviceID, fs); err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
b.ReportMetric(float64(b.N)*100.0/b.Elapsed().Seconds(), "files/s")
|
|
})
|
|
|
|
b.Run(fmt.Sprintf("n=RepBlocks100/size=%d", size), func(b *testing.B) {
|
|
for range b.N {
|
|
for i := range fs {
|
|
fs[i].Blocks = genBlocks(fs[i].Name, seed, 64)
|
|
fs[i].Version = fs[i].Version.Update(42)
|
|
}
|
|
seed++
|
|
if err := db.Update(folderID, protocol.LocalDeviceID, fs); err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
b.ReportMetric(float64(b.N)*100.0/b.Elapsed().Seconds(), "files/s")
|
|
})
|
|
|
|
b.Run(fmt.Sprintf("n=RepSame100/size=%d", size), func(b *testing.B) {
|
|
for range b.N {
|
|
for i := range fs {
|
|
fs[i].Version = fs[i].Version.Update(42)
|
|
}
|
|
if err := db.Update(folderID, protocol.LocalDeviceID, fs); err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
b.ReportMetric(float64(b.N)*100.0/b.Elapsed().Seconds(), "files/s")
|
|
})
|
|
|
|
b.Run(fmt.Sprintf("n=Insert100Rem/size=%d", size), func(b *testing.B) {
|
|
for range b.N {
|
|
for i := range fs {
|
|
fs[i].Blocks = genBlocks(fs[i].Name, seed, 64)
|
|
fs[i].Version = fs[i].Version.Update(42)
|
|
fs[i].Sequence = timeutil.StrictlyMonotonicNanos()
|
|
}
|
|
if err := db.Update(folderID, protocol.DeviceID{42}, fs); err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
b.ReportMetric(float64(b.N)*100.0/b.Elapsed().Seconds(), "files/s")
|
|
})
|
|
|
|
b.Run(fmt.Sprintf("n=GetGlobal100/size=%d", size), func(b *testing.B) {
|
|
for range b.N {
|
|
for i := range fs {
|
|
_, ok, err := db.GetGlobalFile(folderID, fs[i].Name)
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
if !ok {
|
|
b.Fatal("should exist")
|
|
}
|
|
}
|
|
}
|
|
b.ReportMetric(float64(b.N)*100.0/b.Elapsed().Seconds(), "files/s")
|
|
})
|
|
|
|
b.Run(fmt.Sprintf("n=LocalSequenced/size=%d", size), func(b *testing.B) {
|
|
count := 0
|
|
for range b.N {
|
|
cur, err := db.GetDeviceSequence(folderID, protocol.LocalDeviceID)
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
it, errFn := db.AllLocalFilesBySequence(folderID, protocol.LocalDeviceID, cur-100, 0)
|
|
for f := range it {
|
|
count++
|
|
globalFi = f
|
|
}
|
|
if err := errFn(); err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
b.ReportMetric(float64(count)/b.Elapsed().Seconds(), "files/s")
|
|
})
|
|
|
|
b.Run(fmt.Sprintf("n=AllLocalBlocksWithHash/size=%d", size), func(b *testing.B) {
|
|
count := 0
|
|
for range b.N {
|
|
it, errFn := db.AllLocalBlocksWithHash(folderID, globalFi.Blocks[0].Hash)
|
|
for range it {
|
|
count++
|
|
}
|
|
if err := errFn(); err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
b.ReportMetric(float64(count)/b.Elapsed().Seconds(), "blocks/s")
|
|
})
|
|
|
|
b.Run(fmt.Sprintf("n=GetDeviceSequenceLoc/size=%d", size), func(b *testing.B) {
|
|
for range b.N {
|
|
_, err := db.GetDeviceSequence(folderID, protocol.LocalDeviceID)
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
})
|
|
b.Run(fmt.Sprintf("n=GetDeviceSequenceRem/size=%d", size), func(b *testing.B) {
|
|
for range b.N {
|
|
_, err := db.GetDeviceSequence(folderID, protocol.DeviceID{42})
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
})
|
|
|
|
b.Run(fmt.Sprintf("n=RemoteNeed/size=%d", size), func(b *testing.B) {
|
|
count := 0
|
|
for range b.N {
|
|
it, errFn := db.AllNeededGlobalFiles(folderID, protocol.DeviceID{42}, config.PullOrderAlphabetic, 0, 0)
|
|
for f := range it {
|
|
count++
|
|
globalFi = f
|
|
}
|
|
if err := errFn(); err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
b.ReportMetric(float64(count)/b.Elapsed().Seconds(), "files/s")
|
|
})
|
|
|
|
b.Run(fmt.Sprintf("n=LocalNeed100Largest/size=%d", size), func(b *testing.B) {
|
|
count := 0
|
|
for range b.N {
|
|
it, errFn := db.AllNeededGlobalFiles(folderID, protocol.LocalDeviceID, config.PullOrderLargestFirst, 100, 0)
|
|
for f := range it {
|
|
globalFi = f
|
|
count++
|
|
}
|
|
if err := errFn(); err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
b.ReportMetric(float64(count)/b.Elapsed().Seconds(), "files/s")
|
|
})
|
|
|
|
size += 1000
|
|
}
|
|
}
|
|
|
|
func TestBenchmarkDropAllRemote(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("slow test")
|
|
}
|
|
|
|
db, err := Open(t.TempDir())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
t.Cleanup(func() {
|
|
if err := db.Close(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
|
|
fs := make([]protocol.FileInfo, 1000)
|
|
seq := 0
|
|
for {
|
|
local, err := db.CountLocal(folderID, protocol.LocalDeviceID)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if local.Files >= 15_000 {
|
|
break
|
|
}
|
|
for i := range fs {
|
|
seq++
|
|
fs[i] = genFile(rand.String(24), 64, seq)
|
|
}
|
|
if err := db.Update(folderID, protocol.DeviceID{42}, fs); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := db.Update(folderID, protocol.LocalDeviceID, fs); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
t0 := time.Now()
|
|
if err := db.DropAllFiles(folderID, protocol.DeviceID{42}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
d := time.Since(t0)
|
|
t.Log("drop all took", d)
|
|
}
|