felixfoertsch/syncthing
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 10 Wiki Activity
Files
05cc6b0f432f0bfc707ce4dd4c97154593d92d51
syncthing/lib
T
History
bt90andGitHub 05cc6b0f43 chore(fs): speed up case normalization (#10013) 
### Purpose

Resurrecting https://github.com/syncthing/syncthing/pull/9365

### Testing

Current benchmark results:

```
goos: linux
goarch: amd64
pkg: github.com/syncthing/syncthing/lib/fs
cpu: AMD EPYC 7763 64-Core Processor                
                                           │  ../old.txt  │             ../new.txt              │
                                           │    sec/op    │   sec/op     vs base                │
UnicodeLowercase/ASCII_lowercase-4            43.68n ± 4%   12.19n ± 1%  -72.09% (p=0.000 n=10)
UnicodeLowercase/ASCII_mixedcase_start-4     200.65n ± 2%   59.49n ± 3%  -70.35% (p=0.000 n=10)
UnicodeLowercase/ASCII_mixedcase_end-4        95.50n ± 2%   59.10n ± 2%  -38.12% (p=0.000 n=10)
UnicodeLowercase/Latin1_lowercase-4           122.5n ± 1%   131.4n ± 1%   +7.27% (p=0.000 n=10)
UnicodeLowercase/Latin1_mixedcase_start-4     339.9n ± 2%   309.2n ± 1%   -9.05% (p=0.000 n=10)
UnicodeLowercase/Latin1_mixedcase_end-4       183.6n ± 2%   174.3n ± 1%   -5.04% (p=0.000 n=10)
UnicodeLowercase/Unicode_lowercase-4          456.6n ± 1%   440.5n ± 1%   -3.53% (p=0.000 n=10)
UnicodeLowercase/Unicode_mixedcase_start-4    625.9n ± 1%   595.6n ± 1%   -4.83% (p=0.000 n=10)
UnicodeLowercase/Unicode_mixedcase_end-4      516.2n ± 1%   495.5n ± 1%   -4.02% (p=0.000 n=10)
geomean                                       214.1n        150.4n       -29.72%

                                           │  ../old.txt  │             ../new.txt              │
                                           │     B/op     │    B/op     vs base                 │
UnicodeLowercase/ASCII_lowercase-4           0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/ASCII_mixedcase_start-4     24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/ASCII_mixedcase_end-4       24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Latin1_lowercase-4          0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Latin1_mixedcase_start-4    32.00 ± 0%     32.00 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Latin1_mixedcase_end-4      32.00 ± 0%     32.00 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Unicode_lowercase-4         0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Unicode_mixedcase_start-4   48.00 ± 0%     48.00 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Unicode_mixedcase_end-4     48.00 ± 0%     48.00 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                                 ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                           │  ../old.txt  │             ../new.txt              │
                                           │  allocs/op   │ allocs/op   vs base                 │
UnicodeLowercase/ASCII_lowercase-4           0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/ASCII_mixedcase_start-4     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/ASCII_mixedcase_end-4       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Latin1_lowercase-4          0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Latin1_mixedcase_start-4    1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Latin1_mixedcase_end-4      1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Unicode_lowercase-4         0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Unicode_mixedcase_start-4   1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
UnicodeLowercase/Unicode_mixedcase_end-4     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                                 ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean
```

I think the `+7%` for the lowercase Latin1 testcase is easily outweighed
by the ASCII and unicode improvements 🙂
2025-04-01 13:41:57 +02:00
..
api
fix(api): prevent tilde expansion in path suggestions (fixes #9990) (#9992)
2025-03-15 21:06:38 +01:00
assets
lib/assets: MIME types, time formats (#8351)
2022-05-22 22:10:18 +02:00
automaxprocs
all: Use own automaxprocs package that doesn't log (ref #9436) (#9437)
2024-02-27 13:05:19 +01:00
beacon
style: gofumpt all the things (#9829)
2024-11-19 11:32:56 +01:00
build
lib/sha256: Remove it (#9643)
2024-08-10 12:58:20 +01:00
config
chore(config): remove discontinued secondary STUN servers (fixes #10011) (#10012)
2025-03-31 06:41:33 +00:00
connections
refactor: use modern Protobuf encoder (#9817)
2024-12-01 16:50:17 +01:00
db
fix(db): correct unsafe RLock order (fixes #9906) (#9910)
2025-01-09 19:33:04 +01:00
dialer
style: gofumpt all the things (#9829)
2024-11-19 11:32:56 +01:00
discover
fix(discovery): properly unmarshal local discovery (#9880)
2024-12-19 20:16:44 +00:00
events
style: gofumpt all the things (#9829)
2024-11-19 11:32:56 +01:00
fs
chore(fs): speed up case normalization (#10013)
2025-04-01 13:41:57 +02:00
geoip
lib/geoip, cmd/relaypoolsrv, cmd/ursrv: Automatically manage GeoIP updates (#9342)
2024-05-18 20:31:49 +03:00
httpcache
cmd/stupgrades: Cache should apply to HEAD as well as GET
2023-02-22 12:22:52 +01:00
ignore
fix(ignore): ensure normalization of patterns and paths match (fixes #9597) (#9717)
2024-09-28 17:16:44 +02:00
locations
all: minimal set of changes for iOS app (#9619)
2024-07-31 07:31:14 +02:00
logger
all: Use some Go 1.21 features (#9409)
2024-02-10 21:02:42 +01:00
model
refactor: using slices.Contains to simplify the code (#9918)
2025-02-07 08:21:24 +00:00
nat
style: gofumpt all the things (#9829)
2024-11-19 11:32:56 +01:00
netutil
all: Remove lib/util package (#9049)
2023-08-21 19:44:33 +02:00
osutil
refactor: use modern Protobuf encoder (#9817)
2024-12-01 16:50:17 +01:00
pmp
style: gofumpt all the things (#9829)
2024-11-19 11:32:56 +01:00
protocol
chore(proto): change symlinktarget to be byte sequence (fixes #9913) (#9914)
2025-01-11 17:38:29 +01:00
rand
all: Remove unused method receivers (#8462)
2022-07-28 17:32:45 +02:00
rc
style: gofumpt all the things (#9829)
2024-11-19 11:32:56 +01:00
relay
refactor: use modern Protobuf encoder (#9817)
2024-12-01 16:50:17 +01:00
s3
feat(ursrv): new metrics based approach
2024-09-30 14:16:27 -05:00
scanner
chore(scanner): don't warn about cancelled scan (#9920)
2025-01-13 17:35:55 +00:00
semaphore
all: Remove lib/util package (#9049)
2023-08-21 19:44:33 +02:00
signature
lib/sha256: Remove it (#9643)
2024-08-10 12:58:20 +01:00
sliceutil
refactor: use modern Protobuf encoder (#9817)
2024-12-01 16:50:17 +01:00
stats
style: gofumpt all the things (#9829)
2024-11-19 11:32:56 +01:00
stringutil
all: Remove lib/util package (#9049)
2023-08-21 19:44:33 +02:00
structutil
all: Remove lib/util package (#9049)
2023-08-21 19:44:33 +02:00
stun
fix(stun): better error handling (ref #10008) (#10010)
2025-03-30 11:56:29 -07:00
svcutil
all: Remove lib/util package (#9049)
2023-08-21 19:44:33 +02:00
sync
lib/model: Use a single lock (phase two: cleanup) (#9276)
2023-12-11 22:06:45 +01:00
syncthing
chore(lib): expose model methods to obtain progress (#9886)
2025-03-28 13:44:01 +00:00
testutil
all: Remove lib/util package (#9049)
2023-08-21 19:44:33 +02:00
tlsutil
chore: enable TLS client cache for HTTPS where appropriate (#9721)
2024-09-24 08:55:04 +02:00
upgrade
style: gofumpt all the things (#9829)
2024-11-19 11:32:56 +01:00
upnp
style: gofumpt all the things (#9829)
2024-11-19 11:32:56 +01:00
ur
chore(ur): add RSS to reported stats (#10002)
2025-03-27 10:17:10 +01:00
versioner
refactor: use modern Protobuf encoder (#9817)
2024-12-01 16:50:17 +01:00
watchaggregator
refactor: use modern Protobuf encoder (#9817)
2024-12-01 16:50:17 +01:00
weakhash
style: gofumpt all the things (#9829)
2024-11-19 11:32:56 +01:00