Simon Frei and Jakob Borg
ec86db176e
lib/model: Handle invalid needed items on send-only (ref #7476 ) ( #7596 )
2021-04-26 15:38:08 +02:00
Jakob Borg and GitHub
e4c995a321
lib/model: Don't remove non-empty .stfolder ( #7578 )
2021-04-15 18:13:35 +02:00
André Colomb and GitHub
130d14cec9
api: Log API authorization failures. ( #7575 )
2021-04-15 07:33:02 +02:00
Simon Frei and GitHub
15d2dc3a4f
lib/connections: Add SyscallConn() to quic conn ( fixes #7551 ) ( #7570 )
2021-04-13 12:59:58 +01:00
André Colomb and GitHub
f6df1a760d
lib/api: Log the remote address on login attempts ( #7560 )
...
This enables usage of the audit log to e.g. automatically block remote
addresses from connecting after repeated login failures.
2021-04-13 10:14:44 +02:00
Simon Frei and GitHub
f71fcd440a
all: Remove untrusted feature flag ( fixes #109 ) ( #7567 )
...
No longer hide the web UI controls for the new untrusted/encrypted
device feature. Testing hasn't been very widespread, but there has been
some and quite a few bugs have been caught and fixed. I believe its time
to not hide it anymore, and cautiously recommend usage. E.g. mention
that the feature hasn't been widely used yet and anyone using it is an
early adopter, but drop the bit about not using it with production data.
We can maybe stress the need for backups in general and especially
using this.
2021-04-13 10:12:56 +02:00
Simon Frei and GitHub
1a00ea7c6e
lib: Prevent using protocol method with native path ( fixes #7557 ) ( #7563 )
2021-04-11 15:29:43 +02:00
Simon Frei and GitHub
ec0a66c75b
lib/db, lib/model: Refactor removing expired pending folders ( #7537 )
2021-04-11 15:24:08 +02:00
Jakob Borg and GitHub
8e38ecdeb2
Merge pull request from GHSA-x462-89pf-6r5h
2021-04-06 08:00:00 +02:00
Simon Frei and GitHub
f30f9c50f8
lib/db: Handle indirection error repairing sequences ( fixes #7026 ) ( #7525 )
2021-04-05 10:24:16 +02:00
Simon Frei and GitHub
0dcd9794d4
lib/protocol: Deterministic encrypted version ( fixes #7533 ) ( #7538 )
2021-03-31 08:59:15 +02:00
André Colomb and GitHub
fb2d85b9d5
lib/db: Fix comparison of pending folder timestamps ( fixes #7532 ) ( #7535 )
2021-03-30 21:24:53 +02:00
Simon Frei and GitHub
7f0d4f6ba8
lib/db: Don't panic debugging an inexistent file ( #7534 )
2021-03-30 20:06:01 +02:00
Simon Frei and GitHub
0d7a77ba85
lib/model: Reset conn when enc token is missing ( fixes #7198 ) ( #7518 )
2021-03-23 10:38:40 +01:00
Simon Frei and GitHub
924b96856f
lib: Handle adding enc folders on an existing conn ( fixes #7509 ) ( #7510 )
2021-03-22 21:50:19 +01:00
Simon Frei and GitHub
6b25eb2e79
lib/ur: Prevent panic when blocksResult is nil (ref #7495 ) ( #7515 )
2021-03-22 15:07:41 +01:00
Simon Frei and GitHub
bc08a951f1
lib/model: Encrypted fileinfo trailer needs to be in wire format ( #7505 )
2021-03-21 10:34:08 +01:00
Lars Lehtonen and GitHub
a87c5515bd
lib/model: Error check in test ( #7508 )
2021-03-21 10:32:17 +01:00
Jakob Borg and GitHub
ebcd22b02b
lib/osutil: Fix raising max FDs on macOS ( #7507 )
...
There was a logic mistake, so the limit in question wasn't used. On my
macOS this doesn't seem to matter, the hard limit returned is 2^63-1 and
setting the soft limit to that works. However I'm assuming that's not
the case for older macOSes since it was so nicely documented, so we
should still have this working. (10240 FDs should be enough for
anybody.)
2021-03-20 16:32:36 +01:00
Audrius Butkevicius and GitHub
4b02b7e6f1
lib/connections: Silence "connected to myself" messages. ( #7500 )
2021-03-17 23:53:20 +01:00
Jakob Borg
fdd823d2cb
lib/osutil: Remove unused code
2021-03-17 23:18:07 +01:00
Jakob Borg and GitHub
8ef504f745
all: Simplify some method calls ( #7499 )
...
strings.Replace(a, b, c, -1) -> strings.ReplaceAll(a, b, c)
(Go 1.12) and who knows what was up with that dialQueue.Sort() thing.
2021-03-17 23:12:26 +01:00
6c573a5762
Remove unnecessary guard around delete ( #7496 )
...
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2021-03-17 22:23:36 +01:00
Jakob Borg and GitHub
3ac858b150
all: Remove miscellaneous vestigial code ( #7495 )
2021-03-17 22:23:12 +01:00
Jakob Borg and GitHub
f4372710bf
all: Remove crypto/md5 ( #7493 )
...
This is a mostly pointless change to make security scanners and static
analysis tools happy, as they all hate seeing md5. None of our md5 uses
were security relevant, but still. Only visible effect of this change is
that our temp file names for very long file names become slightly longer
than they were previously...
2021-03-17 22:22:49 +01:00
Jakob Borg and GitHub
f39477bbd5
lib/api: Missing error handling in API delete-device ( #7494 )
2021-03-17 22:08:44 +01:00
Jakob Borg and GitHub
6e5514419d
lib/db: Fix some omitted error checks, unused variable ( #7489 )
2021-03-17 21:41:07 +01:00
Jakob Borg and GitHub
81484699db
lib/model: Actually break puller loop on context cancel ( #7492 )
...
Current break does nothing (breaks the select).
2021-03-17 21:34:52 +01:00
0930bccf88
cmd/ursrv, lib/scanner: Remove unnecessary slicing of slices ( #7491 )
...
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2021-03-17 21:04:36 +01:00
Jakob Borg and GitHub
e321bd3941
lib/*/auto: Add noassets files ( #7490 )
...
This adds a couple of dummy asset files protected by the "noassets"
build tag. The purpose is that it should be possible for, for example,
CI tools and static analysis things to compile and analyze the source
tree without our custom asset generation step. Also makes `go test -tags
noassets ./...` work without building assets first.
2021-03-17 21:03:35 +01:00
Simon Frei and GitHub
4b02937862
lib/model: Add missing lock on availability func ( #7487 )
2021-03-17 20:46:13 +01:00
Simon Frei and GitHub
3f2b584c4e
lib/model: Don't use ignore patterns for recv-enc folders ( fixes #7469 ) ( #7472 )
2021-03-16 15:04:11 +01:00
Simon Frei and GitHub
d2d4fcc1df
lib/protocol: Improve messages when an error occurs receiving (ref #7466 ) ( #7470 )
2021-03-15 19:14:09 +01:00
Simon Frei and GitHub
273ee09925
lib/db, lib/model: Allow needing invalid files ( fixes #7474 ) ( #7476 )
2021-03-15 07:58:01 +01:00
Simon Frei and GitHub
f80ee472c2
lib/protocol: Set invalid flag on encrypted file infos ( fixes #7466 ) ( #7467 )
2021-03-13 16:57:36 +01:00
Simon Frei and GitHub
97a8777d03
lib/fs: Check both old and new path when renaming ( fixes #7426 ) ( #7463 )
2021-03-12 21:15:50 +01:00
Simon Frei and GitHub
8a4c00d82e
lib/model: Send failure report on CC encryption check error ( #7460 )
2021-03-12 12:21:54 +01:00
Simon Frei and GitHub
31f859e909
lib/model: Return correct error in puller-iteration (ref #7424 ) ( #7461 )
2021-03-12 12:21:28 +01:00
Jakob Borg and GitHub
4d979a1ce9
all: Truncate some timestamps ( fixes #7457 ) ( #7459 )
...
This truncates times meant for API consumption to second precision,
where fractions won't typically matter or add any value. Exception to
this is timestamps on logs and events, and of course I'm not touching
things like file metadata.
I'm not 100% certain this is an exhaustive change, but it's the things I
found by grepping and following the breadcrumbs from lib/api...
I also considered general-but-ugly solutions, like having the API
serializer itself do reflection magic or even regexps on returned
objects, but decided against it because aurgh...
2021-03-12 10:35:10 +01:00
Simon Frei and GitHub
4465cdf8bc
lib/api: Fix body of renamed config/restart-required endpoint (ref #7402 ) ( #7453 )
2021-03-11 15:54:05 +01:00
Simon Frei and GitHub
3938b61c3f
lib/fs: Expose fs option on interface ( fixes #7385 , ref #7381 ) ( #7389 )
2021-03-11 15:23:56 +01:00
Jakob Borg and GitHub
cdef503db6
all: Make config.Wrapper an actual suture.Service ( fixes #7451 ) ( #7452 )
2021-03-11 14:51:00 +01:00
Jakob Borg and GitHub
df08984a58
lib/api: Sanitize names used in certificates ( fixes #7434 ) ( #7435 )
2021-03-11 13:15:03 +01:00
Simon Frei and GitHub
9a001051d6
cmd/ursrv, lib/ur: Collect and present encryption usage ( #7448 )
2021-03-10 22:26:56 +00:00
greatroar and GitHub
c00520281b
lib/protocol: Optimize FileKey ( #7440 )
2021-03-07 18:44:21 +01:00
Simon Frei and GitHub
310fba4c12
lib: Return error from db.FileSet.Snapshot ( fixes #7419 , ref #5907 ) ( #7424 )
2021-03-07 13:43:22 +01:00
Simon Frei and GitHub
767e1c6f58
lib/connections: Expose SetReadBuffer on conn passed to quic (ref #7417 ) ( #7432 )
2021-03-05 08:06:37 +01:00
Simon Frei and GitHub
3d91f7c975
lib: Use counterfeiter to mock interfaces in tests ( #7375 )
2021-03-03 08:53:50 +01:00
greatroar and GitHub
56b5352f64
all: Use crypt/rand through its buffered version, but not in benchmarks ( #7420 )
2021-03-02 19:17:20 +01:00
Jakob Borg and GitHub
55d5e03639
lib/db: Remove Badger experiment ( #7413 )
2021-03-01 09:16:08 +01:00