755d21953f
all: Remove unused method receivers ( #8462 )
...
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2022-07-28 17:32:45 +02:00
Jakob Borg and GitHub
adce6fa473
all: Support syncing ownership ( fixes #1329 ) ( #8434 )
...
This adds support for syncing ownership on Unixes and on Windows. The
scanner always picks up ownership information, but it is not applied
unless the new folder option "Sync Ownership" is set.
Ownership data is stored in a new FileInfo field called "platform data". This
is intended to hold further platform-specific data in the future
(specifically, extended attributes), which is why the whole design is a
bit overkill for just ownership.
2022-07-26 08:24:58 +02:00
Simon Frei and GitHub
5ac122b85f
lib/model: Don't include deleted items in kqueue warning threshold (ref #7855 ) ( #8365 )
2022-05-28 20:15:38 +02:00
Jakob Borg and GitHub
623ec03dad
lib/model: Correct type of event data ( fixes #8294 ) ( #8295 )
...
These things are fragile, every event should use an ${eventType}Data struct or something instead.
2022-04-21 15:45:31 +02:00
Simon Frei and GitHub
3907cb0693
lib/model: Subscribe to correct event for fs watching (ref #8249 ) ( #8287 )
2022-04-17 12:41:25 +04:00
Simon Frei and GitHub
db72579f0e
lib: Get rid of buggy filesystem wrapping ( #8257 )
2022-04-10 20:55:05 +02:00
Simon Frei and GitHub
edc3a77b98
lib/fs, lib/model: Add warning about kqueue resource usage ( fixes #7855 ) ( #8249 )
2022-04-05 21:32:06 +02:00
André Colomb and GitHub
30fa462e33
all: Comments and cosmetics ( #8218 )
...
* lib/api: Note ItemStarted and ItemFinished for default filtering.
The reasoning why LocalChangeDetected and RemoteChangeDetected events
are not included in the event stream by default (without explicit
filter mask requested) also holds for the ItemStarted and ItemFinished
events. They should be excluded as well when we start to break the
API compatibility for some reason.
* gui: Enumerate unused event types in the eventService.
Define constants for the unused event types as well, for completeness'
sake. They are intentionally not handled in the GUI currently.
* cmd/syncthing: Harmonize uppercase CLI argument placeholders.
Use ALL-UPPERCASE and connecting dashes to distinguish argument
placeholders from literal argument options (e.g. "cpu" or "heap" for
profiling). The dash makes it clear which words form a single
argument and where a new argument starts.
This style is already used for the "syncthing cli debug file" command.
* lib/model: Simplify event data structure.
Using map[string]interface{} is not necessary when all values are
known to be strings.
2022-04-02 20:36:19 +02:00
Simon Frei and GitHub
55c513b827
lib/model: Clear folder error after loading ignores ( fixes #8232 ) ( #8238 )
2022-03-27 21:29:40 +02:00
Jakob Borg and GitHub
f890fe6fd3
lib/config: Improve clarity of free space errors ( fixes #8180 ) ( #8191 )
2022-02-24 17:07:51 +01:00
Simon Frei and GitHub
635085d139
lib/db, lib/model: Remove filesystem state from FileSet ( fixes #7850 ) ( #8151 )
2022-01-31 10:12:52 +01:00
Simon Frei and GitHub
591e4d8af1
gui, lib: Fix tracking deleted locally-changed on encrypted ( fixes #7715 ) ( #7726 )
2021-11-10 09:46:21 +01:00
Simon Frei and GitHub
c025e76f30
lib/model: Do not wait for scan when setting ignores ( fixes #7893 ) ( #7891 )
2021-08-17 09:23:33 +02:00
Simon Frei and GitHub
445a82f120
lib/model: Compare all items with global on scan ( fixes #7740 ) ( #7791 )
2021-06-27 08:48:54 +02:00
Simon Frei and GitHub
c78fa42f31
lib/connections: Dial devices in parallel ( #7783 )
2021-06-25 11:38:04 +02:00
Simon Frei and GitHub
dd39556759
lib: Revert needing invalid files ( fixes #7608 , ref #7476 ) ( #7609 )
2021-04-29 22:01:46 +02:00
Simon Frei and GitHub
1a00ea7c6e
lib: Prevent using protocol method with native path ( fixes #7557 ) ( #7563 )
2021-04-11 15:29:43 +02:00
Simon Frei and GitHub
3f2b584c4e
lib/model: Don't use ignore patterns for recv-enc folders ( fixes #7469 ) ( #7472 )
2021-03-16 15:04:11 +01:00
Simon Frei and GitHub
310fba4c12
lib: Return error from db.FileSet.Snapshot ( fixes #7419 , ref #5907 ) ( #7424 )
2021-03-07 13:43:22 +01:00
Simon Frei and GitHub
c0f353c0e8
lib: Do not set ModifiedBy on meta only changes ( #7345 )
2021-02-08 15:30:39 +01:00
Simon Frei and GitHub
11e9d575c8
lib/model: Refactor folder.scanSubdirs into smaller parts ( #7321 )
2021-02-08 08:40:57 +01:00
Simon Frei and GitHub
249bcb3a01
lib/model: Optimize rename detection in scanner ( #7315 )
2021-01-31 21:02:42 +01:00
Simon Frei and GitHub
b2d82da20d
lib/model: Pull when folder leaves error state ( fixes #7280 ) ( #7281 )
2021-01-14 13:29:01 +01:00
Simon Frei and GitHub
a05dc6cc47
lib/model: Cleanup redundant filesystem variables in folders ( #7237 )
2020-12-27 22:26:25 +01:00
Simon Frei and GitHub
d904dfa191
lib/model: Fix flaky test and add some scanning debug ( #7214 )
2020-12-20 18:13:35 +01:00
Simon Frei and GitHub
9524b51708
all: Implement suture v4-api ( #6947 )
2020-11-17 13:19:04 +01:00
Simon Frei and GitHub
31559e908b
all: Add untrusted folders behind feature flag (ref #62 ) ( #7055 )
2020-11-09 15:33:32 +01:00
Simon Frei and GitHub
1f1729ba43
lib/model: Add done chan to track folder-lifetime ( fixes #6664 ) ( #7094 )
2020-11-09 09:05:48 +01:00
Simon Frei and GitHub
cc9ea9db89
lib/folder: Clear pull errors when nothing is needed anymore ( #7093 )
2020-11-06 14:22:20 +01:00
Simon Frei and GitHub
1a8c10a8d0
lib/model: Use winning version instead of merge on conflict ( #6995 )
2020-10-19 08:53:19 +02:00
Simon Frei and GitHub
9d09fd6af3
all: Add failure reporting ( fixes #7028 ) ( #6925 )
2020-10-07 10:05:13 +02:00
Simon Frei and GitHub
8452fd2ab4
lib/model, lib/scanner: Prevent races aborting scans ( fixes #6994 ) ( #6997 )
2020-09-25 11:27:44 +02:00
Simon Frei and GitHub
3dd13c3994
test, lib/model: Various integration test updates & improvements ( #6956 )
2020-09-07 09:35:37 +02:00
Simon Frei and GitHub
6365e6108f
lib/model: Don't acquire I/O token for send-only pull ( #6951 )
2020-09-03 13:59:45 +02:00
Audrius Butkevicius and GitHub
d507d932b8
all: Use protobuf to generate config structs ( fixes #6734 ) ( #6900 )
2020-08-25 08:11:14 +02:00
Simon Frei and GitHub
a65b46debd
lib/model: Don't mark globally deleted items as recv-only ( fixes #6910 ) ( #6911 )
2020-08-21 12:34:22 +02:00
Simon Frei and GitHub
b628460930
lib/model: Prevent localflag flipflopping on del. item (ref #6865 ) ( #6919 )
2020-08-21 10:09:48 +02:00
Simon Frei and GitHub
cc1f6e4d4a
lib/db, lib/model: Cover exec-paths with debug logging ( #6918 )
2020-08-20 16:11:20 +02:00
Simon Frei and GitHub
a85bc1c3a6
lib/model: Check folder error before sync-waiting ( fixes #6793 ) ( #6847 )
2020-07-31 19:26:09 +02:00
Simon Frei and GitHub
e46c8ab9ee
lib/model: Detect deleted RO items scanning on non-RO ( fixes #6864 ) ( #6865 )
2020-07-30 13:41:45 +02:00
Jakob Borg and GitHub
aedc2d788f
lib/model, lib/versioner: Drive version cleanup from scanner ( fixes #6313 ) ( #6693 )
...
This change adds a separate config for the cleanup interval, and runs that cleanup from the main folder loop.
2020-07-14 10:48:50 +02:00
Simon Frei and GitHub
0648fb0626
lib/model: Don't force rescan already changed items ( #6798 )
2020-06-25 20:23:59 +02:00
Simon Frei and GitHub
f66e57947b
lib/model: Use right db snap when scanning recvonly folder ( #6769 )
2020-06-21 09:28:29 +02:00
Simon Frei and GitHub
22f0077262
lib/model: Don't stay scanning forever on fail ( #6761 )
2020-06-18 14:13:46 +01:00
Simon Frei and GitHub
8cf9d91ed4
lib: Print nicely rounded durations ( #6756 )
2020-06-18 10:55:41 +02:00
Simon Frei and GitHub
a47546a1f1
lib/scanner, lib/model: Improve error handling when scanning ( #6736 )
2020-06-16 09:25:41 +02:00
1f8e6c55f6
lib/db: Refactor to use global list by version ( fixes #6372 ) ( #6638 )
...
Group the global list of files by version, instead of having one flat list for all devices. This removes lots of duplicate protocol.Vectors.
Co-authored-by: Jakob Borg <jakob@kastelo.net >
2020-05-30 09:50:23 +02:00
Simon Frei and GitHub
ed6bfc5417
lib/model: Don't increase pull pause on triggered pull ( #6690 )
2020-05-29 09:52:28 +02:00
Jakob Borg and GitHub
651ee2ce74
lib/model: Partial revert of rename fix ( fixes #6653 ) ( #6656 )
...
We can't just drop the snap because it's in use elsewhere. This should
be equally functional.
2020-05-16 23:05:33 +02:00
Audrius Butkevicius and GitHub
a1c5b44c74
lib/model: Fix rename handling (ref #6650 ) ( #6652 )
2020-05-16 14:39:27 +02:00