From f6c551fe879baae1e1a0060d86ae500024c773b8 Mon Sep 17 00:00:00 2001 From: Jakob Borg Date: Sat, 9 May 2026 12:48:53 +0200 Subject: [PATCH] chore(fs): remove unused SymlinksSupported() method (#10684) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 💀 Signed-off-by: Jakob Borg --- lib/fs/basicfs_unix.go | 4 --- lib/fs/basicfs_windows.go | 4 --- lib/fs/errorfs.go | 1 - lib/fs/fakefs.go | 4 --- lib/fs/filesystem.go | 1 - lib/fs/logfs.go | 6 ---- lib/fs/metrics.go | 66 ++++++++++++++++++--------------------- 7 files changed, 30 insertions(+), 56 deletions(-) diff --git a/lib/fs/basicfs_unix.go b/lib/fs/basicfs_unix.go index 1a54b2652..c60e67574 100644 --- a/lib/fs/basicfs_unix.go +++ b/lib/fs/basicfs_unix.go @@ -16,10 +16,6 @@ import ( "strings" ) -func (*BasicFilesystem) SymlinksSupported() bool { - return true -} - func (f *BasicFilesystem) CreateSymlink(target, name string) error { name, err := f.rooted(name) if err != nil { diff --git a/lib/fs/basicfs_windows.go b/lib/fs/basicfs_windows.go index 65a161397..d1b8d88c2 100644 --- a/lib/fs/basicfs_windows.go +++ b/lib/fs/basicfs_windows.go @@ -23,10 +23,6 @@ import ( var errNotSupported = errors.New("symlinks not supported") -func (BasicFilesystem) SymlinksSupported() bool { - return false -} - func (BasicFilesystem) ReadSymlink(path string) (string, error) { return "", errNotSupported } diff --git a/lib/fs/errorfs.go b/lib/fs/errorfs.go index 439efdffd..1314680c2 100644 --- a/lib/fs/errorfs.go +++ b/lib/fs/errorfs.go @@ -44,7 +44,6 @@ func (fs *errorFilesystem) Remove(_ string) error { retur func (fs *errorFilesystem) RemoveAll(_ string) error { return fs.err } func (fs *errorFilesystem) Rename(_, _ string) error { return fs.err } func (fs *errorFilesystem) Stat(_ string) (FileInfo, error) { return nil, fs.err } -func (*errorFilesystem) SymlinksSupported() bool { return false } func (fs *errorFilesystem) Walk(_ string, _ WalkFunc) error { return fs.err } func (fs *errorFilesystem) Unhide(_ string) error { return fs.err } func (fs *errorFilesystem) Hide(_ string) error { return fs.err } diff --git a/lib/fs/fakefs.go b/lib/fs/fakefs.go index bea6646f5..ef0ccd7c5 100644 --- a/lib/fs/fakefs.go +++ b/lib/fs/fakefs.go @@ -629,10 +629,6 @@ func (fs *fakeFS) Stat(name string) (FileInfo, error) { return fs.Lstat(name) } -func (*fakeFS) SymlinksSupported() bool { - return false -} - func (*fakeFS) Walk(_ string, _ WalkFunc) error { return errors.New("not implemented") } diff --git a/lib/fs/filesystem.go b/lib/fs/filesystem.go index 554497317..31bbb9770 100644 --- a/lib/fs/filesystem.go +++ b/lib/fs/filesystem.go @@ -45,7 +45,6 @@ type Filesystem interface { RemoveAll(name string) error Rename(oldname, newname string) error Stat(name string) (FileInfo, error) - SymlinksSupported() bool Walk(name string, walkFn WalkFunc) error // If setup fails, returns non-nil error, and if afterwards a fatal (!) // error occurs, sends that error on the channel. Afterwards this watch diff --git a/lib/fs/logfs.go b/lib/fs/logfs.go index 27e70ad80..1d9dcdf9d 100644 --- a/lib/fs/logfs.go +++ b/lib/fs/logfs.go @@ -127,12 +127,6 @@ func (fs *logFilesystem) Stat(name string) (FileInfo, error) { return info, err } -func (fs *logFilesystem) SymlinksSupported() bool { - supported := fs.Filesystem.SymlinksSupported() - l.Debugln(fs.getCaller(), fs.Type(), fs.URI(), "SymlinksSupported", supported) - return supported -} - func (fs *logFilesystem) Walk(root string, walkFn WalkFunc) error { err := fs.Filesystem.Walk(root, walkFn) l.Debugln(fs.getCaller(), fs.Type(), fs.URI(), "Walk", root, walkFn, err) diff --git a/lib/fs/metrics.go b/lib/fs/metrics.go index 5e25d6819..773eae2be 100644 --- a/lib/fs/metrics.go +++ b/lib/fs/metrics.go @@ -38,37 +38,36 @@ var ( const ( // fs operations - metricOpChmod = "chmod" - metricOpLchmod = "lchmod" - metricOpChtimes = "chtimes" - metricOpCreate = "create" - metricOpCreateSymlink = "createsymlink" - metricOpDirNames = "dirnames" - metricOpLstat = "lstat" - metricOpMkdir = "mdkir" - metricOpMkdirAll = "mkdirall" - metricOpOpen = "open" - metricOpOpenFile = "openfile" - metricOpReadSymlink = "readsymlink" - metricOpRemove = "remove" - metricOpRemoveAll = "removeall" - metricOpRename = "rename" - metricOpStat = "stat" - metricOpSymlinksSupported = "symlinkssupported" - metricOpWalk = "walk" - metricOpWatch = "watch" - metricOpHide = "hide" - metricOpUnhide = "unhide" - metricOpGlob = "glob" - metricOpRoots = "roots" - metricOpUsage = "usage" - metricOpType = "type" - metricOpURI = "uri" - metricOpOptions = "options" - metricOpSameFile = "samefile" - metricOpPlatformData = "platformdata" - metricOpGetXattr = "getxattr" - metricOpSetXattr = "setxattr" + metricOpChmod = "chmod" + metricOpLchmod = "lchmod" + metricOpChtimes = "chtimes" + metricOpCreate = "create" + metricOpCreateSymlink = "createsymlink" + metricOpDirNames = "dirnames" + metricOpLstat = "lstat" + metricOpMkdir = "mdkir" + metricOpMkdirAll = "mkdirall" + metricOpOpen = "open" + metricOpOpenFile = "openfile" + metricOpReadSymlink = "readsymlink" + metricOpRemove = "remove" + metricOpRemoveAll = "removeall" + metricOpRename = "rename" + metricOpStat = "stat" + metricOpWalk = "walk" + metricOpWatch = "watch" + metricOpHide = "hide" + metricOpUnhide = "unhide" + metricOpGlob = "glob" + metricOpRoots = "roots" + metricOpUsage = "usage" + metricOpType = "type" + metricOpURI = "uri" + metricOpOptions = "options" + metricOpSameFile = "samefile" + metricOpPlatformData = "platformdata" + metricOpGetXattr = "getxattr" + metricOpSetXattr = "setxattr" // file operations metricOpRead = "read" @@ -194,11 +193,6 @@ func (m *metricsFS) Stat(name string) (FileInfo, error) { return m.next.Stat(name) } -func (m *metricsFS) SymlinksSupported() bool { - defer m.account(metricOpSymlinksSupported)(-1) - return m.next.SymlinksSupported() -} - func (m *metricsFS) Walk(name string, walkFn WalkFunc) error { defer m.account(metricOpWalk)(-1) return m.next.Walk(name, walkFn)