lib/config: Decouple VerifyConfiguration from Committer (#7939)

... and remove 8/10 implementations, which were no-ops. This saves code
and time copying configurations.
This commit is contained in:
greatroar
2021-11-22 08:45:29 +01:00
committed by GitHub
parent e2288fe441
commit bf89bffb0b
11 changed files with 20 additions and 40 deletions
-4
View File
@@ -188,10 +188,6 @@ func (h *failureHandler) addReport(data FailureData, evTime time.Time) {
}
}
func (h *failureHandler) VerifyConfiguration(_, _ config.Configuration) error {
return nil
}
func (h *failureHandler) CommitConfiguration(from, to config.Configuration) bool {
if from.Options.CREnabled != to.Options.CREnabled || from.Options.CRURL != to.Options.CRURL {
h.optsChan <- to.Options
-4
View File
@@ -390,10 +390,6 @@ func (s *Service) Serve(ctx context.Context) error {
}
}
func (s *Service) VerifyConfiguration(from, to config.Configuration) error {
return nil
}
func (s *Service) CommitConfiguration(from, to config.Configuration) bool {
if from.Options.URAccepted != to.Options.URAccepted || from.Options.URUniqueID != to.Options.URUniqueID || from.Options.URURL != to.Options.URURL {
select {