From 8e3f1190d1639e4647145577c9a64367a0da21da Mon Sep 17 00:00:00 2001
From: "deepsource-autofix[bot]"
 <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date: Thu, 28 Jul 2022 20:00:07 +0200
Subject: [PATCH] lib/model: Use bytes.Equal instead of converting to string
 (#8469)

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
---
 lib/model/folder_sendrecv_test.go | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/model/folder_sendrecv_test.go b/lib/model/folder_sendrecv_test.go
index bf4043e85..03d36e2e5 100644
--- a/lib/model/folder_sendrecv_test.go
+++ b/lib/model/folder_sendrecv_test.go
@@ -145,7 +145,7 @@ func TestHandleFile(t *testing.T) {
 	for _, block := range blocks[1:] {
 		found := false
 		for _, toCopyBlock := range toCopy.blocks {
-			if string(toCopyBlock.Hash) == string(block.Hash) {
+			if bytes.Equal(toCopyBlock.Hash, block.Hash) {
 				found = true
 				break
 			}
@@ -192,7 +192,7 @@ func TestHandleFileWithTemp(t *testing.T) {
 		found := false
 		block := blocks[idx]
 		for _, toCopyBlock := range toCopy.blocks {
-			if string(toCopyBlock.Hash) == string(block.Hash) {
+			if bytes.Equal(toCopyBlock.Hash, block.Hash) {
 				found = true
 				break
 			}
@@ -277,7 +277,7 @@ func TestCopierFinder(t *testing.T) {
 				found := false
 				block := blocks[idx]
 				for _, pulledBlock := range pulls {
-					if string(pulledBlock.block.Hash) == string(block.Hash) {
+					if bytes.Equal(pulledBlock.block.Hash, block.Hash) {
 						found = true
 						break
 					}
@@ -285,7 +285,7 @@ func TestCopierFinder(t *testing.T) {
 				if !found {
 					t.Errorf("Did not find block %s", block.String())
 				}
-				if string(finish.file.Blocks[idx-1].Hash) != string(blocks[idx].Hash) {
+				if !bytes.Equal(finish.file.Blocks[idx-1].Hash, blocks[idx].Hash) {
 					t.Errorf("Block %d mismatch: %s != %s", idx, finish.file.Blocks[idx-1].String(), blocks[idx].String())
 				}
 			}
@@ -297,7 +297,7 @@ func TestCopierFinder(t *testing.T) {
 			}
 
 			for _, eq := range []int{2, 3, 4, 7} {
-				if string(blks[eq-1].Hash) != string(blocks[eq].Hash) {
+				if !bytes.Equal(blks[eq-1].Hash, blocks[eq].Hash) {
 					t.Errorf("Block %d mismatch: %s != %s", eq, blks[eq-1].String(), blocks[eq].String())
 				}
 			}