lib/stun: Inline util.OnDone, comment on its purpose (#7308)

Co-authored-by: greatroar <@>
2021-01-27 19:27:00 +01:00
parent e19d6e993d
commit 8b86171642
2 changed files with 6 additions and 9 deletions
@@ -111,7 +111,12 @@ func (s *Service) Serve(ctx context.Context) error {
 		s.setExternalAddress(nil, "")
 	}()

-	util.OnDone(ctx, func() { _ = s.stunConn.Close() })
+	// Closing s.stunConn unblocks operations that use the connection
+	// (Discover, Keepalive) and might otherwise block us from returning.
+	go func() {
+		<-ctx.Done()
+		_ = s.stunConn.Close()
+	}()

 	timer := time.NewTimer(time.Millisecond)