lib/osutil: Don't remove before rename on Windows (ref #6493) (#6495)

This was needed in ancient times but not currently.
This commit is contained in:
Jakob Borg
2020-04-04 14:17:16 +02:00
committed by GitHub
parent e1324a0e23
commit 7505ea79a0
2 changed files with 10 additions and 12 deletions
+10 -1
View File
@@ -52,6 +52,15 @@ func TestCreateAtomicCreate(t *testing.T) {
}
func TestCreateAtomicReplace(t *testing.T) {
testCreateAtomicReplace(t, 0644)
}
func TestCreateAtomicReplaceReadOnly(t *testing.T) {
testCreateAtomicReplace(t, 0400)
}
func testCreateAtomicReplace(t *testing.T, oldPerms os.FileMode) {
t.Helper()
os.RemoveAll("testdata")
defer os.RemoveAll("testdata")
@@ -59,7 +68,7 @@ func TestCreateAtomicReplace(t *testing.T) {
t.Fatal(err)
}
if err := ioutil.WriteFile("testdata/file", []byte("some old data"), 0644); err != nil {
if err := ioutil.WriteFile("testdata/file", []byte("some old data"), oldPerms); err != nil {
t.Fatal(err)
}