Revert "Proper signal handling in monitor process"

This reverts commit 33e9a88b56.
This commit is contained in:
Jakob Borg
2014-09-06 06:49:51 +02:00
parent 97cb3fa5a5
commit 5b51f4d058
4 changed files with 12 additions and 39 deletions
+1 -1
View File
@@ -2,7 +2,7 @@
set -euo pipefail
IFS=$'\n\t'
#go test -tags integration -v
./test-http.sh
./test-merge.sh
./test-delupd.sh
go test -tags integration -v
+1 -6
View File
@@ -19,7 +19,6 @@ import (
"os"
"os/exec"
"path/filepath"
"runtime"
"time"
)
@@ -55,11 +54,7 @@ func (p *syncthingProcess) start() error {
}
func (p *syncthingProcess) stop() {
if runtime.GOOS != "windows" {
p.cmd.Process.Signal(os.Interrupt)
} else {
p.cmd.Process.Kill()
}
p.cmd.Process.Kill()
p.cmd.Wait()
}
+7 -10
View File
@@ -24,6 +24,13 @@ var env = []string{
"STTRACE=model",
}
func TestRestartBothDuringTransfer(t *testing.T) {
// Give the receiver some time to rot with needed files but
// without any peer. This triggers
// https://github.com/syncthing/syncthing/issues/463
testRestartDuringTransfer(t, true, true, 10*time.Second, 0)
}
func TestRestartReceiverDuringTransfer(t *testing.T) {
testRestartDuringTransfer(t, false, true, 0, 0)
}
@@ -32,13 +39,6 @@ func TestRestartSenderDuringTransfer(t *testing.T) {
testRestartDuringTransfer(t, true, false, 0, 0)
}
func TestRestartSenderAndReceiverDuringTransfer(t *testing.T) {
// // Give the receiver some time to rot with needed files but
// // without any peer. This triggers
// // https://github.com/syncthing/syncthing/issues/463
testRestartDuringTransfer(t, true, true, 10*time.Second, 0)
}
func testRestartDuringTransfer(t *testing.T, restartSender, restartReceiver bool, senderDelay, receiverDelay time.Duration) {
log.Println("Cleaning...")
err := removeAll("s1", "s2", "f1/index", "f2/index")
@@ -134,9 +134,6 @@ func testRestartDuringTransfer(t *testing.T, restartSender, restartReceiver bool
time.Sleep(1 * time.Second)
}
sender.stop()
receiver.stop()
log.Println("Comparing directories...")
err = compareDirectories("s1", "s2")
if err != nil {