lib/protocol: Avoid panic in DeviceIDFromBytes (#6714)

2020-06-07 10:31:12 +02:00
parent 607bcc0b0e
commit 46536509d7
9 changed files with 69 additions and 21 deletions
@@ -46,13 +46,13 @@ func DeviceIDFromString(s string) (DeviceID, error) {
 	return n, err
 }

-func DeviceIDFromBytes(bs []byte) DeviceID {
+func DeviceIDFromBytes(bs []byte) (DeviceID, error) {
 	var n DeviceID
 	if len(bs) != len(n) {
-		panic("incorrect length of byte slice representing device ID")
+		return n, fmt.Errorf("incorrect length of byte slice representing device ID")
 	}
 	copy(n[:], bs)
-	return n
+	return n, nil
 }

 // String returns the canonical string representation of the device ID