all: Combine sequential appends (#8461)

cmd/ursrv/main.go

@@ -785,72 +785,53 @@ func getReport(db *sql.DB) map[string]interface{} {
 		}
 	}
 
-	var categories []category
+	categories := []category{
-	categories = append(categories, category{
+		{
 			Values: statsForInts(totFiles),
 			Descr:  "Files Managed per Device",
-	})
+		}, {
-
-	categories = append(categories, category{
 			Values: statsForInts(maxFiles),
 			Descr:  "Files in Largest Folder",
-	})
+		}, {
-
-	categories = append(categories, category{
 			Values: statsForInt64s(totMiB),
 			Descr:  "Data Managed per Device",
 			Unit:   "B",
 			Type:   NumberBinary,
-	})
+		}, {
-
-	categories = append(categories, category{
 			Values: statsForInt64s(maxMiB),
 			Descr:  "Data in Largest Folder",
 			Unit:   "B",
 			Type:   NumberBinary,
-	})
+		}, {
-
-	categories = append(categories, category{
 			Values: statsForInts(numDevices),
 			Descr:  "Number of Devices in Cluster",
-	})
+		}, {
-
-	categories = append(categories, category{
 			Values: statsForInts(numFolders),
 			Descr:  "Number of Folders Configured",
-	})
+		}, {
-
-	categories = append(categories, category{
 			Values: statsForInt64s(memoryUsage),
 			Descr:  "Memory Usage",
 			Unit:   "B",
 			Type:   NumberBinary,
-	})
+		}, {
-
-	categories = append(categories, category{
 			Values: statsForInt64s(memorySize),
 			Descr:  "System Memory",
 			Unit:   "B",
 			Type:   NumberBinary,
-	})
+		}, {
-
-	categories = append(categories, category{
 			Values: statsForFloats(sha256Perf),
 			Descr:  "SHA-256 Hashing Performance",
 			Unit:   "B/s",
 			Type:   NumberBinary,
-	})
+		}, {
-
-	categories = append(categories, category{
 			Values: statsForInts(numCPU),
 			Descr:  "Number of CPU cores",
-	})
+		}, {
-
-	categories = append(categories, category{
 			Values: statsForInts(uptime),
 			Descr:  "Uptime (v3)",
 			Type:   NumberDuration,
-	})
+		},
+	}
 
 	reportFeatures := make(map[string][]feature)
 	for featureType, versions := range features {

lib/model/sentdownloadstate.go

@@ -80,12 +80,13 @@ func (s *sentFolderDownloadState) update(pullers []*sharedPullerState) []protoco
 		if !pullerVersion.Equal(localFile.version) || !pullerCreated.Equal(localFile.created) {
 			// The version has changed or the puller was reconstrcuted due to failure.
 			// Clean up whatever we had for the old file, and advertise the new file.
-			updates = append(updates, protocol.FileDownloadProgressUpdate{
+			updates = append(updates,
+				protocol.FileDownloadProgressUpdate{
 					Name:       name,
 					Version:    localFile.version,
 					UpdateType: protocol.FileDownloadProgressUpdateTypeForget,
-			})
+				},
-			updates = append(updates, protocol.FileDownloadProgressUpdate{
+				protocol.FileDownloadProgressUpdate{
 					Name:         name,
 					Version:      pullerVersion,
 					UpdateType:   protocol.FileDownloadProgressUpdateTypeAppend,