felixfoertsch/syncthing
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 10 Wiki Activity

fix(fs): check for unsupported error on modern Windows (fixes #10164) (#10165)

Browse Source 
### Purpose

Locally, on Windows 11, and on the windows-2025 GitHub runner (go 1.23
and 1.24), the `TestCopyRange` test is failing with `The request is not
supported.`

On windows-2022 and windows-2019:
```go
err == syscall.ENOTSUP
```
worked, but on Windows 11 and windows-2025, we need:
```go
errors.Is(err, errors.ErrUnsupported)
```

### Testing

Tested on Windows 11, windows-2019, windows-2022, and
[windows-2025](https://github.com/rasa/syncthing/actions/runs/15525123437/job/43703630634#step:7:2811).
This commit is contained in:
Ross Smith II
2025-06-09 07:20:46 +02:00
committed by GitHub
parent 0211251b34
commit 064213ceb8
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/fs/filesystem_copy_range_test.go
+2 -1
View File
@@ -8,6 +8,7 @@ package fs
import ( import (
"bytes" "bytes"
"errors"
"io" "io"
"math/rand" "math/rand"
"os" "os"
@@ -329,7 +330,7 @@ func TestCopyRange(tttt *testing.T) {
t.Fatal("dst file is not a basic file") t.Fatal("dst file is not a basic file")
} }
if err := impl(srcBasic, dstBasic, testCase.srcOffset, testCase.dstOffset, testCase.copySize); err != nil { if err := impl(srcBasic, dstBasic, testCase.srcOffset, testCase.dstOffset, testCase.copySize); err != nil {
if err == syscall.ENOTSUP { if errors.Is(err, errors.ErrUnsupported) {
// Test runner can adjust directory in which to run the tests, that allow broader tests. // Test runner can adjust directory in which to run the tests, that allow broader tests.
t.Skip("Not supported on the current filesystem, set STFSTESTPATH env var.") t.Skip("Not supported on the current filesystem, set STFSTESTPATH env var.")
} }