cmd/strelaypoolsrv, lib/api: Factor out static asset serving (#6624)

2020-05-10 11:44:34 +02:00
parent da99203dcd
commit 06365e5635
7 changed files with 219 additions and 133 deletions
@@ -0,0 +1,103 @@
+// Copyright (C) 2020 The Syncthing Authors.
+//
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this file,
+// You can obtain one at https://mozilla.org/MPL/2.0/.
+
+package assets
+
+import (
+	"bytes"
+	"compress/gzip"
+	"io"
+	"io/ioutil"
+	"net/http"
+	"net/http/httptest"
+	"strings"
+	"testing"
+	"time"
+)
+
+func compress(s string) string {
+	var sb strings.Builder
+	gz := gzip.NewWriter(&sb)
+
+	io.WriteString(gz, s)
+	gz.Close()
+	return sb.String()
+}
+
+func decompress(p []byte) (out []byte) {
+	r, err := gzip.NewReader(bytes.NewBuffer(p))
+	if err == nil {
+		out, err = ioutil.ReadAll(r)
+	}
+	if err != nil {
+		panic(err)
+	}
+	return out
+}
+
+func TestServe(t *testing.T) {
+	indexHTML := `<html>Hello, world!</html>`
+	indexGz := compress(indexHTML)
+
+	handler := func(w http.ResponseWriter, r *http.Request) {
+		Serve(w, r, Asset{
+			ContentGz: indexGz,
+			Filename:  r.URL.Path[1:],
+			Modified:  time.Unix(0, 0),
+		})
+	}
+
+	for _, acceptGzip := range []bool{true, false} {
+		r := httptest.NewRequest("GET", "http://localhost/index.html", nil)
+		if acceptGzip {
+			r.Header.Set("accept-encoding", "gzip, deflate")
+		}
+
+		w := httptest.NewRecorder()
+		handler(w, r)
+		res := w.Result()
+
+		if res.StatusCode != http.StatusOK {
+			t.Fatalf("wanted OK, got status %d", res.StatusCode)
+		}
+		if ctype := res.Header.Get("Content-Type"); ctype != "text/html; charset=utf-8" {
+			t.Errorf("unexpected Content-Type %q", ctype)
+		}
+		// ETags must be quoted ASCII strings:
+		// https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag
+		if etag := res.Header.Get("ETag"); etag != `"0"` {
+			t.Errorf("unexpected ETag %q", etag)
+		}
+
+		body, _ := ioutil.ReadAll(res.Body)
+		if acceptGzip {
+			body = decompress(body)
+		}
+		if string(body) != indexHTML {
+			t.Fatalf("unexpected content %q", body)
+		}
+	}
+
+	r := httptest.NewRequest("GET", "http://localhost/index.html", nil)
+	r.Header.Set("if-none-match", `"0"`)
+	w := httptest.NewRecorder()
+	handler(w, r)
+	res := w.Result()
+
+	if res.StatusCode != http.StatusNotModified {
+		t.Fatalf("wanted NotModified, got status %d", res.StatusCode)
+	}
+
+	r = httptest.NewRequest("GET", "http://localhost/index.html", nil)
+	r.Header.Set("if-modified-since", time.Now().Format(http.TimeFormat))
+	w = httptest.NewRecorder()
+	handler(w, r)
+	res = w.Result()
+
+	if res.StatusCode != http.StatusNotModified {
+		t.Fatalf("wanted NotModified, got status %d", res.StatusCode)
+	}
+}