From 96c15ef42ab2ba58d10e5bbf5fc84bb7c6524d5a Mon Sep 17 00:00:00 2001 From: Dianne Skoll Date: Tue, 7 Oct 2025 14:00:11 -0400 Subject: [PATCH] Update docs; close stdin when we go to queuing mode. --- docs/WHATSNEW | 20 ++++++++++++++++++++ src/queue.c | 4 +++- 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/docs/WHATSNEW b/docs/WHATSNEW index f41cc03c..323c3d29 100644 --- a/docs/WHATSNEW +++ b/docs/WHATSNEW @@ -1,5 +1,25 @@ CHANGES TO REMIND +* VERSION 6.1 Patch 4 - 2025-10-?? + +- BUG FIX: remind: In calendar mode, reminders that specify a TZ zone + that is *behind* the system time zone could sometimes not show up. + The bug has been fixed; thanks to Jin Chen for reporting it. + +- BUG FIX: remind: Don't set up an inotify file descriptor if we are + not running in Daemon Mode. + +- IMPROVEMENT: lang/*.rem: Suppress redefined function warnings if you + include one language file and then later on a different one. + +- CHANGE: include/holidays/*.rem: Add %"..%" markers and %(is) %b + suffixes to all reminders. This prevents you from having to use the + msgsuffix() hack if you want advance warning of holidays. See + include/holidays/README for details. + + If you *are* using the msgsuffix() hack, you should stop using it! + Just set $DefaultDelta. + * VERSION 6.1 Patch 3 - 2025-09-30 - IMPROVEMENT: remind: Issue a warning that SCANFROM should be used diff --git a/src/queue.c b/src/queue.c index c5df3346..7ac8b390 100644 --- a/src/queue.c +++ b/src/queue.c @@ -190,7 +190,7 @@ maybe_close(int fd) { int new_fd; /* Don't close descriptors connected to a TTY, except for stdin */ - if (fd && isatty(fd)) return; + if (fd != STDIN_FILENO && isatty(fd)) return; (void) close(fd); if (fd != STDIN_FILENO) { @@ -280,6 +280,8 @@ void HandleQueuedReminders(void) maybe_close(STDIN_FILENO); maybe_close(STDOUT_FILENO); maybe_close(STDERR_FILENO); + } else if (!Daemon) { + maybe_close(STDIN_FILENO); } /* If we're a daemon, get the mod time of initial file */