From a653b75b2481e4d740eb380efc5076c72633efd2 Mon Sep 17 00:00:00 2001 From: Romain Vigier Date: Wed, 23 Feb 2022 22:58:25 +0100 Subject: [PATCH] Fix time source combo row sensitivity being reset after change --- src/preferences/SchedulePage.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/preferences/SchedulePage.js b/src/preferences/SchedulePage.js index 5699fc0..a0fb803 100644 --- a/src/preferences/SchedulePage.js +++ b/src/preferences/SchedulePage.js @@ -62,13 +62,13 @@ var SchedulePage = GObject.registerClass({ filter: choiceFilter, }); this._time_source_combo_row.expression = Gtk.PropertyExpression.new(DropDownChoice, null, 'title'); - this._time_source_combo_row.sensitive = settings.get_boolean('manual-time-source'); this._time_source_combo_row.connect('notify::selected-item', () => settings.set_string('time-source', this._time_source_combo_row.selected_item.id)); - const updateTimeSourceComboRowSelected = () => { + const updateTimeSourceComboRowState = () => { this._time_source_combo_row.selected = utils.findItemPositionInModel(this._time_source_combo_row.model, item => item.id === settings.get_string('time-source')); + this._time_source_combo_row.sensitive = settings.get_boolean('manual-time-source'); }; - settings.connect('changed::time-source', () => updateTimeSourceComboRowSelected()); - updateTimeSourceComboRowSelected(); + settings.connect('changed::time-source', () => updateTimeSourceComboRowState()); + updateTimeSourceComboRowState(); settings.bind('always-enable-ondemand', this._always_show_ondemand_switch, 'active', Gio.SettingsBindFlags.DEFAULT);