Johannes Marbach
f1a6ab4278
Fix memory leak in [RecentsDataSource dataSource:didStateChange:]
...
The block passed into `[MXSession listenToEventsOfTypes:onEvent:]` is stored with a strong
reference in the `listenerBlock` property of `MXSessionEventListener`. The method also
returns the listener and it is then stored into the `roomTagsListenerByUserId` dictionary
on `self`. Since a strong reference to `self` is captured in the block that means the block
retains `self` (via the capture) and `self` retains the block (via `roomTagsListenerByUserId`)
so there is a memory leak.
The bug is most easily reproduced during testing #4168 which involves closing the current
and creating a new session.
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org >
2021-04-08 20:54:03 +02:00
Gil Eluard
21d6dfcacd
Merge pull request #4147 from vector-im/element_4134
...
Explore typing notifications inspired by web
2021-04-08 16:25:51 +02:00
Gil Eluard
ccda218ddf
Update Riot/Modules/Room/Views/BubbleCells/RoomTypingBubbleCell.swift
...
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com >
2021-04-08 16:13:56 +02:00
Gil Eluard
825088553a
Update after review
2021-04-08 15:59:53 +02:00
Gil Eluard
b68a9b06c3
Update after review
2021-04-08 15:19:02 +02:00
Gil Eluard
6e27ae3c98
Update Riot/Modules/DotsView/DotsView.swift
...
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com >
2021-04-08 13:48:49 +02:00
Gil Eluard
3c7bc3f1f7
Update Riot/Modules/Room/Views/BubbleCells/RoomTypingBubbleCell.swift
...
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com >
2021-04-08 13:48:25 +02:00
Gil Eluard
7c572a96a9
Update after review
2021-04-08 12:11:36 +02:00
Gil Eluard
e56b01e1a7
Update Riot/Modules/Room/Views/InputToolbar/RoomActionItem.swift
...
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com >
2021-04-08 10:52:51 +02:00
Gil Eluard
0a70b0f595
Update Riot/Modules/Room/Views/InputToolbar/RoomActionsBar.swift
...
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com >
2021-04-08 10:52:39 +02:00
Gil Eluard
77a462f207
Update Riot/Modules/Room/Views/InputToolbar/RoomActionsBar.swift
...
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com >
2021-04-08 10:48:15 +02:00
Gil Eluard
8baef2633d
Update Riot/Modules/Room/Views/InputToolbar/RoomActionsBar.swift
...
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com >
2021-04-08 10:47:57 +02:00
Gil Eluard
a84b5311b7
Update Riot/Modules/Room/Views/InputToolbar/RoomActionsBar.swift
...
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com >
2021-04-08 10:47:42 +02:00
Gil Eluard
66f33ec42f
Update Riot/Modules/Room/Views/InputToolbar/RoomActionItem.swift
...
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com >
2021-04-08 10:47:28 +02:00
Gil Eluard
ee0a0a58ac
Merge branch 'element_4087' into element_4134
2021-04-08 07:56:53 +02:00
Gil Eluard
60cabff3e9
back button chevron looks really weird
2021-04-08 07:56:38 +02:00
ismailgulek
0f0b5ade04
Merge branch 'develop' into voip_design_updates
2021-04-08 00:18:23 +03:00
Gil Eluard
011539338b
Merge branch 'element_4087' into element_4134
...
# Conflicts:
# CHANGES.rst
2021-04-07 21:02:24 +02:00
Gil Eluard
f18e615db0
Increase grow/shrink animation speed in new composer
2021-04-07 21:01:07 +02:00
Gil Eluard
ff36b5bc26
Black theme uses dark background for composer
2021-04-07 20:15:09 +02:00
ismailgulek
9ccfbbf5a8
Remove unused code
2021-04-07 15:49:01 +03:00
ismailgulek
28e046e205
Fix label text color on dark mode
2021-04-07 15:24:42 +03:00
ismailgulek
e42e5ae64d
Fix status bar style generally
2021-04-07 15:21:19 +03:00
Gil Eluard
09fc64e9c7
Merge branch 'element_4087' into element_4134
2021-04-07 14:11:42 +02:00
Gil Eluard
5e6ab4a61b
too much vertical whitespace when replying
2021-04-07 14:11:27 +02:00
Gil Eluard
d7f5ad2e06
Merge branch 'element_4087' into element_4134
2021-04-07 13:15:44 +02:00
Gil Eluard
5c9b2a6a0b
Merge branch 'develop' into element_4087
2021-04-07 13:15:26 +02:00
ismailgulek
881c811536
Continue with no auth if well known is not provided, fixes #4040
2021-04-07 14:14:04 +03:00
Gil Eluard
b9f866f893
Merge branch 'element_4087' into element_4134
2021-04-07 13:11:28 +02:00
Gil Eluard
370db5372d
too much vertical whitespace when replying
2021-04-07 13:11:07 +02:00
Gil Eluard
a09550a1ee
Crash in [RoomViewController refreshTypingNotification]
2021-04-07 12:26:51 +02:00
Gil Eluard
91f206027e
Merge branch 'element_4087' into element_4134
2021-04-07 11:15:22 +02:00
Gil Eluard
890157dcc8
Crash in [RoomViewController setupActions]
2021-04-07 11:14:08 +02:00
Gil Eluard
f239790362
Switching composer between text mode & action mode
...
- Tweaked animation speed
2021-04-07 10:28:35 +02:00
Gil Eluard
49eafdd7c1
Merge branch 'element_4087' into element_4134
2021-04-07 09:33:10 +02:00
Gil Eluard
62cb90ffd7
Switching composer between text mode & action mode
...
- Tweaked animation speed
2021-04-07 09:32:57 +02:00
ismailgulek
dc0a15de6c
Remove lab setting for Jitsi calls
2021-04-06 17:25:37 +03:00
Gil Eluard
098c083b1e
Merge branch 'develop' into element_4181
...
# Conflicts:
# CHANGES.rst
# Riot/Managers/Settings/RiotSettings.swift
2021-04-06 15:59:40 +02:00
Gil Eluard
18e2666b84
Consider displaying names in typing notifications
2021-04-06 14:32:25 +02:00
Gil Eluard
bfd605dff7
Limit typing notifications timeline jumps
2021-04-06 13:09:30 +02:00
Gil Eluard
de019ff560
Possibility to lock some room creation parameters from settings
...
- Update after review
2021-04-06 10:51:07 +02:00
Gil Eluard
3e03a7bf2a
Possibility to lock some room creation parameters from settings
...
- Update after review
2021-04-06 10:47:54 +02:00
Gil Eluard
6886d3cb5f
Merge branch 'element_4087' into element_4134
2021-04-03 00:04:30 +02:00
Gil Eluard
8a0674404e
Switching composer between text mode & action mode
...
- Tweaked animation speed
2021-04-03 00:03:57 +02:00
ismailgulek
c1ecb9c016
Remove Jitsi widget info from activities view
2021-04-02 17:29:26 +03:00
Gil Eluard
9eff526a8b
Possibility to lock some room creation parameters from settings
2021-04-02 15:54:21 +02:00
ismailgulek
7d60f0955e
Hide voice call option for non-direct rooms & disable call buttons when active call exists
2021-04-02 16:12:21 +03:00
ismailgulek
fb3c76ab0f
Merge branch 'develop' into voip_design_updates
2021-04-02 14:39:37 +03:00
ismailgulek
0eecb59a26
Unify call screen methods, use UIViewController
2021-04-02 14:22:03 +03:00
Gil Eluard
1b9b05f2f4
Merge branch 'develop' into element_4173
2021-04-02 11:44:15 +02:00