Rename OnboardingConstants to OnboardingMetrics. Fix strings warning about public property in public extension. Remove unused OnboardingCelebrationViewModelResult.
Fix tests by moving constants out of Coordinator (as it is only part of the Riot target).