felixfoertsch/bundesmessenger-ios
1
0
Fork 0
mirror of https://gitlab.opencode.de/bwi/bundesmessenger/clients/bundesmessenger-ios.git synced 2026-05-02 14:16:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add sunset banners guiding users to install Element X when registering against a server with MAS. (#7890)

Browse Source
This commit is contained in:
Doug
2025-01-10 13:22:03 +00:00
committed by GitHub
parent 7da4b1c139
commit ee2073a8e3
33 changed files with 498 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files
RiotSwiftUI/Modules/Authentication/Registration/Test/Unit/AuthenticationRegistrationViewModelTests.swift
+25 -3
View File
@@ -13,11 +13,10 @@ import XCTest
@MainActor class AuthenticationRegistrationViewModelTests: XCTestCase {
let defaultHomeserver = AuthenticationHomeserverViewData.mockMatrixDotOrg
var viewModel: AuthenticationRegistrationViewModelProtocol!
var context: AuthenticationRegistrationViewModelType.Context!
var context: AuthenticationRegistrationViewModelType.Context { viewModel.context }
@MainActor override func setUp() async throws {
viewModel = AuthenticationRegistrationViewModel(homeserver: defaultHomeserver)
context = viewModel.context
viewModel = AuthenticationRegistrationViewModel(homeserver: defaultHomeserver, showReplacementAppBanner: false)
}
func testMatrixDotOrg() {
@@ -27,6 +26,7 @@ import XCTest
// Then the view state should contain a homeserver that matches matrix.org and shows SSO buttons.
XCTAssertEqual(context.viewState.homeserver, homeserver, "The homeserver data should match the original.")
XCTAssertTrue(context.viewState.showSSOButtons, "The SSO buttons should be shown.")
XCTAssertFalse(context.viewState.showReplacementAppBanner, "The sunset banner should not be shown.")
}
func testBasicServer() {
@@ -262,6 +262,28 @@ import XCTest
// Then the view state should reflect that the homeserver is loading.
XCTAssertEqual(context.username, localPart, "The username should match the value passed to the update method.")
}
func testSunsetBanner() async {
// Given a view model configured with a default homeserver that requires MAS (and the sunset banner).
let homeserver = AuthenticationHomeserverViewData(address: "beta.matrix.org",
showLoginForm: false,
showRegistrationForm: false,
showQRLogin: false,
ssoIdentityProviders: []) // The initial discovery would have failed so the OIDC provider is not known.
viewModel = AuthenticationRegistrationViewModel(homeserver: homeserver, showReplacementAppBanner: true)
XCTAssertEqual(context.viewState.homeserver, homeserver, "The homeserver data should match the original.")
XCTAssertTrue(context.viewState.showReplacementAppBanner, "The sunset banner should be shown.")
XCTAssertFalse(context.viewState.showSSOButtons, "The SSO buttons should not be shown.")
// When selecting another server that doesn't require MAS.
let legacyHomeserver = AuthenticationHomeserverViewData.mockMatrixDotOrg
viewModel.update(homeserver: legacyHomeserver)
// Then the banner should be removed and registration should be possible.
XCTAssertEqual(context.viewState.homeserver, legacyHomeserver, "The homeserver data should match the updated server.")
XCTAssertFalse(context.viewState.showReplacementAppBanner, "The sunset banner should no longer be visible.")
XCTAssertTrue(context.viewState.showSSOButtons, "The SSO buttons should now be visible.")
}
}
extension AuthenticationRegistrationViewState.UsernameAvailability: Equatable {