felixfoertsch/bundesmessenger-ios
1
0
Fork 0
mirror of https://gitlab.opencode.de/bwi/bundesmessenger/clients/bundesmessenger-ios.git synced 2026-04-27 19:56:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

Cleaned up various things, mostly removed unnecessary selfs, comments and bad formatting

Browse Source
This commit is contained in:
Stefan Ceriu
2022-09-26 18:21:34 +03:00
committed by Stefan Ceriu
parent c073dfd95d
commit eac1401cc1
39 changed files with 141 additions and 350 deletions
Download Patch File Download Diff File Expand all files Collapse all files
RiotSwiftUI/Modules/UserSessions/UserSessionDetails/Coordinator/UserSessionDetailsCoordinator.swift
+5 -7
View File
@@ -22,11 +22,6 @@ struct UserSessionDetailsCoordinatorParameters {
}
final class UserSessionDetailsCoordinator: Coordinator, Presentable {
// MARK: - Properties
// MARK: Private
private let parameters: UserSessionDetailsCoordinatorParameters
private let userSessionDetailsHostingController: UIViewController
private var userSessionDetailsViewModel: UserSessionDetailsViewModelProtocol
@@ -58,13 +53,16 @@ final class UserSessionDetailsCoordinator: Coordinator, Presentable {
func start() {
MXLog.debug("[UserSessionDetailsCoordinator] did start.")
userSessionDetailsViewModel.completion = { [weak self] result in
guard let self = self else { return }
guard let self = self else {
return
}
MXLog.debug("[UserSessionDetailsCoordinator] UserSessionDetailsViewModel did complete with result: \(result).")
self.completion?(result)
}
}
func toPresentable() -> UIViewController {
return self.userSessionDetailsHostingController
return userSessionDetailsHostingController
}
}
RiotSwiftUI/Modules/UserSessions/UserSessionDetails/Test/UI/UserSessionDetailsUITests.swift
-1
View File
@@ -18,7 +18,6 @@ import XCTest
import RiotSwiftUI
class UserSessionDetailsUITests: MockScreenTestCase {
func test_longPressDetailsCell_CopiesValueToClipboard() throws {
app.goToScreenWithIdentifier(MockUserSessionDetailsScreenState.allSections.title)
RiotSwiftUI/Modules/UserSessions/UserSessionDetails/Test/Unit/UserSessionDetailsViewModelTests.swift
-1
View File
@@ -19,7 +19,6 @@ import XCTest
@testable import RiotSwiftUI
class UserSessionDetailsViewModelTests: XCTestCase {
func test_whenSessionNameAndLastSeenIPNil_viewStateCorrect() {
let userSessionInfo = createUserSessionInfo(sessionId: "session",
sessionName: nil,
RiotSwiftUI/Modules/UserSessions/UserSessionDetails/UserSessionDetailsModels.swift
-3
View File
@@ -29,7 +29,6 @@ enum UserSessionDetailsViewAction {
}
struct UserSessionDetailsViewState: BindableState, Equatable {
let sections: [UserSessionDetailsSectionViewData]
}
@@ -47,7 +46,6 @@ struct UserSessionDetailsSectionItemViewData: Identifiable {
}
extension UserSessionDetailsSectionViewData: Equatable {
static func == (lhs: UserSessionDetailsSectionViewData, rhs: UserSessionDetailsSectionViewData) -> Bool {
lhs.header == rhs.header &&
lhs.footer == rhs.footer &&
@@ -56,7 +54,6 @@ extension UserSessionDetailsSectionViewData: Equatable {
}
extension UserSessionDetailsSectionItemViewData: Equatable {
static func == (lhs: UserSessionDetailsSectionItemViewData, rhs: UserSessionDetailsSectionItemViewData) -> Bool {
lhs.title == rhs.title &&
lhs.value == rhs.value
RiotSwiftUI/Modules/UserSessions/UserSessionDetails/UserSessionDetailsViewModel.swift
-9
View File
@@ -21,17 +21,8 @@ typealias UserSessionDetailsViewModelType = StateStoreViewModel<UserSessionDetai
UserSessionDetailsViewAction>
class UserSessionDetailsViewModel: UserSessionDetailsViewModelType, UserSessionDetailsViewModelProtocol {
// MARK: - Properties
// MARK: Private
// MARK: Public
var completion: ((UserSessionDetailsViewModelResult) -> Void)?
// MARK: - Setup
init(userSessionInfo: UserSessionInfo) {
super.init(initialViewState: UserSessionDetailsViewState(sections: []))
updateViewState(userSessionInfo: userSessionInfo)
RiotSwiftUI/Modules/UserSessions/UserSessionDetails/UserSessionDetailsViewModelProtocol.swift
-1
View File
@@ -17,7 +17,6 @@
import Foundation
protocol UserSessionDetailsViewModelProtocol {
var completion: ((UserSessionDetailsViewModelResult) -> Void)? { get set }
var context: UserSessionDetailsViewModelType.Context { get }
}
RiotSwiftUI/Modules/UserSessions/UserSessionDetails/View/UserSessionDetails.swift
-7
View File
@@ -17,11 +17,6 @@
import SwiftUI
struct UserSessionDetails: View {
// MARK: - Properties
// MARK: Private
private enum LayoutConstants {
static let listItemHorizontalPadding: CGFloat = 20
static let sectionVerticalPadding: CGFloat = 8
@@ -29,8 +24,6 @@ struct UserSessionDetails: View {
@Environment(\.theme) private var theme: ThemeSwiftUI
// MARK: Public
@ObservedObject var viewModel: UserSessionDetailsViewModel.Context
var body: some View {
RiotSwiftUI/Modules/UserSessions/UserSessionDetails/View/UserSessionDetailsItem.swift
-7
View File
@@ -17,15 +17,8 @@
import SwiftUI
struct UserSessionDetailsItem: View {
// MARK: - Properties
// MARK: Private
@Environment(\.theme) private var theme: ThemeSwiftUI
// MARK: Public
let viewData: UserSessionDetailsSectionItemViewData
let horizontalPadding: CGFloat