Fixes #4881 - Using the bundle display name as the app name in localizable .strings files. Exposing generated .strings and info.plist members to Objective-C.

This commit is contained in:
Stefan Ceriu
2021-09-22 14:10:16 +03:00
parent eba9b1c65c
commit cc8b6a8d75
32 changed files with 1696 additions and 1663 deletions
@@ -70,10 +70,10 @@ class VersionCheckCoordinator: Coordinator, VersionCheckBannerViewDelegate, Vers
if Constants.hasOSVersionBeenDropped {
versionCheckBannerView.configureWithDetails(VersionCheckBannerViewDetails(title: VectorL10n.versionCheckBannerTitleDeprecated(String(Constants.osVersionToBeDropped)),
subtitle: VectorL10n.versionCheckBannerSubtitleDeprecated(String(Constants.osVersionToBeDropped))))
subtitle: VectorL10n.versionCheckBannerSubtitleDeprecated(InfoPlist.cfBundleDisplayName, String(Constants.osVersionToBeDropped), InfoPlist.cfBundleDisplayName)))
} else {
versionCheckBannerView.configureWithDetails(VersionCheckBannerViewDetails(title: VectorL10n.versionCheckBannerTitleSupported(String(Constants.osVersionToBeDropped)),
subtitle: VectorL10n.versionCheckBannerSubtitleSupported(String(Constants.osVersionToBeDropped))))
subtitle: VectorL10n.versionCheckBannerSubtitleSupported(InfoPlist.cfBundleDisplayName, String(Constants.osVersionToBeDropped), InfoPlist.cfBundleDisplayName)))
}
bannerPresenter.presentBannerView(versionCheckBannerView, animated: true)
@@ -93,11 +93,11 @@ class VersionCheckCoordinator: Coordinator, VersionCheckBannerViewDelegate, Vers
if Constants.hasOSVersionBeenDropped {
versionCheckAlertViewController.configureWithDetails(VersionCheckAlertViewControllerDetails(title: VectorL10n.versionCheckModalTitleDeprecated(String(Constants.osVersionToBeDropped)),
subtitle: VectorL10n.versionCheckModalSubtitleDeprecated,
subtitle: VectorL10n.versionCheckModalSubtitleDeprecated(InfoPlist.cfBundleDisplayName, InfoPlist.cfBundleDisplayName),
actionButtonTitle: VectorL10n.versionCheckModalActionTitleDeprecated))
} else {
versionCheckAlertViewController.configureWithDetails(VersionCheckAlertViewControllerDetails(title: VectorL10n.versionCheckModalTitleSupported(String(Constants.osVersionToBeDropped)),
subtitle: VectorL10n.versionCheckModalSubtitleSupported,
subtitle: VectorL10n.versionCheckModalSubtitleSupported(InfoPlist.cfBundleDisplayName, InfoPlist.cfBundleDisplayName),
actionButtonTitle: VectorL10n.versionCheckModalActionTitleSupported))
}