Instrument missing screen metrics (#5764)

* Instrument missing screen metrics

- Done
This commit is contained in:
Gil Eluard
2022-03-08 10:13:46 +01:00
committed by GitHub
parent 35a330c74e
commit acf7d0de13
56 changed files with 269 additions and 246 deletions
@@ -39,11 +39,11 @@ final class RoomInfoCoordinator: NSObject, RoomInfoCoordinatorType {
participants.enableMention = true
participants.mxRoom = self.room
participants.delegate = self
participants.screenTimer = AnalyticsScreenTimer(screen: .roomMembers)
participants.screenTracker = AnalyticsScreenTracker(screen: .roomMembers)
let files = RoomFilesViewController()
files.finalizeInit()
files.screenTimer = AnalyticsScreenTimer(screen: .roomUploads)
files.screenTracker = AnalyticsScreenTracker(screen: .roomUploads)
MXKRoomDataSource.load(withRoomId: self.room.roomId, andMatrixSession: self.session) { (dataSource) in
guard let dataSource = dataSource as? MXKRoomDataSource else { return }
dataSource.filterMessagesWithURL = true
@@ -54,7 +54,7 @@ final class RoomInfoCoordinator: NSObject, RoomInfoCoordinatorType {
let settings = RoomSettingsViewController()
settings.finalizeInit()
settings.screenTimer = AnalyticsScreenTimer(screen: .roomSettings)
settings.screenTracker = AnalyticsScreenTracker(screen: .roomSettings)
settings.initWith(self.session, andRoomId: self.room.roomId)
if self.room.isDirect {
@@ -43,7 +43,7 @@ final class RoomInfoListViewController: UIViewController {
private var indicatorPresenter: UserIndicatorTypePresenterProtocol!
private var loadingIndicator: UserIndicator?
private var isRoomDirect: Bool = false
private var screenTimer = AnalyticsScreenTimer(screen: .roomDetails)
private var screenTracker = AnalyticsScreenTracker(screen: .roomDetails)
private lazy var closeButton: CloseButton = {
let button = CloseButton()
@@ -134,9 +134,9 @@ final class RoomInfoListViewController: UIViewController {
return self.theme.statusBarStyle
}
override func viewDidAppear(_ animated: Bool) {
super.viewDidAppear(animated)
screenTimer.start()
override func viewWillAppear(_ animated: Bool) {
super.viewWillAppear(animated)
screenTracker.trackScreen()
}
override func viewDidLayoutSubviews() {
@@ -147,7 +147,6 @@ final class RoomInfoListViewController: UIViewController {
override func viewDidDisappear(_ animated: Bool) {
super.viewDidDisappear(animated)
screenTimer.stop()
stopLoading()
}