From 755846a384ec4211b54475989164b623ec46bfe6 Mon Sep 17 00:00:00 2001 From: manuroe Date: Mon, 27 Sep 2021 17:06:36 +0200 Subject: [PATCH] Update PR template with a checkbox for accessibility and self review. --- .github/PULL_REQUEST_TEMPLATE.md | 12 +++++++----- changelog.d/4920.doc | 1 + 2 files changed, 8 insertions(+), 5 deletions(-) create mode 100644 changelog.d/4920.doc diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c45428232..d9c3901ec 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,10 @@ ### Pull Request Checklist -* [ ] I read the [contributing guide](https://github.com/vector-im/element-ios/blob/develop/CONTRIBUTING.md) -* [ ] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators +- [ ] I read the [contributing guide](https://github.com/vector-im/element-ios/blob/develop/CONTRIBUTING.md) +- [ ] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators +- [ ] Accessibility has been taken into account. * [ ] Pull request is based on the develop branch -* [ ] Pull request contains a [changelog file](https://github.com/matrix-org/matrix-ios-sdk/blob/develop/CONTRIBUTING.md#changelog) in ./changelog.d -* [ ] Pull request includes screenshots or videos of UI changes -* [ ] Pull request includes a [sign off](https://github.com/matrix-org/matrix-ios-sdk/blob/develop/CONTRIBUTING.md#sign-off) +- [ ] Pull request contains a [changelog file](https://github.com/matrix-org/matrix-ios-sdk/blob/develop/CONTRIBUTING.md#changelog) in ./changelog.d +- [ ] You've made a self review of your PR +- [ ] Pull request includes screenshots or videos of UI changes +- [ ] Pull request includes a [sign off](https://github.com/matrix-org/matrix-ios-sdk/blob/develop/CONTRIBUTING.md#sign-off) diff --git a/changelog.d/4920.doc b/changelog.d/4920.doc new file mode 100644 index 000000000..746bc48aa --- /dev/null +++ b/changelog.d/4920.doc @@ -0,0 +1 @@ +Update PR template with a checkbox for accessibility and self review. \ No newline at end of file