Cleanup from comments

This commit is contained in:
David Langley
2021-08-12 16:57:19 +01:00
parent 77144980e3
commit 82b0361647
9 changed files with 28 additions and 14 deletions
@@ -44,10 +44,11 @@ final class RoomNotificationSettingsCoordinator: RoomNotificationSettingsCoordin
let avatarData: AvatarInputOption?
let showAvatar = presentedModally
if #available(iOS 14.0.0, *) {
avatarData = showAvatar ? .swiftUI(AvatarInput(mxContentUri: room.summary.avatar,
itemId: room.roomId,
displayName: room.summary.displayname
)) : nil
avatarData = showAvatar ? .swiftUI(AvatarInput(
mxContentUri: room.summary.avatar,
itemId: room.roomId,
displayName: room.summary.displayname
)) : nil
} else {
avatarData = showAvatar ? .uiKit(RoomAvatarViewData(
roomId: room.roomId,
@@ -36,7 +36,7 @@ final class RoomNotificationSettingsViewModel: RoomNotificationSettingsViewModel
@available(iOS 14.0, *)
@Published var viewState: RoomNotificationSettingsViewState!
@available(iOS 14.0, *)
lazy var bag = Set<AnyCancellable>()
lazy var cancelables = Set<AnyCancellable>()
// MARK: Public
@@ -72,13 +72,13 @@ final class RoomNotificationSettingsViewModel: RoomNotificationSettingsViewModel
let avatarData = avatarData,
case let AvatarInputOption.swiftUI(data) = avatarData {
avatarService.avatarImage(inputData: data)
.sink{ image in
.sink { image in
var newState = self.state
newState.avatar = image
newState.displayName = data.displayName
self.state = newState
}
.store(in: &bag)
.store(in: &cancelables)
}
}
@@ -17,7 +17,6 @@
*/
import Foundation
import SwiftUI
protocol RoomNotificationSettingsViewModelViewDelegate: AnyObject {
func roomNotificationSettingsViewModel(_ viewModel: RoomNotificationSettingsViewModelType, didUpdateViewState viewState: RoomNotificationSettingsViewStateType)
@@ -29,7 +29,6 @@ struct FormSectionHeaderView: View {
.padding(.leading)
.padding(.bottom, 8)
.font(Font(theme.fonts.footnote))
.autocapitalization(.allCharacters)
.textCase(.uppercase)
}
}
@@ -27,7 +27,7 @@ struct RoomNotificationSettingsView: View {
@ViewBuilder
private var leftButton: some View {
if presentedModally {
SwiftUI.Button(VectorL10n.cancel) {
Button(VectorL10n.cancel) {
viewModel.process(viewAction: .cancel)
}
}