felixfoertsch/bundesmessenger-ios
1
0
Fork 0
mirror of https://gitlab.opencode.de/bwi/bundesmessenger/clients/bundesmessenger-ios.git synced 2026-04-19 08:03:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Implemented PSG-680 - Sessions overview security recommendations

Browse Source 
- remove uppercased strings from localizables
- moved inactivity computation to the service
This commit is contained in:
Stefan Ceriu
2022-09-27 16:51:13 +03:00
committed by Stefan Ceriu
parent 6585aaf523
commit 7eee1cceab
20 changed files with 369 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files
RiotSwiftUI/Modules/UserSessions/UserSessionOverview/MockUserSessionOverviewScreenState.swift
+8 -6
View File
@@ -41,22 +41,24 @@ enum MockUserSessionOverviewScreenState: MockScreenState, CaseIterable {
let viewModel: UserSessionOverviewViewModel
switch self {
case .currentSession:
let session = UserSessionInfo(sessionId: "session",
sessionName: "iOS",
let session = UserSessionInfo(id: "session",
name: "iOS",
deviceType: .mobile,
isVerified: false,
lastSeenIP: "10.0.0.10",
lastSeenTimestamp: Date().timeIntervalSince1970 - 100,
isCurrentSession: true)
isActive: true,
isCurrent: true)
viewModel = UserSessionOverviewViewModel(session: session)
case .otherSession:
let session = UserSessionInfo(sessionId: "session",
sessionName: "Mac",
let session = UserSessionInfo(id: "session",
name: "Mac",
deviceType: .desktop,
isVerified: true,
lastSeenIP: "10.0.0.10",
lastSeenTimestamp: Date().timeIntervalSince1970 - 100,
isCurrentSession: false)
isActive: true,
isCurrent: false)
viewModel = UserSessionOverviewViewModel(session: session)
}
RiotSwiftUI/Modules/UserSessions/UserSessionOverview/UserSessionOverviewViewModel.swift
+1 -1
View File
@@ -27,7 +27,7 @@ class UserSessionOverviewViewModel: UserSessionOverviewViewModelType, UserSessio
self.session = session
let cardViewData = UserSessionCardViewData(session: session)
let state = UserSessionOverviewViewState(cardViewData: cardViewData, isCurrentSession: session.isCurrentSession)
let state = UserSessionOverviewViewState(cardViewData: cardViewData, isCurrentSession: session.isCurrent)
super.init(initialViewState: state)
}